December 2011 - Wine-devel - list.winehq.org

Re: [1/6]usp10: code for the cmap format 12 table for unicode code points beyond the BMP
by Alexandre Julliard 19 Dec '11

19 Dec '11

Aric Stewart <aric(a)codeweavers.com> writes: > + while (k < GET_BE_DWORD(format->nGroups)) > + { > + if (GET_BE_DWORD(format->groups[k].startCharCode) > utf32c) > + break; > + if (GET_BE_DWORD(format->groups[k].endCharCode) < utf32c) > + k++; > + else > + { > + DWORD offset = utf32c - GET_BE_DWORD(format->groups[k].startCharCode); > + *pgi = GET_BE_DWORD(format->groups[k].startGlyphID) + offset; > + return 0; > + } You probably want a binary search. Also do we really need a new source file for such a small function? -- Alexandre Julliard julliard(a)winehq.org

1 0

Looking to implement msvcp90's basic_ifstream (and friends)
by Aaron Faanes 19 Dec '11

19 Dec '11

Howdy! I ran into this bug when running a game of mine, and it seemed doable for me. The bug is due to msvcp90 missing its file I/O stuff. Here's the link: http://bugs.winehq.org/show_bug.cgi?id=25966 My intention is to implement these classes as wrappers of ntdll's file I/O API. Is this the right approach, or is there another API that is more preferable? -- Aaron Faanes <dafrito(a)gmail.com>

2 5

Re: [PATCH] comdlg32: Correctly handle filters with multiple file extensions in Save As dialogs
by Marvin 19 Dec '11

19 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16032 Your paranoid android. === WNT4WSSP6 (32 bit filedlg) === filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;*.def)" === W2KPROSP4 (32 bit filedlg) === filedlg.c:1106: Test failed: Filename ends in est\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc)" filedlg.c:1106: Test failed: Filename ends in est\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;)" filedlg.c:1106: Test failed: Filename ends in est\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;*.def)" === WXPPROSP3 (32 bit filedlg) === filedlg.c:1106: Test failed: Filename ends in est\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc)" filedlg.c:1106: Test failed: Filename ends in est\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;)" filedlg.c:1106: Test failed: Filename ends in est\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;*.def)" === W2K3R2SESP2 (32 bit filedlg) === filedlg.c:1106: Test failed: Filename ends in est\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc)" filedlg.c:1106: Test failed: Filename ends in est\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;)" filedlg.c:1106: Test failed: Filename ends in est\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;*.def)" === WVISTAADM (32 bit filedlg) === filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;*.def)" === W2K8SE (32 bit filedlg) === filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;*.def)" === W7PRO (32 bit filedlg) === filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;*.def)" === W7PROX64 (32 bit filedlg) === filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;*.def)" === TEST64_W7SP1 (32 bit filedlg) === filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;*.def)" === W7PROX64 (64 bit filedlg) === filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;*.def)" === TEST64_W7SP1 (64 bit filedlg) === filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;)" filedlg.c:1106: Test failed: Filename ends in m32\deadbeef, expected deadbeef.abc from filter "TestFilter (*.abc;*.def)"

1 0

Re: wineconsole: Remove the character-width check as we need newer FreeType library.
by Eric Pouech 18 Dec '11

18 Dec '11

this doesn't solve the printing issue as the always infer that any char has the same size how is this printed on real windows with your character set ? A+ 2011/12/14 Akihiro Sagawa <sagawa.aki(a)gmail.com> > > This closes bug #10063. This check is needed for FreeType < 2.0.8, but > commit 570e68b82200bdd9981b2cd8fe9e68d35bad3cb9 updated the requirement, > 2.1.4 or later. And it is not useful for DBCS fonts, as they have two > different width (halfwidth and fullwidth) even in monospaced font such > as MS Gothic. > --- > programs/wineconsole/user.c | 34 ++-------------------------------- > 1 files changed, 2 insertions(+), 32 deletions(-) > > > > > -- -- Eric Pouech

2 2

Warning report for wine-1.3.35
by Jerome Leclanche 18 Dec '11

18 Dec '11

No more warnings on 32-bit :) I'm still getting "warning: variable ‘_qzz_res’ set but not used" from valgrind though (stripped from the report); does anyone know what's up with those? J. Leclanche

1 0

Debugging Wine with Lightroom 3.5
by Roland Baudin 17 Dec '11

17 Dec '11

Hi, let me first congratulate all the people who work hard on the Wine project : their work is much appreciated here... Now, my question : I was able to install and run Adobe Photoshop Lightroom 3.5 under wine 1.3.33 or 1.3.34. While it runs quite well and is fairly stable I have two major issues : - with Windows version set in winecfg to "Windows XP" (or below) the menu bar is hidden. However, clicking on the empty place of the menu bar partially reveals the menu items and they are functional. Moreover, other context menus (for example, right clicking on a picture and selecting Delete brings up the deletion dialog) are all working OK. - with Windows version set in winecfg to "Vista" (or higher) the menu bar is now visible and fully functional, but many context menus are not working anymore (for example, right clicking on a picture and selecting Delete does nothing now). [Note this problem is half known (see bug 18635 http://bugs.winehq.org/show_bug.cgi?id=18635) So the dilemma is : either set Windows version to XP and get fully functional context menu but a hidden menu bar, or set version to Vista and see the menu bar but get many context menus broken. I'd like to debug this situation so it would be nice if someone could point me to the right direction : - first I don't understand the relation between Windows versions and menu bar or dialogs. Is it related to different versions of the dlls or any other mechanism? - second, I noticed with XP version a lot of fixme:GetMenuInfo when running Lightroom. These messages don't appear with Vista version. I've tried to set up a patch (found on the Internet) that implement the GetMenuInfo function but this doesn't help. The patch seems to work but the menu bar is still hidden. - third, with Vista version, when invoking a broken menu, there is no particular message I can see on the terminal that could tell me what is not working. I've tried to play with various dll replacement but with no success. After googling and reading I suspect the problem is in the user32.dll and perhaps the DrawMenuBar implementation but I'm not sure... Any help (at least some clue to start debugging) would be greatly appreciated. Thanks, RB -- X File Explorer http://roland65.free.fr/xfe Toutes Choses http://roland65.free.fr/ttc

2 1

Would making the Wine file dialogs know about the Nautilus bookmarks be a reasonable thing?
by Scott Ritchie 17 Dec '11

17 Dec '11

Assuming you're running Gnome, as I'm not sure there's a freedesktop standard for the Bookmark feature yet (and perhaps there should be). In every Gnome nautilus window, save dialog, and file open dialog there's a standard set of folders you see on the side as quick links. Some are obvious, and we duplicate them (eg Desktop), others are automatic, like gvfs links to external hard disks. Users can also add their own. Would it be appropriate to display those self-added bookmarks in Wine? I'm worried there might be something I'm missing about the implementation that would make this difficult or a bad idea. Thanks, Scott Ritchie

4 3

Re: [PATCH 2/2] comdlg32: Widen buffer to accomodate Catalan translation
by Francois Gouget 17 Dec '11

17 Dec '11

On Fri, 16 Dec 2011, Alex Henrie wrote: > --- > dlls/comdlg32/filedlg.c | 2 +- [...] > - WCHAR buf[16]; > + WCHAR buf[17]; > LoadStringW(COMDLG32_hInstance, IDS_SAVE_AS, buf, sizeof(buf)/sizeof(WCHAR)); I don't think it makes sense to add room for just one more WCHAR. There's no telling how long a future Arabic or Panjabi translation might be. So either set the buffer size to something like 80, 128 or 256 characters (sucks 5, 8 and 16 times less respectively), or do away with the hardcoded buffer size altogether (overkill? rocks? both?<g>). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !

2 1

Re: [6/6]usp10: add Mathematical Alphanumeric Symbols script
by Marvin 16 Dec '11

16 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16023 Your paranoid android. === WVISTAADM (32 bit usp10) === usp10.c:532: Test failed: 0:Incorrect Script Tag 0 != 74727364 usp10.c:533: Test failed: 0:Incorrect Script Tag 0 != 616d736f usp10.c:534: Test failed: 0:Incorrect Script Tag 0 != 6874616d usp10.c:586: Test failed: 0:Incorrect Script Tag 0 != 74727364 usp10.c:587: Test failed: 0:Incorrect Script Tag 0 != 616d736f usp10.c:588: Test failed: 0:Incorrect Script Tag 0 != 6874616d usp10.c:640: Test failed: 0:Incorrect Script Tag 0 != 74727364 usp10.c:641: Test failed: 0:Incorrect Script Tag 0 != 616d736f usp10.c:642: Test failed: 0:Incorrect Script Tag 0 != 6874616d usp10.c:695: Test failed: 0:Incorrect Script Tag 0 != 74727364 usp10.c:696: Test failed: 0:Incorrect Script Tag 0 != 616d736f usp10.c:697: Test failed: 0:Incorrect Script Tag 0 != 6874616d === W2K8SE (32 bit usp10) === usp10.c:532: Test failed: 0:Incorrect Script Tag 0 != 74727364 usp10.c:533: Test failed: 0:Incorrect Script Tag 0 != 616d736f usp10.c:534: Test failed: 0:Incorrect Script Tag 0 != 6874616d usp10.c:586: Test failed: 0:Incorrect Script Tag 0 != 74727364 usp10.c:587: Test failed: 0:Incorrect Script Tag 0 != 616d736f usp10.c:588: Test failed: 0:Incorrect Script Tag 0 != 6874616d usp10.c:640: Test failed: 0:Incorrect Script Tag 0 != 74727364 usp10.c:641: Test failed: 0:Incorrect Script Tag 0 != 616d736f usp10.c:642: Test failed: 0:Incorrect Script Tag 0 != 6874616d usp10.c:695: Test failed: 0:Incorrect Script Tag 0 != 74727364 usp10.c:696: Test failed: 0:Incorrect Script Tag 0 != 616d736f usp10.c:697: Test failed: 0:Incorrect Script Tag 0 != 6874616d

1 0

About release 1.3.35
by GOUJON Alexandre 16 Dec '11

16 Dec '11

Am I the only one who noticed that the "Release 1.3.35" was authored by Frédéric Delanoy ? Who's the author (really) doesn't matter but having a commit from a gmail.com e-mail address instead of a winehq.org one (just) surprised me. Anyway, let's pull this latest wine version, compile and test it !

2 1