April 2011 - Wine-devel - list.winehq.org

Re: [PATCH 2/4] inetcpl: Fill the security listview with zones
by Nikolay Sivov 13 Apr '11

13 Apr '11

Some minor things regarding listview. On Wed, Apr 13, 2011 at 7:33 AM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > --- > dlls/inetcpl.cpl/security.c | 131 +++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 131 insertions(+), 0 deletions(-) > > +static void add_zone_to_listview(secdlg_data *sd, DWORD *pindex, DWORD zone) > +{ > + DWORD lv_index = *pindex; > + ZONEATTRIBUTES *za = &sd->zone_attr[lv_index]; > + LVITEMW lvitem; > + HRESULT hr; > + INT iconid = 0; > + HMODULE hdll = NULL; > + WCHAR * ptr; > + HICON icon; > + > + TRACE("item %d (zone %d)\n", lv_index, zone); > + > + sd->zones[lv_index] = zone; > + > + memset(&lvitem, 0, sizeof(LVITEMW)); This reset shouldn't be needed, cause control checks for mask field and doesn't access other fields. > + > + if (ListView_InsertItemW(sd->hlv, &lvitem) >= 0) { > + /* activate first item in the listview */ > + if (! lv_index) { > + lvitem.state = LVIS_FOCUSED | LVIS_SELECTED; > + lvitem.stateMask = LVIS_FOCUSED | LVIS_SELECTED; > + SendMessageW(sd->hlv, LVM_SETITEMSTATE, 0, (LPARAM) &lvitem); > + } > + SendMessageW(sd->hlv, LVM_SETIMAGELIST, LVSIL_NORMAL, (LPARAM)sd->himages); > + You could use macros here too, if you prefer that.

1 0

po: Update US English resource
by Ken Sharp 13 Apr '11

13 Apr '11

http://www.winehq.org/pipermail/wine-devel/2011-April/089585.html (I lost the original mail - along with a bunch of others) I'm confused as to what the .po files are for. ise/ize will be correct if the .rc file default is British English. Without updating the .po file for US English I don't see how else this can be updated - unless it is simply the way it was before with LANG_ and SUBLANG_, but then what are the .po files for? I can't find any details in the Wiki and I'm afraid I wasn't around when they were introduced...

1 0

ntdll: Add support for Windows XP 64-bit
by Ken Sharp 13 Apr '11

13 Apr '11

Morning all, Could someone far smarter than me please take a look at the attached patch? Windows XP 64-bit runs NT kernel 5.2, whereas 32-bit runs 5.1. Any 64-bit app expecting XP 64-bit will fail (such as IE8 for NT 5.2). The patch lets the installer continue, but I'm not sure if it is enough to be accepted. For example, do I need to "winxp,winxp64", here? http://source.winehq.org/source/dlls/ntdll/version.c?v=wine-1.3.17#L172 TIA, Ken.

1 0

Re: wined3d: Track when the FBO is dirty. (try 3)
by Henri Verbeet 12 Apr '11

12 Apr '11

On 7 April 2011 18:51, Adam Martinson <amartinson(a)codeweavers.com> wrote: > - context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + > + if (rt_count == device->adapter->gl_info.limits.buffers && > + rts == device->render_targets && > + depth_stencil == device->depth_stencil) > + { > + if (context->device_fbo != NULL) > + { > + context_apply_device_fbo(context); > + } > + else > + { > + context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + context->device_fbo = context->current_fbo; > + } > + } > + else > + { > + context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + } That's not very pretty. > @@ -6709,6 +6721,7 @@ void device_resource_released(struct IWineD3DDeviceImpl *device, struct wined3d_ > { > ERR("Surface %p is still in use as render target %u.\n", surface, i); > device->render_targets[i] = NULL; > + fbo_dirty = TRUE; > } > } > > @@ -6716,7 +6729,10 @@ void device_resource_released(struct IWineD3DDeviceImpl *device, struct wined3d_ > { > ERR("Surface %p is still in use as depth/stencil buffer.\n", surface); > device->depth_stencil = NULL; > + fbo_dirty = TRUE; That code should never execute, hence the ERR.

2 3

Re: [2/2] comctl32/tab: Use dpa to store item data
by Henri Verbeet 12 Apr '11

12 Apr '11

On 10 April 2011 07:56, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > Use dpa to store item data > This seems to break text on winecfg tabs for me.

3 4

Re: user32: Fix the single menu item activation using a hot key.
by Marvin 12 Apr '11

12 Apr '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10449 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

__CxxFrameHandler unsupported on wine64?
by Peter Urbanec 12 Apr '11

12 Apr '11

I have an application that requires MFC80.DLL. When I install only the MFC80.DLL file from the vcredist package, I end up with the following errors: wine: Call from 0x7fd606a3148b to unimplemented function MSVCR80.dll.__CxxFrameHandler, aborting So, I had a quick look at the wine source and found a comment in dlls/msvcrt/cppexcept.c that says: /* CxxFrameHandler is not supported on non-i386 */ I don't think that this is quite right, given that Microsoft's MFC80.DLL attempts to call __CxxFrameHandler. Is it more likely that wine only provides an i386 implementation? If so, is there any chance that someone may be able to provide x86_64 implementation in the near future? It's way over my head :-( Best regards, Peter Urbanec

2 1

Re: [3/3] wined3d: only acquire a context in buffer::PreLoad if we have to
by Henri Verbeet 12 Apr '11

12 Apr '11

You can't just resend this unmodified if you're leaving buffer creation in.

2 1

Re: [PATCH 4/4] d3d9: COM cleanup for the IDirect3DSwapChain9 iface.
by Michael Stefaniuc 12 Apr '11

12 Apr '11

Please ignore this patch for now as it conflicts with Henri's patch. bye michael On 04/12/2011 10:23 AM, Michael Stefaniuc wrote: > --- > dlls/d3d9/d3d9_private.h | 7 ++--- > dlls/d3d9/device.c | 8 +++--- > dlls/d3d9/swapchain.c | 61 ++++++++++++++++++++++++++++++---------------- > 3 files changed, 47 insertions(+), 29 deletions(-)

1 0

Re: dbghelp: get rid of a couple unused variables (try 2)
by Eric Pouech 11 Apr '11

11 Apr '11

Le 11/04/2011 19:07, Austin English a écrit : IMO, you should keep the variable names in comment so that we know what we're talking about: /* version = */ dwarf2_parse_u2(&ctx); or dwarf2_parse_u2(&ctx); /* version */ A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0