July 2011 - Wine-devel - list.winehq.org

Re: msvcrt/tests: Remove dead assignment (Clang)
by Octavian Voicu 07 Jul '11

07 Jul '11

2011/7/7 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > c = outbuffer[sizeof(outbuffer) - 1]; > ok(ungetc(c, file) == c, "ungetc did not return its input for bufmode=%x\n", bufmodes[bufmode]); > ok(!feof(file), "feof after ungetc returned EOF for bufmode=%x\n", bufmodes[bufmode]); > - ok((c = fgetc(file)) != EOF, "getc after ungetc returned EOF for bufmode=%x\n", bufmodes[bufmode]); > + ok(fgetc(file) != EOF, "getc after ungetc returned EOF for bufmode=%x\n", bufmodes[bufmode]); > ok(c == outbuffer[sizeof(outbuffer) - 1], > "getc did not return ungetc'd data for bufmode=%x\n", bufmodes[bufmode]); Also, this change doesn't look like it's removing a dead assignment, but it does make the test ok(c == outbuffer[sizeof(outbuffer) - 1], ...) always succeed. Octavian

2 1

Re: [PATCH 2/2] mshtml: Mark some functions as cdecl.
by Juan Lang 07 Jul '11

07 Jul '11

Hi Jacek, > These are functions that I missed when revieweing Gecko headers. I will > probably change their calling convention in the next Gecko release. In that case, why not change the calling convention now? The matrix of possible configurations is much simpler that way. Right now, we have: current Wine + current gecko = crash By changing the calling convention in Wine, we have: Wine <= 1.3.23 + current gecko = crash Wine 1.3.24-?? + current gecko = no crash Wine ?? + current gecko = crash Wine ?? + new gecko = no crash Wine <= 1.3.23 + new gecko = crash By doing a new gecko release, we have: any Wine + current gecko = crash any Wine + new gecko = no crash --Juan

2 3

Re: [PATCH 1/2] kernel32: Fixes various 'profile' functions (profile.c). (try 3)
by Alexandre Julliard 07 Jul '11

07 Jul '11

Christian Inci <chris.pcguy.inci(a)gmail.com> writes: > kernel32: Fixes various 'profile' functions. > Try 2: Formatting change. > Try 3: Splitted tests/profile.c patch You can't split it that way. What you need is to split each separate fix together with its own test fix. Also please use a subject message that describes what you are fixing, not just "fixes various functions". -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext
by Nikolay Sivov 07 Jul '11

07 Jul '11

On Thu, Jul 7, 2011 at 2:09 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext > + ICreateTypeInfo2Impl *This = impl_from_ICreateTypeInfo2(iface); + + TRACE("(%p,%d), stub!\n", iface, dwHelpStringContext); It's not a stub anymore. + + This->typelib->typelib_header.helpcontext = dwHelpStringContext; Could you please get rid of this ugly naming here and use something like 'context' for variable. + + return S_OK; } > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

Re: msxml3: Don't format xml output if we should be preserving whitespace.
by Marvin 06 Jul '11

06 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12283 Your paranoid android. === W2KPROSP4 (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === WXPPROSP3 (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === WVISTAADM (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === W2K8SE (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === W7PRO (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root>

1 0

Re: kernel32: Fixes various 'profile' functions.
by André Hentschel 06 Jul '11

06 Jul '11

spotted with a quick look on it: Am 06.07.2011 18:54, schrieb Christian Inci: > kernel32: Fixes various 'profile' functions. > > diff --git a/dlls/kernel32/profile.c b/dlls/kernel32/profile.c > index a2bd5b5..da7661c 100644 > --- a/dlls/kernel32/profile.c > +++ b/dlls/kernel32/profile.c > @@ -316,6 +316,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > PROFILESECTION **next_section; > PROFILEKEY *key, *prev_key, **next_key; > DWORD dwFileSize; > + BOOL no_section = TRUE; > > TRACE("%p\n", hFile); > > @@ -440,6 +441,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > next_section = &section->next; > next_key = &section->key; > prev_key = NULL; > + no_section = FALSE; formatting! > @@ -1179,6 +1183,7 @@ INT WINAPI GetPrivateProfileStringA( LPCSTR section, LPCSTR entry, > ret = len - 1; > } > buffer[ret] = 0; > + buffer[ret+1] = 0; > } really? -- Best Regards, André Hentschel

1 0

Re: ws2_32: Remove dead assignment (Clang)
by Marcus Meissner 06 Jul '11

06 Jul '11

On Wed, Jul 06, 2011 at 10:34:45AM +0200, Frédéric Delanoy wrote: > --- > dlls/ws2_32/socket.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 4fc65ab..91aab01 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -5874,7 +5874,7 @@ SOCKET WINAPI WSAAccept( SOCKET s, struct WS_sockaddr *addr, LPINT addrlen, > { > case CF_ACCEPT: > if (addr && addrlen) > - addr = memcpy(addr, &src_addr, (*addrlen > size) ? size : *addrlen ); > + memcpy(addr, &src_addr, (*addrlen > size) ? size : *addrlen ); This is wrong. Keep the addrlen check. Ciao, Marcus

1 1

Re: shell32: Remove dead assignments (Clang)
by Nikolay Sivov 06 Jul '11

06 Jul '11

2011/7/6 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > dlls/shell32/shelllink.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c > index 07fe7aa..fff0e79 100644 > --- a/dlls/shell32/shelllink.c > +++ b/dlls/shell32/shelllink.c > @@ -1189,29 +1189,29 @@ static HRESULT WINAPI IPersistStream_fnSave( > Stream_WriteLocationInfo( stm, This->sPath, &This->volume ); > > if( This->sDescription ) > - r = Stream_WriteString( stm, This->sDescription ); > + Stream_WriteString( stm, This->sDescription ); > This is questionable. If you write to a provided stream it's ok for it to fail write operation, this needs a test. Method return value should probably reflect write failure.

1 0

Re: [PATCH] ntdll/tests: Added tests for ObjectTypeInformation class in NtQueryObject
by Vitaliy Margolen 06 Jul '11

06 Jul '11

On 07/05/2011 07:20 PM, Austin Lund wrote: > + todo_wine ok( len>= sizeof(UNICODE_STRING) + 88 + sizeof(type_event) + sizeof(WCHAR), "unexpected len %u\n", len ); What is that magic number "88"? If it's a size of some structure - then please use it explicitly. Vitaliy.

1 0

Re: [1/10] dinput: Implement IDirectInput::RunControlPanel.
by Vitaliy Margolen 06 Jul '11

06 Jul '11

On 07/05/2011 06:18 AM, Andrew Nguyen wrote: > --- > dlls/dinput/dinput_main.c | 15 ++++++++- > dlls/dinput/tests/Makefile.in | 1 + > dlls/dinput/tests/dinput.c | 69 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 84 insertions(+), 1 deletions(-) > create mode 100644 dlls/dinput/tests/dinput.c Patches look good to me. Vitaliy.

1 0