September 2011 - Wine-devel

Re: [PATCH 05/17] vbscript: Added interp_lteq implementation
by Marvin 19 Sep '11

19 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14379 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 04/17] vbscript: Added interp_lt implementation
by Marvin 19 Sep '11

19 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14378 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 03/17] vbscript: Added interp_gt implementation
by Marvin 19 Sep '11

19 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14377 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 02/17] vbscript: Added interp_gteq implementation
by Marvin 19 Sep '11

19 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14376 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: comctl32: Don't crash when getting a bad image list handle.
by Alexandre Julliard 19 Sep '11

19 Sep '11

Francois Gouget <fgouget(a)codeweavers.com> writes: > @@ -3587,7 +3588,15 @@ static const IImageListVtbl ImageListImpl_Vtbl = { > > static inline BOOL is_valid(HIMAGELIST himl) > { > - return himl && himl->lpVtbl == &ImageListImpl_Vtbl; > + __TRY > + { > + return himl && himl->lpVtbl == &ImageListImpl_Vtbl; > + } > + __EXCEPT_PAGE_FAULT > + { > + return FALSE; > + } > + __ENDTRY You can't return from a __TRY block. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ieframe/tests: Skip some tests on Windows if WebBrowser is not supported.
by Jacek Caban 18 Sep '11

18 Sep '11

On 09/16/11 15:25, Francois Gouget wrote: > --- > > This fixes this test on the WNT4WSSP6 testbot machine. > It also helps on my NT4 VM but one would not notice because there's no > ieframes dll so WineTest does not even try to run this test! > > dlls/ieframe/tests/webbrowser.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/dlls/ieframe/tests/webbrowser.c b/dlls/ieframe/tests/webbrowser.c > index a36c134..0506be6 100644 > --- a/dlls/ieframe/tests/webbrowser.c > +++ b/dlls/ieframe/tests/webbrowser.c > @@ -212,7 +212,10 @@ static HRESULT _create_WebBrowser(unsigned line, IUnknown **unk) > > hres = CoCreateInstance(&CLSID_WebBrowser, NULL, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, > &IID_IUnknown, (void**)unk); > - ok_(__FILE__,line)(hres == S_OK, "Creating WebBrowser object failed: %08x\n", hres); > + if (hres == REGDB_E_CLASSNOTREG) > + win_skip_(__FILE__,line)("WebBrowser is not supported\n"); > + else > + ok_(__FILE__,line)(hres == S_OK, "Creating WebBrowser object failed: %08x\n", hres); > return hres; > } The failure is valid here, it's the testbot that is not smart enough. The tested DLL is not present on WINNT, so the test should be skipped automatically, like winetest does. Jacek

2 3

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3)
by Marvin 18 Sep '11

18 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14371 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

re: msxml3: Fix printing NULL strings
by Dan Kegel 18 Sep '11

18 Sep '11

Hi Francois, your patch has a signedness problem which makes -Werror unhappy. (We could disable signedness warnings, but since we don't currently have any, it's nice to keep them out of the tree...) Here's the log from the buildbot: $ ccache gcc -c -I. -I. -I../../include -I../../include -I/usr/include/libxml2 -I/usr/include/libxml2 -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -Werror -o element.o element.c cc1: warnings being treated as errors element.c: In function ‘variant_from_dt’: element.c:666: error: pointer targets in passing argument 1 of ‘debugstr_a’ differ in signedness ../../include/wine/debug.h:259: note: expected ‘const char *’ but argument is of type ‘const xmlChar *’ element.c: In function ‘element_get_dt’: element.c:732: error: pointer targets in passing argument 1 of ‘debugstr_a’ differ in signedness ../../include/wine/debug.h:259: note: expected ‘const char *’ but argument is of type ‘const xmlChar *’ element.c: In function ‘domelem_put_nodeTypedValue’: element.c:789: error: pointer targets in passing argument 1 of ‘debugstr_a’ differ in signedness ../../include/wine/debug.h:259: note: expected ‘const char *’ but argument is of type ‘const xmlChar *’ element.c: In function ‘domelem_put_dataType’: element.c:937: error: pointer targets in passing argument 1 of ‘debugstr_a’ differ in signedness ../../include/wine/debug.h:259: note: expected ‘const char *’ but argument is of type ‘const xmlChar *’ make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/msxml3' make[1]: *** [element.o] Error 1 make: *** [dlls/msxml3] Error 2

2 1

Re: quartz/tests: Skip some tests if not allowed to register filters.
by Marvin 18 Sep '11

18 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14367 Your paranoid android. === WNT4WSSP6 (32 bit filtermapper) === filtermapper.c:93: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:230: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:344: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:402: Test failed: CoCreateInstance failed with 80040154

2 1

Re: shell32: Don't dereference NULL pointers when tracing.
by Octavian Voicu 18 Sep '11

18 Sep '11

On Sun, Sep 18, 2011 at 8:37 PM, Francois Gouget <fgouget(a)free.fr> wrote: > + TRACE("-- vmode %#x, flags %#x", view_params->pfs->ViewMode, view_params->pfs->fFlags); > + if (view_params->prcView) > + TRACE(", left %d, top %d, right %d, bottom %d", view_params->prcView->left, > + view_params->prcView->top, view_params->prcView->right, view_params->prcView->bottom); > + TRACE("\n"); I think it would look much nicer with wine_dbgstr_rect and it can handle NULL pointers. Octavian

1 0