September 2011 - Wine-devel

Re: [patch] Support NULL puLen in VerQueryValue
by Andrew Nguyen 15 Oct '11

15 Oct '11

On 01/03/2011 09:25 PM, Rafael Ávila de Espíndola wrote: > I couldn't find any documentation saying that this must be supported, > but running google code search on VerQueryValue.*NULL found some uses. > > Cheers, > Rafael > > > > You should write some tests to examine the behavior of VerQueryValue with NULL puLen.

3 2

[patch] Fake display interface
by Jari Vetoniemi 06 Oct '11

06 Oct '11

Yeah, I'm aware of virtual desktop and used to create scripts to launch applications using wine explorer \desktop=WIDTHxHEIGHT or whatever the parameters were, it works well. But means that you have to create always new shell script, and it also can prevent desktop integration for certain application. If you globally enable that also, it means that every application opens on the same virtual desktop. Also virtual desktop won't fake the display resolutions to application which is useful in certain cases. 2011/9/2 Hin-Tak Leung <hintak_leung(a)yahoo.co.uk>: > --- On Fri, 2/9/11, Jari Vetoniemi <mailroxas(a)gmail.com> wrote: > >> Hello, >> >> I personally hate when applications decide to change my >> screen >> resolution without asking me, or some applications just >> won't run >> inside window. >> So I did fake display interface for the winex11.drv. It >> allows you to >> send any display resolution and frequency to the >> application, but it >> does not change resolution. >> It's small and simple patch, and won't probably ever be >> included into >> the mainline wine. However I'll post it here as it might be >> useful for >> some. >> >> To enable, create string key UseFakeDisp with value Y in >> H_C_U/Software/Wine/X11 Driver >> Default fake resolution is 800x600 60HZ, you can change >> default with >> registry keys FakeDispHeight, FakeDispWidth, FakeDispFreq >> You can also use env variable >> WINE_FAKEDISP=WIDTHxHEIGHT_FREQ (eg. >> WINE_FAKEDISP=1024x768_60) >> >> Might improve it later to use the same syntax for default >> resolution >> and allow multiple fake resolutions to be defined with ; >> separator. >> This is also useful for dual head setups where you may want >> to run >> game or application fullscreen on other monitor while still >> keeping >> the other alive. >> There is also interesting side effect: While some >> applications throw >> error or won't run on resolutions they don't support, some >> applications that don't support them still run with the >> resolution >> specified. Eg. I can run Ys games with 1440x900 resolution >> where they >> normally would not run, and they look great. > > In winecfg there is a way of configuring wine to run under its own desktop window (and having any window application's windows running inside that), instead of having the unix host's window manager managing the window application's window. Have you tried using that? Granted it is a bit awkward for what you want to do (having to go into winecfg to change the desktop's resolution and resetting it afterwards, instead of passing the resolution in per application), but may be improving on that functionality in winecfg could get your code included eventually somehow. >

3 8

Favorite bug: deadlock preventing backtraces?
by Dan Kegel 30 Sep '11

30 Sep '11

On one of my boxes, if I run winmm/midi.ok in a loop, it will eventually deadlock/crash ( http://bugs.winehq.org/show_bug.cgi?id=28388 ): err:ntdll:RtlpWaitForCriticalSection section 0x110060 "heap.c: main process heap section" wait timed out in thread 0022, blocked by 001f, retrying (60 sec) wine: Critical section 00110060 wait failed at address 0x7bc3484a (thread 0022), starting debugger... err:ntdll:RtlpWaitForCriticalSection section 0x110060 "heap.c: main process heap section" wait timed out in thread 0022, blocked by 001f, retrying (60 sec) Sadly, no backtrace follows ( http://bugs.winehq.org/show_bug.cgi?id=28265 ). Since I'm not around when it finally happens, I haven't tried btall yet. I suppose I should write a shell script to watch for that error message in the log, and run btall then... any better ideas? (I did try giving winedbg a private heap, didn't seem to prevent the deadlock.)

2 2

Using ApiTrace to improve D3D/OpenGL performance
by Emanuele Oriani 30 Sep '11

30 Sep '11

Dear all, Just wanted to bring to your attention ApiTrace 2.0, http://zrusin.blogspot.com/2011/09/apitrace-20.html . Apparently this tool is quite fast and should allow to play back GL commands, to analyse performance and replay commands. This might be useful to understand where some bottlenecks of wined3d might be? What do you think? Cheers

2 2

design comments in code or in tests?
by Joerg-Cyril.Hoehle＠t-systems.com 30 Sep '11

30 Sep '11

Hi, here's another one you WineConf folks may want to discuss. I've already expressed that there are not enough comments in mmdevapi's code. I thought about adding some, but wondered whether there's any value in using the header format that old code in Wine uses/used for automated doc. Generation (whatever the exact format was). For instance, comments ought to document GetPosition's contract in sufficient detail: - 0 <= GetPosition <= sum of written samples (modulo Frequency) - underruns don't count, it's no wall clock - monotically increasing(?) - should reflect speaker position, not buffering (MSDN says that) Don't look up MSDN. If that were complete enough, I would not have had the need to write as many tests as I did. Then I thought about placing comments in dlls/*/tests/ instead, because the test code is thrown away less often than the dll code. Seriously. Regards, Jörg Höhle

1 0

Subject: [PATCH 1/2 (try2)] mmdevapi: Don't fail if dwChannelMask is not set correctly
by Joerg-Cyril.Hoehle＠t-systems.com 30 Sep '11

30 Sep '11

Hi, Andrew Eikum writes: >(try2): Remove the test found by testbot. My Win7 Home VM passed that >test, so it seems we can expect any behavior. I object to the removal of the test like that. It should be replaced with a comment to explain that the behaviour of IsFormatSupported is very surprising, hence skipped. Actually, that behaviour begs for even more tests to understand what's going on. So far I believed in the invariant: IsFormatSupported == S_OK <=> Initialize == S_OK which is verified using all standard formats (1-2 channels), with one exception on testbot: render.c:396: Initialize (1, 48000x16x1) returns 8889000f unlike IsFormatSupported ^1^ means in exclusive mode, and only there. Now you experienced A. on testbot: IsFormatSupported(dwChannelMask==FFFF) == S_OK, like Initialize which conforms to the above invariant and simply suggests that ChannelMask is not checked at all, therefore this code in Wine seems too much: + fmtex->dwChannelMask != 0 && + fmtex->dwChannelMask != get_channel_mask(pwfx->nChannels)) B. your own Win7 Home system, with dwChannelMask=ffff, IsFormatSupported returns + ok(hr == S_FALSE || hr == AUDCLNT_E_UNSUPPORTED_FORMAT while Initialize returns + ok(hr == S_OK, which is weird. When does IFS return UNSUPPORTED_FORMAT? When does it return S_FALSE? In the latter case, is the suggested format anything else than GetMixFormat? What does exclusive mode return? Unlike in Wine, the shared mode "audio engine" mixer is a completely different SW entity than the exclusive mode "audio device", so it's important to check both. This needs more testing. In particular, tests performed on HW that supports more than 2 channels are welcome. Based on your surprising test result, I'd guess yours is such a system. Unlike DSound, mmdevapi has no GetSpeakerConfig that I'm aware of (short of Device Topology), so I don't know how apps find out about multi-channel abilities. BTW, I believe + fmtex->dwChannelMask != get_channel_mask(pwfx->nChannels)) in Wine is bogus anyway, because it's arbitrary. There exist different 3/4/5/6 channel configurations. Regards, Jörg Höhle

1 0

winscard
by Vincent Hardy 30 Sep '11

30 Sep '11

Hi all, Here are four patches that are a partial but functional implementation of winscard. I installed "Belgian Electronic Identity Card MiddleWare" (http://eid-mw.googlecode.com/files/BeidMW35-6995.msi) I tested winscard by starting beid35gui.exe and I can see my identity card data. Moreover, this should help to solve this bug http://bugs.winehq.org/show_bug.cgi?id=26978. Are these 4 patches good enough to be sent to wine-patch ? winscard is really useful for me and probably for other people too. Vincent

5 4

Re: user32: Prioritize focus for dialog owner on EndDialog.
by Marvin 30 Sep '11

30 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14644 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

2 1

Buildbot status
by Dan Kegel 30 Sep '11

30 Sep '11

The buildbot is alive and well and has been finding real problems of various sorts roughly once a day for some time. I'm not spending much time on it anymore, just watching and tweaking occasionally. The number of spurious failures is tapering off as I slowly expand the blacklist and polish up the scripts. I plan to turn on email notifications to wine-devel once there have been no spurious failure reports for five days, probably sometime in October. http://wiki.winehq.org/BuildBot is up to date in case anyone's interested in details.

4 6

Re: [1/3] kernel32: Reset LastError if GetModuleFileName() succeeds.
by Francois Gouget 29 Sep '11

29 Sep '11

On Fri, 30 Sep 2011, Francois Gouget wrote: > This is necessary because LastError may already be set to > ERROR_INSUFFICIENT_BUFFER which would mislead the caller. And of course the older versions of Windows (up to XP SP3!) don't reset lasterror so the test bit of the patch cannot go in. I'd still argue that GetModuleFileNameW() should reset LastError though. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0