September 2011 - Wine-devel

Re: [PATCH 13/21] vbscript: Added interp_neg implementation
by Marvin 12 Sep '11

12 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14155 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 08/21] vbscript: Added hex literal implementation
by Marvin 12 Sep '11

12 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14153 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 07/21] vbscript: Added interpreter support for numeric literals
by Marvin 12 Sep '11

12 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14152 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Marking test cases as flaky?
by Dan Kegel 12 Sep '11

12 Sep '11

Hi folks, I've been running "make test" a lot lately, and occasionally (it happened five times today), a test will fail out of the blue, in one out of twenty or a hundred runs. It would be bad form for buildbot to reject a patch because of a spurious test failure, so I've been making a list of tests that fail, adding to it each time I run into a test that fails occasionally, and skipping the tests on that list during "make test". This is all fine... but one of the tests that fails occasionally is ddraw/visual.ok (see http://bugs.winehq.org/show_bug.cgi?id=28301 ). It really doesn't feel right to skip that entirely just because a few particular pixel comparisons fail sometimes. Plan A would be to fix the tests to not be flaky, but that's hard, and the buildbot needs a quick solution. Plan B might be to conditionally compile the flaky tests away, e.g.: --- a/dlls/ddraw/tests/visual.c +++ b/dlls/ddraw/tests/visual.c @@ -1490,6 +1490,7 @@ static void D3D1_TextureMapBlendTest(void) ok(hr == D3D_OK, "IDirect3DDevice3_EndScene failed, hr = %08x\n", hr); } +#ifndef WINE_SKIP_FLAKY_TEST_SEE_BUG_28301 color = D3D1_getPixelColor(DirectDraw1, Surface1, 5, 5); red = (color & 0x00ff0000) >> 16; green = (color & 0x0000ff00) >> 8; @@ -1513,6 +1514,7 @@ static void D3D1_TextureMapBlendTest(void) green = (color & 0x0000ff00) >> 8; blue = (color & 0x000000ff); ok(red == 0 && green == 0 && blue == 0xff, "Got color %08x, expected 000000ff or near\n", color); +#endif Then my blacklist would mostly be a bunch of -D definitions in CFLAGS, one per flaky test. Or we could use a single define for all flaky tests. I may try that privately, to increase buildbot's test coverage. Would something like that be useful for other people, or should I just stick with private patches? - Dan

4 8

Re: [PATCH] cmd: Add help info for xcopy
by Frédéric Delanoy 12 Sep '11

12 Sep '11

On Fri, Sep 9, 2011 at 09:16, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > > --- a/programs/cmd/builtins.c > +++ b/programs/cmd/builtins.c > @@ -68,7 +68,8 @@ static const WCHAR parmNoY[] = {'/','-','Y','\0'}; > static const WCHAR nullW[] = {'\0'}; > > const WCHAR externals[][10] = { > - {'A','T','T','R','I','B','\0'} > + {'A','T','T','R','I','B','\0'}, > + {'X','C','O','P','Y','\0'} Patch is OK, but for consistency, shouldn't the externals be put at the start of wcmdmain.c, just after the inbuilt[][]10]? This way, you could see directly which command is built-in, and which is external. Frédéric

3 3

Re: notepad: Die if we get an unknown encoding name in load_encoding_name().
by Octavian Voicu 11 Sep '11

11 Sep '11

On Mon, Sep 12, 2011 at 12:22 AM, Francois Gouget <fgouget(a)free.fr> wrote: > - assert(0 && "bad encoding in load_encoding_name"); > + assert("bad encoding in load_encoding_name"); Hello, assert() is a debug macro which generates some code such that, during runtime: if the argument is non-zero, nothing happens; if the argument is zero, a message like "Assertion `X' failed" is printed (where X is exactly the expression that was given as an argument to assert, string-ified). assert(X) is something like: "I assert that at this point in the code, X holds; if you get there and X doesn't hold, tell me and abort the program". So assert(0 && "msg") will always trigger an assertion failure and tell you something like "Assertion `0 && "msg"' failed" then exit, which is good. If you change it to assert("msg"), condition will always be true so assertion will never be triggered. Octavian

2 1

re: [PATCH 2/4] ntdll: Colon character is not allowed in dir/filenames
by Dan Kegel 11 Sep '11

11 Sep '11

Hi Frédéric, fails a test here: ../../../tools/runtest -q -P wine -M cryptnet.dll -T ../../.. -p cryptnet_test.exe.so cryptnet.c && touch cryptnet.ok fixme:cryptnet:CryptGetObjectUrl unimplemented for 0 cryptnet.c:444: Test failed: Expected ERROR_FILE_NOT_FOUND or ERROR_PATH_NOT_FOUND, got 123 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 11, 2011 at 3:14 PM Subject: Re: 78678: Subject: [PATCH 2/4] ntdll: Colon character is not allowed in dir/filenames To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-default-x86_64 while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default-x86_64/builds/44 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: wpp: Shed an unused parameter from generic_msg. (RESEND)
by Alexandre Julliard 11 Sep '11

11 Sep '11

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > I sent basically this in February without any feedback, and it still > applies. It's still wrong, the parameter is used inside the #ifdef. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 2)
by Marvin 11 Sep '11

11 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14145 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

Re: shell32/tests: Make test explicit about return pointer
by Marvin 11 Sep '11

11 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14136 Your paranoid android. === WVISTAADM (32 bit shelldispatch) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0