January 2012 - Wine-devel - list.winehq.org

Re: mscoree: Implement DllGetClassObject (try 3)
by Vincent Povirk 13 Jan '12

13 Jan '12

+HRESULT create_monodata(REFIID riid, LPVOID *ppObj ) ... + IID iid; You mean clsid here, not riid, right? Otherwise, looks good to me.

1 0

Re: services: Avoid a race when service_entry is freed and process is terminated
by Piotr Caban 13 Jan '12

13 Jan '12

On 01/13/12 20:40, Piotr Caban wrote: > --- > programs/services/rpc.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > Please ignore this patch.

1 0

Mac OSX: Use existing Pictures/ Music/ Videos/ etc. directories
by Joerg-Cyril.Hoehle＠t-systems.com 13 Jan '12

13 Jan '12

Hi, winecfg on Mac OSX (10.5.6 and .7) does not link "My Videos" etc. to the equivalent directories on the Mac. Everything is linked to $HOME (or was it Desktop/?) instead. What a pity! See enhancement request/bug 19028 Wouldn't that be an easy patch for Wine+MacOS starters and a nice thing to have in wine-1.4 too? Thank you, Jörg Höhle

1 0

err:ntdll:RtlDeleteResource Deleting active MRSW lock, expect failure
by Joerg-Cyril.Hoehle＠t-systems.com 13 Jan '12

13 Jan '12

Hi, Does anyone know about this error? It sometimes occurs on a Linux machine after the mmdevapi capture tests exited, with a delay as if originating from the server (or a service.exe). Some capture logs sent to me contain this too. Looking up bugzilla, you'll find this error mentioned half a dozen times with various apps. Regards, Jörg Höhle

2 1

[PATCH 2/2] winealsa: Fix AudioCaptureClient Get/ReleaseBuffer protocol.
by Joerg-Cyril.Hoehle＠t-systems.com 13 Jan '12

13 Jan '12

Hi, I forgot to mention that with "winmm: GetCurrentPadding is superfluous while recording" in git, the ALSA patch 82525 can be applied to enforce strict checking of method sequencing: "winealsa: Fix AudioCaptureClient Get/ReleaseBuffer protocol" Regards, Jörg Höhle

1 0

Re: [PATCH 1/4] server: Add mechanism to store and retrieve information about a socket (try 2).
by Vitaliy Margolen 13 Jan '12

13 Jan '12

On 01/13/2012 12:05 AM, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Changelog: > server: Add mechanism to store and retrieve information about a socket. > > + > +/* Get and set user-accessible socket variables */ > +(a)REQ(get_socket_variable) > + obj_handle_t handle; /* handle to the socket */ > + unsigned int varcode; /* variable to return */ > + unsigned int varsize; /* size of variable to return */ > +(a)REPLY > + char ok; /* operation status */ > + int value; /* returned value of variable */ > +(a)END > + > +(a)REQ(set_socket_variable) > + obj_handle_t handle; /* handle to the socket */ > + unsigned int varcode; /* variable to set */ > + unsigned int varsize; /* size of variable to set */ > + int value; /* value of variable to set */ > +(a)REPLY > + char ok; /* operation status */ > +(a)END You are not using "ok" parameters in either of the calls. You should use status returned by wine_server_call_() for things like that. Also size seems to be redundant here. If it's an int - store it as int on both sides. This also implies you should use an array instead of struct for a storage. And drop size checks. One more thing, keep in mind that time_t is not unsigned int. But long. Vitaliy.

1 0

Re: kernel32: Specify the access rights when creating a file object.
by Alexandre Julliard 13 Jan '12

13 Jan '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > While investigating how to fix the file section access tests in kernel32 I've > found that some places in Wine deliberately create objects with access rights > set to 0, that leads to creation of potentially not accessible objects. Many of these are deliberate. You'll need test cases to show that you can require more permissions. -- Alexandre Julliard julliard(a)winehq.org

2 5

Re: [PATCH 1/4] server: Add mechanism to store and retrieve information about a socket (try 2).
by Alexandre Julliard 13 Jan '12

13 Jan '12

"Erich E. Hoover" <ehoover(a)mines.edu> writes: > Real Name: > Erich Hoover > > Description: > This patch implements storing of internal information about a > socket. The intent for this approach is to add a dynamic mechanism to > permit the storage of various variables that are accessible in user > space, such as storing of the connect() time (part 2). That's ugly, you don't need an arbitrary opaque variable storage mechanism. Just store the connect time and return it as such. Besides, you don't even need to set it from the client side, the server is notified on connect. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: Return correct background color
by Marvin 13 Jan '12

13 Jan '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16419 Your paranoid android. === WNT4WSSP6 (32 bit treeview) === treeview.c:638: Test failed: Default background color reported as 0xffffffff === W2KPROSP4 (32 bit treeview) === treeview.c:638: Test failed: Default background color reported as 0xffffffff === WXPPROSP3 (32 bit treeview) === treeview.c:638: Test failed: Default background color reported as 0xffffffff === W2K3R2SESP2 (32 bit treeview) === treeview.c:638: Test failed: Default background color reported as 0xffffffff === WVISTAADM (32 bit treeview) === treeview.c:638: Test failed: Default background color reported as 0xffffffff === W2K8SE (32 bit treeview) === treeview.c:638: Test failed: Default background color reported as 0xffffffff === W7PRO (32 bit treeview) === treeview.c:638: Test failed: Default background color reported as 0xffffffff === W7PROX64 (32 bit treeview) === treeview.c:638: Test failed: Default background color reported as 0xffffffff === TEST64_W7SP1 (32 bit treeview) === treeview.c:638: Test failed: Default background color reported as 0xffffffff === W7PROX64 (64 bit treeview) === treeview.c:638: Test failed: Default background color reported as 0xffffffff === TEST64_W7SP1 (64 bit treeview) === treeview.c:638: Test failed: Default background color reported as 0xffffffff

1 0

Re: po: Update French translation
by Francois Gouget 12 Jan '12

12 Jan '12

On Thu, 12 Jan 2012, Frédéric Delanoy wrote: [...] > #: appwiz.rc:64 > msgid "&Support Info" > -msgstr "Inf&ormations de support..." > +msgstr "Inf&ormations de support" I don't know why 'Information' was abbreviated in English. This should be checked and unabbreviated if it was abusive. But if it's because of a lack of space, for instance, then we should probably abbreviate it in French too (even if it means the spellchecker complains :-/). Besides that, thanks a lot for the patch. It looks like it's going to fix a lot of the issues reported on my wine-po site: http://fgouget.free.fr/wine-po/ Btw, if anyone feels like tackling some of them I'll gladly accept all the help I can get. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 2