January 2012 - Wine-devel - list.winehq.org

Re: dinput: Support INFINITE as number of effect iterations (try 2)
by Vitaliy Margolen 02 Feb '12

02 Feb '12

On 01/28/2012 05:56 PM, Marcel Hasler wrote: > According to the DirectX reference, IDirectInputEffect::Start accepts > INFINITE (aka -1) for the number of iterations. However, passing -1 to > Linux via input_event results in no effect being played at all. This > patch sets the number of iterations to the maximum signed value > allowed if INFINITE is passed. > > This fixes bug 29712. > > This patch supersedes patch 83233. It does the same thing but adds a > comment and should be easier to understand. In general looks good. Would be nice to point out that linux/input.h says that any durations should not exceed 0x7fff as a maximum value. Please don't make code "easier to read" by adding needless if / else. Your first patch was fine. Vitaliy.

2 5

Re: [PATCH 2/3] winecoreaudio: Implement the lock-free callback design.
by Andrew Eikum 01 Feb '12

01 Feb '12

On Mon, Jan 30, 2012 at 11:37:17AM +0100, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Fixes bug #29657 > While I like the idea of this patch and how you implemented it, I wonder if it's appropriate for code freeze. The main problem in that bug is that the CA driver can deadlock, or release memory out of order. When working on this patch, were you able to identify specifically where the contention is? The idea of the InTransition state was to handle the lock release in mid-call. Can we add a check for that state in the callbacks to solve this problem less intrusively? The first patch seems fine. Andrew

4 6

Updated clang-static-analyzer results (just in time for 1.4 ;))
by Austin English 01 Feb '12

01 Feb '12

Enjoy: http://www.mediafire.com/?aiomfk1cr9bc61y Using: wine-1.4-rc1-34-g01947e0 LLVM commit 683d1e1d449e6e790ff4c0b6340a4bbf144ff919 / git-svn-id: http://llvm.org/svn/llvm-project/llvm/trunk(a)149340 91177308-0d34-0410-b5e6-96231b3b80d8 austin(a)aw21 ~ $ sha1sum scan-build-2012-01-30-1.tar.bz2 8b3b2573c3595c805431b2ab40c6958805f37497 scan-build-2012-01-30-1.tar.bz2 -- -Austin

2 2

Re: quartz: If the MediaSeeking is not implemented all the way up the passthru chain fall back to the filtergraph's clock to find position.
by Alexandre Julliard 31 Jan '12

31 Jan '12

Aric Stewart <aric(a)codeweavers.com> writes: > Resolves bug Bug 25606 > --- > dlls/quartz/filtergraph.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M quartz.dll -T ../../.. -p quartz_test.exe.so filtergraph.c && touch filtergraph.ok wine: Unhandled page fault on read access to 0x00000000 at address 0x690fff17 (thread 0066), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x690fff17). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:690fff17 ESP:0032fc70 EBP:0032fcd8 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:69195fa4 ECX:0032fcb8 EDX:0012cc0c ESI:0032fd28 EDI:0012c878 Stack dump: 0x0032fc70: 0032fd28 69195fa4 0032fcd8 690fb648 0x0032fc80: 0012c878 0000000d 00000000 00000000 0x0032fc90: 0032fd34 0032fd3c 00000000 6877a314 0x0032fca0: 6877418e 0012c7c0 80004001 6877a314 0x0032fcb0: 6877418e 0032fd28 00000000 00000000 0x0032fcc0: 00000001 6877428a 690fb58b 6877a314 Backtrace: =>0 0x690fff17 MediaSeeking_GetCurrentPosition+0x137(iface=0x12c7c8, pCurrent=0x32fd28) [/home/julliard/wine/wine/dlls/quartz/filtergraph.c:2460] in quartz (0x0032fcd8) 1 0x6876ddea func_filtergraph+0x3a9() [/home/julliard/wine/wine/dlls/quartz/tests/filtergraph.c:284] in quartz_test (0x0032fd58) 2 0x68767392 main+0x3a1(argc=0, argv=(nil)) [/home/julliard/wine/wine/dlls/quartz/tests/../../../include/wine/test.h:556] in quartz_test (0x0032fe28) 3 0x68773865 __wine_spec_exe_entry+0x74(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in quartz_test (0x0032fe70) 4 0x6848cc4c call_process_entry+0xb() in kernel32 (0x0032fe88) 5 0x6848ddcf start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1083] in kernel32 (0x0032fec8) 6 0x6837a0b0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 7 0x6837cd9d call_thread_func+0x7c(entry=0x6848dd70, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2532] in ntdll (0x0032ffa8) 8 0x6837a08e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 9 0x6835219e start_process+0x1d(kernel_start=0x6848dd70) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x0032ffe8) 10 0x68028a9d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 0x690fff17 MediaSeeking_GetCurrentPosition+0x137 [/home/julliard/wine/wine/dlls/quartz/filtergraph.c:2460] in quartz: movl 0x0(%eax),%edx 2460 IReferenceClock_GetTime(This->refClock, &time); -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: crypt32: Only accept trailing NULLs in a certificate common name.
by Erich E. Hoover 31 Jan '12

31 Jan '12

On Tue, Jan 31, 2012 at 10:23 AM, Erich E. Hoover <ehoover(a)mines.edu> wrote: > On Tue, Jan 31, 2012 at 10:04 AM, Juan Lang <juan.lang(a)gmail.com> wrote: >> Sorry I didn't spot this earlier. Without this, someone who registers >> a certificate common name with an embedded NULL, like >> "codeweavers.com\0.badguy", could fool crypt32 into accepting it for a >> domain it isn't registered to, codeweavers.com in my example. > > It looks like you've just changed it to allow more than one NULL at > the end... It seems to me that the matching code already handles the > case of an embedded NULL, since it goes through the allowed_len > characters and manually checks each byte (rather than using a routine > like strcmp() which stops at NULLs). Please forgive the "Reply to all" fail. Erich Hoover ehoover(a)mines.edu

2 3

Warning report for wine-1.4-rc1
by Jerome Leclanche 31 Jan '12

31 Jan '12

Some new warnings. Inlining it instead of attaching it this time, I hope that's ok. ========== 32-bit ========== ccache gcc -msse4 -O3 -Wall -m32 -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o newstruc.o ../../../tools/wrc/newstruc.c ccache gcc -msse4 -O3 -Wall -m32 -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o po.o ../../../tools/wrc/po.c ../../../tools/wrc/po.c:127:12: warning: ‘string_has_context’ defined but not used [-Wunused-function] ========== 64-bit ========== ccache gcc -msse4 -O3 -Wall -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o newstruc.o ../../../tools/wrc/newstruc.c ccache gcc -msse4 -O3 -Wall -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o po.o ../../../tools/wrc/po.c ../../../tools/wrc/po.c:127:12: warning: ‘string_has_context’ defined but not used [-Wunused-function] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/dbghelp -I. -I../../../include -I../../include -D__WINESRC__ -D_IMAGEHLP_SOURCE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o cpu_x86_64.o ../../../dlls/dbghelp/cpu_x86_64.c ../../../dlls/dbghelp/cpu_x86_64.c: In function ‘is_inside_epilog’: ../../../dlls/dbghelp/cpu_x86_64.c:341:14: warning: variable ‘rex’ set but not used [-Wunused-but-set-variable] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/ntdll -I. -I../../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o signal_x86_64.o ../../../dlls/ntdll/signal_x86_64.c ../../../dlls/ntdll/signal_x86_64.c: In function ‘is_inside_epilog’: ../../../dlls/ntdll/signal_x86_64.c:2632:14: warning: variable ‘rex’ set but not used [-Wunused-but-set-variable] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/oleaut32 -I. -I../../../include -I../../include -D__WINESRC__ -D_OLEAUT32_ -DCOM_NO_WINDOWS_H -DENTRY_PREFIX=OLEAUTPS_ -DPROXY_DELEGATION -DWINE_REGISTER_DLL -DPROXY_CLSID=CLSID_PSFactoryBuffer -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o safearray.o ../../../dlls/oleaut32/safearray.c ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/oleaut32 -I. -I../../../include -I../../include -D__WINESRC__ -D_OLEAUT32_ -DCOM_NO_WINDOWS_H -DENTRY_PREFIX=OLEAUTPS_ -DPROXY_DELEGATION -DWINE_REGISTER_DLL -DPROXY_CLSID=CLSID_PSFactoryBuffer -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o tmarshal.o ../../../dlls/oleaut32/tmarshal.c ../../../dlls/oleaut32/tmarshal.c:426:3: warning: #warning You need to implement stubless proxies for your architecture [-Wcpp] ../../../dlls/oleaut32/tmarshal.c: In function ‘serialize_param’: ../../../dlls/oleaut32/tmarshal.c:717:279: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:793:73: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:794:56: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:800:50: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:802:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:802:41: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:807:51: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:809:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:809:41: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:895:92: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c: In function ‘deserialize_param’: ../../../dlls/oleaut32/tmarshal.c:1076:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/oleaut32/tmarshal.c:1079:78: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:1086:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/oleaut32/tmarshal.c:1181:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/oleaut32/tmarshal.c:1189:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c: In function ‘init_proxy_entry_point’: ../../../dlls/oleaut32/tmarshal.c:1699:17: warning: unused variable ‘xasm’ [-Wunused-variable] ../../../dlls/oleaut32/tmarshal.c: At top level: ../../../dlls/oleaut32/tmarshal.c:1317:1: warning: ‘xCall’ defined but not used [-Wunused-function] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/setupapi -I. -I../../../include -I../../include -D__WINESRC__ -D_SETUPAPI_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o devinst.o ../../../dlls/setupapi/devinst.c ../../../dlls/setupapi/devinst.c: In function ‘SETUPDI_AllocateDeviceInfo’: ../../../dlls/setupapi/devinst.c:470:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/setupapi/devinst.c: In function ‘SETUPDI_FreeDeviceInfo’: ../../../dlls/setupapi/devinst.c:527:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c: In function ‘SetupDiGetDeviceRegistryPropertyA’: ../../../dlls/setupapi/devinst.c:3106:278: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/setupapi/devinst.c: In function ‘SetupDiGetDeviceRegistryPropertyW’: ../../../dlls/setupapi/devinst.c:3167:278: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/setupapi/devinst.c: In function ‘CM_Get_Device_IDA’: ../../../dlls/setupapi/devinst.c:3940:45: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c: In function ‘CM_Get_Device_IDW’: ../../../dlls/setupapi/devinst.c:3958:45: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c:3970:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c: In function ‘CM_Get_Device_ID_Size’: ../../../dlls/setupapi/devinst.c:3982:47: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c:3993:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/winmm -I. -I../../../include -I../../include -D__WINESRC__ -D_WINMM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o winmm.o ../../../dlls/winmm/winmm.c ../../../dlls/winmm/winmm.c: In function ‘MMSYSTEM_GetMidiStream’: ../../../dlls/winmm/winmm.c:975:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/winmm/winmm.c: In function ‘MMSYSTEM_MidiStream_MessageHandler’: ../../../dlls/winmm/winmm.c:1092:43: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/winmm/winmm.c: In function ‘midiStreamOpen’: ../../../dlls/winmm/winmm.c:1304:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] -- ccache gcc -msse4 -O3 -Wall -c -I../../../programs/winedbg -I. -I../../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o be_x86_64.o ../../../programs/winedbg/be_x86_64.c ../../../programs/winedbg/be_x86_64.c: In function ‘be_x86_64_is_func_call’: ../../../programs/winedbg/be_x86_64.c:346:11: warning: variable ‘segment’ set but not used [-Wunused-but-set-variable] ========== system ========== Operating System Linux azura 3.0.0-14-generic #23-Ubuntu SMP Mon Nov 21 20:28:43 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux Configuration (32-bit) '--prefix=/usr' '--libdir=/usr/lib32' '--disable-tests' '--with-alsa' '--with-freetype' '--without-gstreamer' '--with-jpeg' '--with-ldap' '--with-openal' '--with-opengl' '--with-openssl' '--with-png' '--with-x' '--with-xinerama' '--with-xinput2' '--with-xml' '--with-xrandr' '--without-capi' '--without-cms' '--without-cups' '--without-curses' '--without-fontconfig' '--without-gettextpo' '--without-gnutls' '--without-gphoto' '--without-gsm' '--without-hal' '--without-mpg123' '--without-opencl' '--without-oss' '--without-sane' '--without-tiff' '--without-v4l' '--without-xslt' '--without-xxf86vm' 'CC=ccache gcc -msse4 -O3 -Wall' Configuration (64-bit) '--prefix=/usr' '--libdir=/usr/lib' '--enable-tests' '--enable-win64' '--with-alsa' '--with-freetype' '--without-gstreamer' '--with-jpeg' '--with-ldap' '--with-openal' '--with-opengl' '--with-openssl' '--with-png' '--with-x' '--with-xinerama' '--with-xinput2' '--with-xml' '--with-xrandr' '--without-capi' '--without-cms' '--without-cups' '--without-curses' '--without-fontconfig' '--without-gettextpo' '--without-gnutls' '--without-gphoto' '--without-gsm' '--without-hal' '--without-mpg123' '--without-opencl' '--without-oss' '--without-sane' '--without-tiff' '--without-v4l' '--without-xslt' '--without-xxf86vm' 'CC=ccache gcc -msse4 -O3 -Wall' Warning report for wine-1.4-rc1 generated on Tue Jan 31 12:38:27 GMT 2012 J. Leclanche

2 2

Re: [PATCH 3/4] ddraw/tests: Add an IDirect3DTexture2::Load color key test
by Marvin 31 Jan '12

31 Jan '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16746 Your paranoid android. === W7PROX64 (64 bit ddraw4) === ddraw4.c:1247: Test failed: Failed to get Direct3DTexture2 interface, hr 0x80004002. ddraw4.c:1249: Test failed: Failed to get Direct3DTexture2 interface, hr 0x80004002. Timeout === TEST64_W7SP1 (64 bit ddraw4) === ddraw4.c:1247: Test failed: Failed to get Direct3DTexture2 interface, hr 0x80004002. ddraw4.c:1249: Test failed: Failed to get Direct3DTexture2 interface, hr 0x80004002. Timeout

1 0

Re: [PATCH 2/4] ddraw/tests: Add an IDirect3DTexture::Load color key test
by Marvin 31 Jan '12

31 Jan '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16745 Your paranoid android. === WNT4WSSP6 (32 bit ddraw2) === ddraw2.c:1117: Test failed: Got unexpected hr 0x88760064. ddraw2.c:1129: Test failed: Got unexpected hr 0x88760064. ddraw2.c:1131: Test failed: Got unexpected hr 0x887600d7. ddraw2.c:1140: Test failed: Got unexpected hr 0x88760064. ddraw2.c:1143: Test failed: dwColorSpaceLowValue is 0xff. ddraw2.c:1144: Test failed: dwColorSpaceHighValue is 0xff. ddraw2.c:1152: Test failed: Got unexpected hr 0x88760064. ddraw2.c:1155: Test failed: dwColorSpaceLowValue is 0xff. ddraw2.c:1156: Test failed: dwColorSpaceHighValue is 0xff. === W7PROX64 (64 bit ddraw2) === ddraw2.c:1111: Test failed: Failed to get Direct3DTexture interface, hr 0x80004002. ddraw2.c:1113: Test failed: Failed to get Direct3DTexture interface, hr 0x80004002. Timeout === TEST64_W7SP1 (64 bit ddraw2) === ddraw2.c:1111: Test failed: Failed to get Direct3DTexture interface, hr 0x80004002. ddraw2.c:1113: Test failed: Failed to get Direct3DTexture interface, hr 0x80004002. Timeout

1 0

Re: [PATCH 2/2] urlmon: Properly handle relative URIs with specified host in combine_uri
by Marvin 31 Jan '12

31 Jan '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16738 Your paranoid android. === W7PROX64 (64 bit uri) === uri.c:10092: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[31].dword_props[1]. uri.c:10095: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[31].dword_props[1]. uri.c:10092: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[32].dword_props[1]. uri.c:10095: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[32].dword_props[1]. uri.c:10408: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[31].dword_props[1]. uri.c:10411: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[31].dword_props[1]. uri.c:10408: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[32].dword_props[1]. uri.c:10411: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[32].dword_props[1].

2 1

Re: configure.ac: remove an extraneous semicolon (Clang)
by Ken Thomases 31 Jan '12

31 Jan '12

On Jan 30, 2012, at 10:09 PM, Austin English wrote: > @@ -1723,7 +1723,7 @@ then > saved_CFLAGS="$CFLAGS" > CFLAGS="$CFLAGS -Wlogical-op -Werror" > AC_CACHE_CHECK([for broken string.h that generates warnings with -Wlogical-op], ac_cv_c_logicalop_noisy, > - AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <string.h>]], [[char*f(const char *h,char n) {return strchr(h,n);}]])],[ac_cv_c_logicalop_noisy=no],[ac_cv_c_logicalop_noisy=yes])) > + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <string.h>]], [[char*f(const char *h,char n) {return strchr(h,n)}]])],[ac_cv_c_logicalop_noisy=no],[ac_cv_c_logicalop_noisy=yes])) > CFLAGS="$saved_CFLAGS" > if test "$ac_cv_c_logicalop_noisy" = "no" > then That doesn't look extraneous to me. Also, static analysis of the configure test programs seems like it would produce tons of noise. Those are often not sane programs by normal standards. Regards, Ken

2 1