October 2012 - Wine-devel - list.winehq.org

Re: [PATCH] cmd: Properly handle multibyte characters in batch files.
by Alexandre Julliard 16 Oct '12

16 Oct '12

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > @@ -244,7 +244,8 @@ WCHAR *WCMD_fgets(WCHAR *buf, DWORD noChars, HANDLE h) > > if (!WCMD_is_console_handle(h) && i != charsRead) { > /* Sets file pointer to the start of the next line, if any */ > - filepos.QuadPart += i + 1 + (buf[i] == '\r' ? 1 : 0); > + INT bytes = WideCharToMultiByte(GetConsoleCP(), 0, buf, i, NULL, 0, NULL, NULL); > + filepos.QuadPart += bytes + 1 + (buf[i] == '\r' ? 1 : 0); There's no guarantee that all characters would round-trip properly, this should be based on the original multibyte length somehow. -- Alexandre Julliard julliard(a)winehq.org

1 0

user32 tests patch
by Christian Costa 16 Oct '12

16 Oct '12

Forget my user32 patch. MapWindowPoints tests are wrong.

1 0

Re: [PATCH 2/6] d3dcompiler: Improve a Nvidia GPU recognition fallback.
by Matteo Bruni 16 Oct '12

16 Oct '12

Ehh, this patch should have been called something like "wined3d: Improve a Nvidia GPU recognition fallback.", but well...

1 0

Re: [PATCH 7/8] mshtml: Added IHTMLScriptElement::put_src tests
by Marvin 16 Oct '12

16 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22264 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: dwrite: Implement GetMetrics() for IDWriteFont
by Dmitry Timoshkov 16 Oct '12

16 Oct '12

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + static const WCHAR arialW[] = {'A','r','i','a','l',0}; Please don't use fonts which Wine doesn't provide. Testing Tahoma is fine. -- Dmitry.

2 1

Re: [PATCH] user32: Don't ignore return value of MapWindowPoints
by Nikolay Sivov 16 Oct '12

16 Oct '12

On 10/16/2012 04:10, danielfsantos(a)att.net wrote: > ScreenToClient should return zero if the operation fails, but is always > returning TRUE. This patch corrects the problem and solves a crash bug > in Lord of the Rings Online (bug #31979) > > Credit for this patch goes to some one else, as yet unidentified, since > it originally came from a closed forum for beta testers of the LoTRO > Riders of Rohan expansion and the forum has subsequently been wiped. > --- > dlls/user32/winpos.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/dlls/user32/winpos.c b/dlls/user32/winpos.c > index 5a2f1f2..3855b19 100644 > --- a/dlls/user32/winpos.c > +++ b/dlls/user32/winpos.c > @@ -250,8 +250,7 @@ BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt ) > */ > BOOL WINAPI ScreenToClient( HWND hwnd, LPPOINT lppnt ) > { > - MapWindowPoints( 0, hwnd, lppnt, 1 ); > - return TRUE; > + return MapWindowPoints( 0, hwnd, lppnt, 1 ) != 0; > } > This needs a test.

1 0

Re: [3/4] comctl32: fix notifications and return value when collapsing already collapsed node (rebased)
by Nikolay Sivov 15 Oct '12

15 Oct '12

Hi, Daniel. You forgot a patch.

2 1

Re: jscript: Move 'inline' to the beginning of the declaration.
by Francois Gouget 15 Oct '12

15 Oct '12

On Mon, 15 Oct 2012, Michael Stefaniuc wrote: [...] > --- a/dlls/jscript/jsstr.h > +++ b/dlls/jscript/jsstr.h > @@ -28,7 +28,7 @@ struct _jsstr_t { > > #define JSSTR_FLAG_NULLBSTR 1 > > -static unsigned inline jsstr_length(jsstr_t *str) > +inline static unsigned jsstr_length(jsstr_t *str) 'static inline' is the more common format in Wine (4166 occurences versus 0 for 'inline static'). But yes, moving it before the return type makes sense. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

1 0

Re: [2/4] comctl32: do not send TVN_ITEMEXPANDING when expanding item with no children
by Alexandre Julliard 15 Oct '12

15 Oct '12

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 4ce8e5ea93897e03e1c3bbd0be90c9179890a37a Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Thu, 27 Sep 2012 21:06:48 +0200 > Subject: comctl32/treeview: do not send TVN_ITEMEXPANDING when expanding item > with no children > > also, send it when re-expanding expanded item or re-collapsing collapsed one. > Tests in later commit (look for VK_ADD/VK_SUBSTRACT) This causes the explorerframe tests to hang. -- Alexandre Julliard julliard(a)winehq.org

1 0

d3d9 implementation
by Luchezar Belev 15 Oct '12

15 Oct '12

hello i have been writing some d3d9/d3d8 implementation on top of opengl as a pet project i mainly work on it under windows, but also made it run under wine. i thought you guys might find it interesting to try it out. It works fine with all the games i got - there are no major problems. they are guild wars (1), wow, league of legends, tomb raider underworld, titan quest, skyrim. it requires opengl 3.3 or higher. attached is zip archive with binaries (2 files) and a readme. (i'm not sure i want to give away the sources yet.)

2 1