November 2012 - Wine-devel - list.winehq.org

Re: [PATCH 2/7] advapi: Implement SetNamedSecurityInfoW on top of SetSecurityInfo (resend 3).
by Alexandre Julliard 16 Nov '12

16 Nov '12

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > + hfile = CreateFileW( pObjectName, access, FILE_SHARE_READ|FILE_SHARE_WRITE|FILE_SHARE_DELETE, > + NULL, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, 0 ); > + if (hfile == INVALID_HANDLE_VALUE) > + return FALSE; FALSE doesn't do what you want here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH v3] dsound: create a primary_pwfx separately from pwfx
by Andrew Eikum 16 Nov '12

16 Nov '12

This breaks the Giants: Citizen Kabuto demo on coreaudio: http://www.fileplanet.com/55371/download/Giants:-Citizen-Kabuto-Demo I've attached a +dsound,+coreaudio,+tid log (could certainly be a winecoreaudio bug, but I don't have time to analyze right now). Also, > diff --git a/dlls/dsound/primary.c b/dlls/dsound/primary.c > index 8da12e2..ff4598c 100644 > --- a/dlls/dsound/primary.c > +++ b/dlls/dsound/primary.c > @@ -85,11 +174,20 @@ HRESULT DSOUND_ReopenDevice(DirectSoundDevice *device, BOOL forcewave) > + if (FAILED(hres))) { Fails to compile. Andrew

1 0

Re: [2/2] msxml3: Stub support for external entity resolver
by Marvin 16 Nov '12

16 Nov '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22981 Your paranoid android. === WXPPROSP3 (32 bit saxreader) === saxreader.c:2230: Test failed: got 0x00000000 === WVISTAADM (32 bit saxreader) === saxreader.c:2230: Test failed: got 0x00000000 === W2K8SE (32 bit saxreader) === saxreader.c:2230: Test failed: got 0x00000000 === W7PRO (32 bit saxreader) === saxreader.c:2230: Test failed: got 0x00000000 === W7PROX64 (32 bit saxreader) === saxreader.c:2230: Test failed: got 0x00000000 === TEST64_W7SP1 (32 bit saxreader) === saxreader.c:2230: Test failed: got 0x00000000 === W7PROX64 (64 bit saxreader) === saxreader.c:2230: Test failed: got 0x00000000 === TEST64_W7SP1 (64 bit saxreader) === saxreader.c:2230: Test failed: got 0x00000000

1 0

Re: msi: Fix a couple of leaks (coverity)
by Hans Leidekker 16 Nov '12

16 Nov '12

On Fri, 2012-11-16 at 11:50 +0100, Frédéric Delanoy wrote: > diff --git a/dlls/msi/files.c b/dlls/msi/files.c > index 11913ef..98d7513 100644 > --- a/dlls/msi/files.c > +++ b/dlls/msi/files.c > @@ -336,6 +336,7 @@ UINT ACTION_InstallFiles(MSIPACKAGE *package) > if (rc != ERROR_SUCCESS) > { > ERR("Unable to load media info for %s (%u)\n", debugstr_w(file->File), rc); > + msi_free(mi); > return ERROR_FUNCTION_FAILED; This is a loop, so you should instead call msi_free_media_info to also free any strings allocated in a previous call to msi_load_media_info.

1 0

Re: [PATCH 2/4] kernel32: Partial implement CreateHardLinkTransactedA/W
by Alexandre Julliard 16 Nov '12

16 Nov '12

Detlef Riekenberg <wine.dev(a)web.de> writes: > transaction is ignored for now I don't think that's a good idea, particularly not for DeleteFile. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] amstream: Initialize correctly AM_MEDIA_TYPE struct.
by Michael Stefaniuc 16 Nov '12

16 Nov '12

Hello Christian, On 11/15/2012 09:43 AM, Christian Costa wrote: > Fixes bug 32185. > --- > dlls/amstream/mediastreamfilter.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/amstream/mediastreamfilter.c b/dlls/amstream/mediastreamfilter.c > index 9b2bd8e..d5388e5 100644 > --- a/dlls/amstream/mediastreamfilter.c > +++ b/dlls/amstream/mediastreamfilter.c > @@ -132,6 +132,8 @@ static HRESULT WINAPI BasePinImp_GetMediaType(BasePin *This, int index, AM_MEDIA > MSPID purpose_id; > int i; > > + ZeroMemory(amt, sizeof(*amt)); > + this looks "odd". There is no check if amt is NULL, at least that's what caught my attention. So I've looked around and stumbled upon the AM_MEDIA_TYPE structure documentation http://msdn.microsoft.com/en-us/library/windows/desktop/dd373477%28v=vs.85%… "pUnk Not used. Set to NULL." Setting that to NULL in amstream's BasePinImp_GetMediaType() fixes the crash for me. But who's responsibility is to set / check that? That function or the caller aka test_media_streams() ? bye michael

2 1

Re: [PATCH 1/2] usp10/tests: Added tests for wgBlank, wgDefault, wgInvalid and wgKashida (try 2).
by Alexandre Julliard 15 Nov '12

15 Nov '12

Qian Hong <fracting(a)gmail.com> writes: > @@ -3038,6 +3203,7 @@ START_TEST(usp10) > test_ScriptPlace(hdc); > > test_ScriptGetFontProperties(hdc); > + test_ScriptGetFontProperties2(hdc); There's no need to have two separate tests functions. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: advapi32: fix a too small buffer in CredUnmarshalCredentialW [try2]
by Hans Leidekker 15 Nov '12

15 Nov '12

On Wed, 2012-11-14 at 16:28 +0100, Stefan Leichter wrote: > @@ -2053,6 +2053,8 @@ static BOOL cred_decode( const WCHAR *cred, unsigned int len, char *buf ) > char c0, c1, c2, c3; > const WCHAR *p = cred; > > + TRACE("%s\n", debugstr_wn(cred,len)); This string is already traced in CredUnmarshalCredentialW. > @@ -2134,6 +2136,7 @@ BOOL WINAPI CredUnmarshalCredentialW( LPCWSTR cred, PCRED_MARSHAL_TYPE type, PVO > case UsernameTargetCredential: > { > USERNAME_TARGET_CREDENTIAL_INFO *target; > + ULONGLONG size = 0; > > if (len < 9 || !cred_decode( cred + 3, 6, (char *)&size ) || !size || size % sizeof(WCHAR)) > { You should also perform a sanity check on 'size' to avoid overflow in calculations that follow.

2 3

Re: wined3d: Use backup swapchain DC for devices created with desktop window. (try 2)
by Stefan Dösinger 14 Nov '12

14 Nov '12

Am Montag, 3. September 2012, 04:06:01 schrieb Adam Jakubek: > Previous version failed on test bots. > Added test case skipping when no device can be created with normal > (non-desktop) window. I skimmed bug #18490, and I'm wondering about two things: Does the app create a D3DDEVTYPE_REF or D3DDEVTYPE_NULLREF device? Once the device is created, what does it to with it? A +d3d log would provide some answers. This is some guesswork: I don't think the game creates a _REF device because REF devices require the user to install the reference rasterizer dll, as Matteo already mentioned. If it's a NULLREF device I wonder what the game is able to do with it. The bug report has a link which promises some clues, but the link is dead. Stefan

3 2

Re: fix a too small buffer in CredUnmarshalCredentialW
by Hans Leidekker 14 Nov '12

14 Nov '12

On Wed, 2012-11-14 at 09:48 +0100, Stefan Leichter wrote: > + char buffer[6]; > + unsigned int buflen, *size = (unsigned int*) buffer; > > - if (len < 9 || !cred_decode( cred + 3, 6, (char *)&size ) || !size || size % sizeof(WCHAR)) > + if (len < 9 || !cred_decode( cred + 3, 6, buffer ) || !*size || *size % sizeof(WCHAR)) You're still truncating the decoded size. You should instead make 'size' a ULONGLONG and initialize it to 0. Is this little-endian ARM?

2 1