December 2012 - Wine-devel - list.winehq.org

Re: oleaut32: Dont output an error when the typelib cannot be found
by Alexandre Julliard 18 Dec '12

18 Dec '12

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c > index fa9b050..04914e0 100644 > --- a/dlls/oleaut32/typelib.c > +++ b/dlls/oleaut32/typelib.c > @@ -2544,9 +2544,11 @@ static HRESULT TLB_PEFile_Open(LPCWSTR path, INT index, LPVOID *ppBase, DWORD *p > return S_OK; > } > } > - > - hr = E_FAIL; > } > + > + TRACE("No TYPELIB resource found\n"); > + hr = E_FAIL; > + SetLastError(0); Setting last error to 0 is almost always wrong. In this case it's most likely just a side effect of CreateFile, and shouldn't need to be done explicitly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Does Wine benefit from libtiff5 over libtiff4?
by Scott Ritchie 18 Dec '12

18 Dec '12

I'm trying to manage building for 3 different Ubuntu releases now for our 1.5 releases, and the main delta between them is libtiff 12.04: libtiff4 available 12.10: libtiff4 and libtiff 5 available 13.04: libtiff4 and libtiff 5 available It's much simpler if I can build on 12.04 and copy the binary packages, however this means I can't use libtiff5 if I do so. Is there any benefit in doing a separate build just for this? *note that in 12.10/13.04 official archive we build seperately and just use libtiff5. Thanks, Scott Ritchie

3 3

Call for papers - FOSDEM 2013
by Jeremy White 17 Dec '12

17 Dec '12

Alright folks, We need to put together a schedule for our room at FOSDEM. So I would like to formally 'call for papers' for FOSDEM. Please email suggested topics to wineconf(a)winehq.org, where I'll collate them and piece them into a schedule. A 'paper' can be a talk you wish to give, or a topic you think we should discuss. As always, they should be relatively brief, and should emphasize discussion and collaboration. This year it probably makes sense to imagine a few talks aimed at developers outside the Wine community. After all, the hope is that a few bored non Wine developers may wander by from time to time. Perhaps we can suck them in <grin>. Cheers, Jeremy

5 7

Re: [PATCH 3/8] winemac: Implement GetDeviceCaps().
by Alexandre Julliard 17 Dec '12

17 Dec '12

Ken Thomases <ken(a)codeweavers.com> writes: > --- > dlls/winemac.drv/Makefile.in | 1 + > dlls/winemac.drv/gdi.c | 321 ++++++++++++++++++++++++++++++++++++++++- > dlls/winemac.drv/macdrv.h | 101 +++++++++++++ > 3 files changed, 415 insertions(+), 8 deletions(-) > create mode 100644 dlls/winemac.drv/macdrv.h It doesn't build here on OS X 10.5.8: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -gstabs+ -fno-omit-frame-pointer -Wpointer-arith -I/usr/local/include/freetype2 -I/usr/local/include -g -O2 -o gdi.o gdi.c gdi.c: In function 'device_init': gdi.c:143: error: 'CGDisplayModeRef' undeclared (first use in this function) gdi.c:143: error: (Each undeclared identifier is reported only once gdi.c:143: error: for each function it appears in.) gdi.c:143: error: syntax error before 'mode' gdi.c:160: error: 'mode' undeclared (first use in this function) gdi.c:162: warning: implicit declaration of function 'CGDisplayModeCopyPixelEncoding' gdi.c:162: warning: initialization makes pointer from integer without a cast gdi.c:164: warning: implicit declaration of function 'CGDisplayModeGetWidth' gdi.c:165: warning: implicit declaration of function 'CGDisplayModeGetHeight' gdi.c:178: warning: implicit declaration of function 'CGDisplayModeRelease' make[1]: *** [gdi.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 6

[PATCH 0/3] Add O_DENY* flags to fcntl and cifs
by Pavel Shilovsky 17 Dec '12

17 Dec '12

Network filesystems CIFS, SMB2.0, SMB3.0 and NFSv4 have such flags - this change can benefit cifs and nfs modules. While this change is ok for network filesystems, itsn't not targeted for local filesystems due security problems (e.g. when a user process can deny root to delete a file). Share flags are used by Windows applications and WINE have to deal with them too. While WINE can process open share flags itself on local filesystems, it can't do it if a file stored on a network share and is used by several clients. This patchset makes it possible for CIFS/SMB2.0/SMB3.0. Pavel Shilovsky (3): fcntl: Introduce new O_DENY* open flags for network filesystems CIFS: Add O_DENY* open flags support CIFS: Use NT_CREATE_ANDX command for forcemand mounts fs/cifs/cifsacl.c | 10 ++++---- fs/cifs/cifsglob.h | 11 ++++++++- fs/cifs/cifsproto.h | 9 ++++---- fs/cifs/cifssmb.c | 47 ++++++++++++++++++++------------------ fs/cifs/dir.c | 14 ++++++++---- fs/cifs/file.c | 18 ++++++++++----- fs/cifs/inode.c | 11 +++++---- fs/cifs/link.c | 10 ++++---- fs/cifs/readdir.c | 2 +- fs/cifs/smb1ops.c | 15 ++++++------ fs/cifs/smb2file.c | 10 ++++---- fs/cifs/smb2inode.c | 4 ++-- fs/cifs/smb2ops.c | 10 ++++---- fs/cifs/smb2pdu.c | 6 ++--- fs/cifs/smb2proto.h | 14 +++++++----- fs/fcntl.c | 5 ++-- include/uapi/asm-generic/fcntl.h | 11 +++++++++ 17 files changed, 125 insertions(+), 82 deletions(-) -- 1.7.10.4

11 28

Re: [PATCH 3/6] jscript: Fixed deleting nonexistent identifiers
by Marvin 17 Dec '12

17 Dec '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23454 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/6] jscript: Fixed deleting nonexisting properties from member expression
by Marvin 17 Dec '12

17 Dec '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23453 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] jscript: Fixed Number.toFixed for value 0 with 0 precision
by Marvin 17 Dec '12

17 Dec '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23452 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: msvcrt: implement _strxfrm_l
by Piotr Caban 17 Dec '12

17 Dec '12

On 12/14/12 10:28, Jérôme Gardou wrote: > --- > dlls/msvcrt/msvcrt.spec | 2 +- > dlls/msvcrt/string.c | 26 ++++++++++++++++++++++++-- > 2 files changed, 25 insertions(+), 3 deletions(-) > Please add parameters validation. The function also behaves differently with native msvcrt when output buffer is to small. This function should return data that keeps sorting order. It should use LCMAP_SORTKEY flag. Cheers, Piotr

1 0

Re: winex11.drv: give a better warning for broken drivers on 64-bit OS's
by Austin English 17 Dec '12

17 Dec '12

On Sun, Dec 16, 2012 at 2:31 PM, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin Wrong macro, please ignore. -- -Austin

1 0