March 2012 - Wine-devel - list.winehq.org

Re: [1/2] winefile: Fix compilation warnings in _NO_EXTENSIONS mode
by Alexandre Julliard 16 Mar '12

16 Mar '12

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -3973,6 +3973,7 @@ static BOOL prompt_target(Pane* pane, LPWSTR source, LPWSTR target) > static IContextMenu2* s_pctxmenu2 = NULL; > static IContextMenu3* s_pctxmenu3 = NULL; > > +#ifndef _NO_EXTENSIONS > static void CtxMenu_reset(void) > { > s_pctxmenu2 = NULL; It would be better to get rid of that define, it creates a mess for no good reason. -- Alexandre Julliard julliard(a)winehq.org

2 1

Fwd: [Wine (a project of Software Freedom Conservancy)] Your organization application has been accepted.
by Maarten Lankhorst 16 Mar '12

16 Mar '12

huzzah! -------- Originele bericht -------- Onderwerp: [Wine (a project of Software Freedom Conservancy)] Your organization application has been accepted. Datum: Fri, 16 Mar 2012 17:44:28 +0000 Van: no-reply(a)google-melange.appspotmail.com Aan: m.b.lankhorst(a)gmail.com Your Organization Application for "Wine (a project of Software Freedom Conservancy)" in Google Summer of Code 2012 has been accepted. Please click "http://www.google-melange.com/gsoc/profile/organization/google/gsoc2012?org… to fill in the necessary information and create your Organization. Best regards, Google Open Source Programs

1 0

Re: [2/2] sxs/tests: Add tests for CreateAssemblyNameObject.
by Marvin 16 Mar '12

16 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17409 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 1/2] urlmon: Add mime handler layer before data is processed
by Marvin 16 Mar '12

16 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17407 Your paranoid android. === W2K3R2SESP2 (32 bit protocol) === Timeout

2 1

Re: [PATCH 3/8] amstream/tests: Add media streams tests.
by Marvin 16 Mar '12

16 Mar '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17387 Your paranoid android. === W2KPROSP4 (32 bit amstream) === amstream.c:212: Test failed: IAMMultiMediaStream_AddMediaStream returned: 80040256

2 2

Re: wpp: Stop parsing single and double quoted string constants after a first newline character.
by Matteo Bruni 16 Mar '12

16 Mar '12

Il 14 marzo 2012 23:02, Józef Kucia <joseph.kucia(a)gmail.com> ha scritto: > @@ -679,11 +649,23 @@ void pp_writestring(const char *format, ...) > } > } > <pp_iqs,pp_dqs,pp_sqs>\\. add_string(ppy_text, ppy_leng); > -<pp_iqs,pp_dqs,pp_sqs>\n { > +<pp_iqs>\n { > newline(1); > add_string(ppy_text, ppy_leng); > ppy_warning("Newline in string constant encountered (started line %d)", string_start()); > } > +<pp_dqs>\n { > + newline(-1); > + add_string(ppy_text, ppy_leng); > + ppy_warning("Newline in double quoted string constant encountered (started line %d)", string_start()); > + if(end_double_quoted_string()) return tDQSTRING; > + } > +<pp_sqs>\n { > + newline(-1); > + add_string(ppy_text, ppy_leng); > + ppy_warning("Newline in single quoted string constant encountered (started line %d)", string_start()); > + if(end_single_quoted_string()) return tSQSTRING; > + } > > /* > * Identifier scanning I'm not sure this is legit. If I'm reading the C spec correctly, a character or string constant can be only terminated by ' or " respectively. Although it can't contain unescaped newline characters either, so it looks like we are actually in the realm of "undefined behavior". So, I guess this change will only have any effect on non-standard complying sources, and in the specific case of asm-style comments, it brings us the behavior we want. On the other hand, it also actually turns an error (unexpected end of file) into a warning, which may be troublesome in general. I hope it doesn't break anything else... (You can take this email as "okay for me, but someone else may know better")

2 2

Re: [2/4](resend)strmbase: implement BaseControlWindow
by Nikolay Sivov 16 Mar '12

16 Mar '12

On 3/16/2012 04:00, Aric Stewart wrote: > +HRESULT WINAPI BaseControlWindowImpl_GetTypeInfo(IVideoWindow *iface, UINT iTInfo, LCID lcid, ITypeInfo**ppTInfo) > +{ > + BaseControlWindow* This = (BaseControlWindow*)iface; > + It doesn't look like a normal COM interface (lack of refcount for example, and corresponding IUnknown support), but I think it's still better to use a cleaner way to get impl pointer like all others do now - with impl_from_*() functions.

2 1

Re: [PATCH 1/4] mshtml: Get rid of PRBool in nsiface.idl
by Henri Verbeet 16 Mar '12

16 Mar '12

On 15 March 2012 11:54, Jacek Caban <jacek(a)codeweavers.com> wrote: > > +typedef unsigned char cpp_bool; > +#define bool cpp_bool > +cpp_quote("#define PRBool cpp_bool") /* FIXME */ Is there any chance this is going to conflict with bool from stdbool.h? Technically that's C99, and we don't use C99, but I imagine it could still be pulled in by some other header.

2 1

Re: [po]Update Ukrainian translation
by Francois Gouget 16 Mar '12

16 Mar '12

Why did you remove these? #: xcopy.rc:43 msgctxt "File key" msgid "F" -msgstr "F" +msgstr "" #: xcopy.rc:44 msgctxt "Directory key" msgid "D" -msgstr "D" +msgstr "" They are supposed to match the key specified by the translation below which they did: #: xcopy.rc:34 msgid "" "Is '%1' a filename or directory\n" "on the target?\n" "(F - File, D - Directory)\n" msgstr "" "'%1' є файлом чи директорією?\n" "(F - Файл, D - Директорія)\n" -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ La terre est une bêta...

1 0

qcap patch
by Christian Costa 16 Mar '12

16 Mar '12

Forget my qcap patch. It's the wrong one and I need to add missing CLSID defines in some headers first.

1 0