May 2012 - Wine-devel - list.winehq.org

Re: [2/2]kernel32/test: added test for OutputDebugStringA called with NULL pointer
by Marvin 30 May '12

30 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18671 Your paranoid android. === WXPPROSP3 (32 bit debugger) === Timeout === W2K3R2SESP2 (32 bit debugger) === Timeout

1 0

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream. (try 2)
by Dmitry Timoshkov 30 May '12

30 May '12

Józef Kucia <joseph.kucia(a)gmail.com> wrote: > + offset.QuadPart = 0; > + size.u.LowPart = 0xffffffff; > + size.u.HighPart = 0xffffffff; > + return IWICStream_InitializeFromIStreamRegion(iface, pIStream, offset, size); What prevents you from discovering correct stream size? -- Dmitry.

3 5

Re: [1/2] mscoree: Install Wine Mono on prefix update.
by Alexandre Julliard 30 May '12

30 May '12

Vincent Povirk <madewokherd(a)gmail.com> writes: > From d271ba591f6afb4e0b2356da24841f54d5f11b9b Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Tue, 29 May 2012 10:35:36 -0500 > Subject: [PATCH 1/2] mscoree: Install Wine Mono on prefix update. > > --- > dlls/mscoree/mscoree_main.c | 120 +++++++++++++++++++++++++++++++++++++++++++ > tools/wine.inf.in | 1 + > 2 files changed, 121 insertions(+) This is breaking 64-bit prefixes, because things are not done in the correct order. It also looks like the package is not creating the 64-bit registry keys. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 4/4] jscript: Added VT_I2 tests
by Marvin 30 May '12

30 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18657 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/3] jscript: Get rid of ret_nan hack
by Ruslan Kabatsayev 30 May '12

30 May '12

Hello, This patch (committed as d0a719a79dae001df341db907fcae54118691d35) leads to compilation error: make[1]: Entering directory `/fastdocs/programmer/wine-git/dlls/msadp32.acm' make[1]: Nothing to be done for `all'. make[1]: Leaving directory `/fastdocs/programmer/wine-git/dlls/msadp32.acm' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -I/opt/Xorg-7.5/include -L/opt/Xorg-7.5/lib -o string.o string.c lex.c: In function ‘cc_token’: lex.c:936:71: error: ‘NAN’ undeclared (first use in this function) lex.c:936:71: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [lex.o] Error 1 I've tried doing git clean -xdf, but this still doesn't compile. Regards, Ruslan On Tue, May 29, 2012 at 2:53 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/jscript/date.c | 28 ++++++++++++++-------------- > dlls/jscript/error.c | 3 ++- > dlls/jscript/global.c | 2 +- > dlls/jscript/jscript.h | 7 ------- > dlls/jscript/jsutils.c | 6 +++--- > dlls/jscript/lex.c | 2 +- > 6 files changed, 21 insertions(+), 27 deletions(-) > > > > >

2 1

ru.po: improved an Russian translation
by Oleg Yarigin 30 May '12

30 May '12

There are some improvements of a style (now it is more official) and non-translated empty lines. To avoid an character encoding interruption, I send the diff file as a packed text file attachment (ru_diff.txt.bz2, 22.3 KB).

3 2

stub for SetThreadStackGuarantee
by Daniel Jelinski 29 May '12

29 May '12

Hello, SQL Server Management Studio 2005 needs SetThreadStackGuarantee to either be absent or return TRUE - otherwise it refuses to run at all. Is there a reason for this stub to return FALSE? Regards, Daniel

1 0

Re: kernel32/volume: Don't modify the last error in GetVolumeInformation
by Alexandre Julliard 29 May '12

29 May '12

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -729,6 +731,8 @@ BOOL WINAPI GetVolumeInformationW( LPCWSTR root, LPWSTR label, DWORD label_len, > } > else > { > + /* At this point, last error is ERROR_NOT_SUPPORTED. Restoring the previous one */ > + SetLastError(lastError); You should never need to do that sort of thing, there are no guarantees about last error on success. -- Alexandre Julliard julliard(a)winehq.org

2 1

Implementing joystick ids in DirectInput
by Lucas Zawacki 29 May '12

29 May '12

Hey guys, asking for a little code review here... I was looking at the solution for this bug http://bugs.winehq.org/show_bug.cgi?id=30705 and it comes down to implementing the DIPROP_JOYSTICKSID property for joystick devices. After some research on what this is I know it's always a number between (0,n), where n is the number of joysticks connected, and is analogous to the winmm driver joystick id. The solution I came up is in the attached patch, it's a little weird but I found it hard to give a unique ID to each joystick on Linux when they can come from different drivers. This solution uses the order which dinput puts the joysticks on it's device list and will work regardless. If someone has a better way to do it I'd like to know. Cheers,

2 2

Re: [PATCH 1/3] ntdll: Implement RtlGetProductInfo and use it for GetProductInfo
by Alexandre Julliard 29 May '12

29 May '12

Detlef Riekenberg <wine.dev(a)web.de> writes: > The wrapper in kernel32 is not needed. > RtlGetProductInfo and GetProductInfo have the same signature and > tests show the same results. No they don't have the same signature, look closer. -- Alexandre Julliard julliard(a)winehq.org

1 0