June 2012 - Wine-devel - list.winehq.org

Misspelt Portuguese in msvcrt
by Francois Gouget 13 Jun '12

13 Jun '12

Is there a reason why Portuguese is misspelt in these two places? diff --git a/dlls/msvcrt/locale.c b/dlls/msvcrt/locale.c index 97b82ec..b26a9c8 100644 --- a/dlls/msvcrt/locale.c +++ b/dlls/msvcrt/locale.c @@ -85,7 +85,7 @@ static const char * const _country_synonyms[] = "german-swiss", "des", "italian-swiss", "its", "german-austrian", "dea", - "portugese", "ptb", + "portuguese", "ptb", "portuguese-brazil", "ptb", "spanish-mexican", "esm", "norwegian-bokmal", "nor", diff --git a/dlls/msvcrt/tests/locale.c b/dlls/msvcrt/tests/locale.c index 8d6a34f..638a3d2 100644 --- a/dlls/msvcrt/tests/locale.c +++ b/dlls/msvcrt/tests/locale.c @@ -472,7 +472,7 @@ static void test_setlocale(void) if(ret) ok(!strcmp(ret, "Polish_Poland.1250"), "ret = %s\n", ret); - ret = setlocale(LC_ALL, "portugese"); + ret = setlocale(LC_ALL, "portuguese"); ok(ret != NULL || broken (ret == NULL), "ret == NULL\n"); if(ret) ok(!strcmp(ret, "Portuguese_Brazil.1252"), "ret = %s\n", ret); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ E-Voting: Those who cast the votes decide nothing. Those who count the votes decide everything.

2 1

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 3).
by Jacek Caban 13 Jun '12

13 Jun '12

Hi Erich, On 06/12/12 19:03, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control, the search is a > now a binary search, and some additional cleanup. It is important to > note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. Many > apologizes to Jacek Caban for missing some of his comments in his > original reply. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. The patch looks much better. There is one remaining problem: + int pos = sizeof(html_encoded_symbols)/sizeof(html_encoded_symbols[0]); + float step = pos/2; + int dir = +1; + + do + { + const char *encoded_symbol; + + pos += -dir*ceil(step); Using float here is definitely not needed, esp. that you always use ceil() on it. You've made it more complicated than it really is. See [1] for an example. Also feel free to send linear search with FIXME comment. That's fine for the first iteration patch. Jacek [1] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/mshtml/dispex.c#l709

1 0

Re: [11/11] windowscodecs: Implement GetMetadataFormat.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18989 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd

1 0

Re: [10/11] windowscodecs: Handle IFD fields with count 0 same way as with count 1.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18988 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd

1 0

Re: [09/11] windowscodecs: Add support for IFD_UNDEFINED field type.
by Marvin 12 Jun '12

12 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18987 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd

1 0

Re: [08/11] windowscodecs: Add tests for more types of IFD fields.
by Marvin 12 Jun '12

12 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18986 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd

1 0

Re: po: Update Russian translation (try 3) (resend)
by Francois Gouget 12 Jun '12

12 Jun '12

msgid "KeyID=" -msgstr "Код ключа=" +msgstr "Код ключа: " [...] msgid "Other Name=" -msgstr "Другое имя=" +msgstr "Альтернативное имя: " and many more like this. Why did you not fix this? Replacing the equal sign with a colon looks wrong to me but then I don't speak Russian. Still I have not seen anything to suggest that the typographic rules would be different in this regard. But Nikolay Sivov, who speaks Russian, seems to concur. Note that this was reported to you back in May: http://www.winehq.org/pipermail/wine-devel/2012-May/095672.html -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner

1 0

Re: [PATCH 4/5] wined3d: Set undefined vertex attributes to 0.0.
by Stefan Dösinger 12 Jun '12

12 Jun '12

Am Dienstag, 12. Juni 2012, 17:03:49 schrieb Henri Verbeet: > + if (state->vertex_shader->reg_maps.input_registers & (1 << i)) > + GL_EXTCALL(glVertexAttrib4fARB(i, 0.0f, 0.0f, 0.0f, 0.0f)); Does an application need this? Afair Windows drivers have implementation- specific behavior here that pretty much matches their GL counterparts.

1 0

re: Command line parameters
by Dan Kegel 12 Jun '12

12 Jun '12

John asked > [ How do I launch Windows apps from Unix apps and pass filenames to them?] > execl (the_path_to_wine, "wine", path_to_the_windows_program, command_line_parameter_for_windows_app, NULL); Relative unix paths will often work with Windows apps, but in general, you will have to translate command_line_parameter_for_windows_app, and any paths that appear in data files, from Unix to Windows before launching the app. The winepath utility may help there, or you can translate them yourself once you know how Wine maps filenames. Also, I recall being in a situation where I had to put the commandline in a batch file and do wine cmd.exe /c foo.bat because there wasn't another other way to make the windows app happy... something about the commandline that made me need to use CreateProcess, and cmd.exe was the easiest way to use CreateProcess. - Dan

5 10

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 2).
by Jacek Caban 12 Jun '12

12 Jun '12

Hi Erich, On 06/11/12 21:01, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control. It is important > to note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. You didn't address most of my comments. Feel free to ask for clarifications if something was not clear enough. Jacek

2 1