June 2012 - Wine-devel - list.winehq.org

Re: [PATCH 2/3] server: STATUS_MORE_PROCESSING_REQUIRED does not indicate that an async operation is complete (try 4).
by Alexandre Julliard 06 Jun '12

06 Jun '12

"Erich E. Hoover" <compholio(a)gmail.com> writes: > @@ -285,7 +285,9 @@ void async_set_result( struct object *obj, unsigned int status, unsigned int tot > if (async->timeout) remove_timeout_user( async->timeout ); > async->timeout = NULL; > async->status = status; > - if (async->data.cvalue) > + if (status == STATUS_MORE_PROCESSING_REQUIRED) > + async->status = STATUS_PENDING; > + else if (async->data.cvalue) Why are you marking the async pending? That doesn't seem right, it's terminated at that point. -- Alexandre Julliard julliard(a)winehq.org

2 1

http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono
by Dan Kegel 06 Jun '12

06 Jun '12

http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh now also installs mono. It should be probably be called wine-install-addons.sh now, maybe I'll rename it that soon. If you have a better idea for the name, let me know. (I've also deprecated the copy that was in winezeug; that one now just tells users to get it from the winetricks repo.)

11 20

Re: windowscodecs: Add a stubbed out IWICMetadataBlockReader to TIFF decoder.
by Vincent Povirk 06 Jun '12

06 Jun '12

Looks good. Here are some notes in case you get around to implementing this before I do: I found it very surprising that no metadata handlers seem to implement IWICMetadataBlockReader, while many of them advertise that they can be found in other metadata formats. I'm guessing that metadata handlers return child IWICMetadataReader objects from the IWICMetadataReader interface, but I haven't tested this. It probably doesn't make sense to reimplement GetEnumerator for each decoder, and we should be able to make a common implementation based on the other methods. We should probably implement GetReaderByIndex based on CreateMetadataReaderFromContainer, which I'm guessing expects a copy of the image stream (using IWICStream because we can't use IStream::Clone) seeked to the beginning of some metadata, or a region of the image stream, maybe depending on the container format.

1 0

Re: urlmon: Use file content to verify MIME type reported by file protocol handler
by Marvin 06 Jun '12

06 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18815 Your paranoid android. === WXPPROSP3 (32 bit protocol) === protocol.c:1046: Test failed: unexpected call ReportResult protocol.c:1051: Test failed: hrResult = 00000000, expected: 80004004 protocol.c:2838: Test failed: Read failed: 00000001

2 1

Re: [2/2] user32: Add a test to demonstrate the z-order problem for a top level window with a region. Take 2.
by Alexandre Julliard 06 Jun '12

06 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This version of the test tries harder to avoid races that could cause > the test failures. It's not races, it's failing consistently here, even with your latest version. I don't think you can reliably test expose events processing from a Windows app. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] shell32: do not crash "wine control.exe nonexisting"
by Jacek Caban 06 Jun '12

06 Jun '12

Hi Marcus, On 06/06/12 10:17, Marcus Meissner wrote: > Hi, > > wine control.exe joy crashed in this line, as it should be wine control.exe joy.cpl. > > The list is just not setup yet as we fail... > > Ciao, Marcus > --- > dlls/shell32/control.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/shell32/control.c b/dlls/shell32/control.c > index cb080d5..b3eddb6 100644 > --- a/dlls/shell32/control.c > +++ b/dlls/shell32/control.c > @@ -55,7 +55,7 @@ void Control_UnloadApplet(CPlApplet* applet) > } > if (applet->proc) applet->proc(applet->hWnd, CPL_EXIT, 0L, 0L); > FreeLibrary(applet->hModule); > - list_remove( &applet->entry ); > + if (applet->entry.next) list_remove( &applet->entry ); > HeapFree(GetProcessHeap(), 0, applet->cmd); > HeapFree(GetProcessHeap(), 0, applet); > } The way Wine standard list implementation works, it should not be NULL here. It seems that list_init call is missing where the CPlApplet is allocated. Cheers, Jacek

3 6

Re: [PATCH 3/5] d3drm: Handle texture associated with the materail when loading a mesh.
by Alexandre Julliard 06 Jun '12

06 Jun '12

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/d3drm/meshbuilder.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 37 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M d3drm.dll -T ../../.. -p d3drm_test.exe.so d3drm.c && touch d3drm.ok d3drm.c:375: Test failed: No texture should be present wine: Unhandled page fault on write access to 0x00162708 at address 0x68353cb7 (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] msi: Add support for 64-bit registry components.
by Alexandre Julliard 05 Jun '12

05 Jun '12

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/msi/action.c | 30 +++++++--- > dlls/msi/msi_main.c | 1 + > dlls/msi/msipriv.h | 1 + > dlls/msi/package.c | 2 - > dlls/msi/tests/install.c | 140 ++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 162 insertions(+), 12 deletions(-) This breaks the Gecko installer on 64-bit for me. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [1/2] user32: Add a test to demonstrate the z-order problem for a top level window with a region.
by Alexandre Julliard 05 Jun '12

05 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/user32/tests/win.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so ../../../../wine/dlls/user32/tests/win.c && touch win.ok win.c:7111: Test succeeded inside todo block: expected next window 0x400ea, got 0x400ea win.c:7114: Test succeeded inside todo block: expected previous window 0x400f0, got 0x400f0 make[1]: *** [win.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] server: Make sure that region and rectangle have the same origin before calling rect_in_region().
by Alexandre Julliard 05 Jun '12

05 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -2457,7 +2457,9 @@ DECL_HANDLER(update_window_zorder) > if (!(ptr->style & WS_VISIBLE)) continue; > if (ptr->ex_style & WS_EX_TRANSPARENT) continue; > if (!intersect_rect( &tmp, &ptr->visible_rect, &rect )) continue; > - if (ptr->win_region && !rect_in_region( ptr->win_region, &rect )) continue; > + tmp = rect; > + offset_rect( &tmp, -ptr->client_rect.left, -ptr->client_rect.top ); > + if (ptr->win_region && !rect_in_region( ptr->win_region, &tmp )) continue; The window region is not in client coordinates. -- Alexandre Julliard julliard(a)winehq.org

1 0