July 2012 - Wine-devel - list.winehq.org

Re: [1/2] gdiplus: Add a test for image stream refcount.
by Marvin 25 Jul '12

25 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=94 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: gdiplus: Handle image loading failures under some XP versions.
by Vincent Povirk 25 Jul '12

25 Jul '12

This looks right to me. I've heard of native having problems sometimes with some JPEG images.

2 1

Re: [2/5] windowscodecs: Add tests for IWICPixelFormatInfo.
by Marvin 25 Jul '12

25 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=90 Your paranoid android. === debiantesting (build) === Can't copy patch to VM: Unable to send '/var/lib/winetestbot/jobs/90/1/patch': + file=/var/lib/winetestbot/staging/patch

1 0

Re: [PATCH 3/3] mshtml: Added runtimeStyle tests
by Marvin 25 Jul '12

25 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20319 Your paranoid android. === W7PROX64 (64 bit style) === style.c:2371: Test failed: textDecoration = (null), expected underline

1 0

RFC: Type safe C interfaces in widl
by Jacek Caban 25 Jul '12

25 Jul '12

Hi all, COM clean up is going well now (thanks Michael!) and after recent conversation about wincodecs clean up, I had an idea about how to get rid of even more casts. We could use widl to teach C a bit more about interface inheritance, so that child->parent interface casts would work in similar way as current obj->iface cast. I experimented a bit and wrote a prove of concept patch for widl (see attached widl.diff). With this patch, COM interfaces become unions in form like this: #ifndef WIDL_TYPE_SAFE_C_INTERFACE interface IWICBitmapFrameDecode { CONST_VTBL IWICBitmapFrameDecodeVtbl* lpVtbl; }; #else union IWICBitmapFrameDecode { CONST_VTBL IWICBitmapFrameDecodeVtbl* lpVtbl; IWICBitmapSource base; }; #endif This is an opt-in macro based solution (so compatibility with standard C interface is not a problem). You may see how this may be used in the attached example of patch (wincodecs.diff). Sadly, it has its drawbacks. Having interface as union instead of struct breaks pretty sane assumption that interface==struct. Also there is no portable way to statically initialize the interface for object-less static interface implementation like: IMyInterface iface_instance = { &MyInterfaceVtbl }; Since using this union based may be controlled per-file, it may not be such a big deal, but I personally really like such constructs, esp. in tests. If we decide to use this solution, there are further decisions to to (it's just a prove of concept now!): - Naming convention. Is 'base' good? Should we use IIfaceName_iface instead (seems too long) - Sometimes &iface->base.base.base constructs will happen. Should we have all parents, instead of only direct parent, in the union, so that we can do iface->IUnknown_iface instead? I don't have strong opinion myself yet, so I'd like to hear others' opinions. Cheers, Jacek

1 0

Re: [PATCH] secur32: Handle incomplete messages in schan_InitializeSecurityContextW().
by Marvin 25 Jul '12

25 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=89 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] secur32: Handle incomplete messages in schan_InitializeSecurityContextW().
by Marvin 25 Jul '12

25 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=88 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: oleaut32: Add support for boolean strings in VarNot.
by Marvin 25 Jul '12

25 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=87 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: windowscodecs: Implement MetadataHandler_GetValue.
by Marvin 25 Jul '12

25 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=86 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH] opengl32: Disable wglGetProcAddress for core GL 1.0/1.1 functions
by Marvin 25 Jul '12

25 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=85 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0