August 2012 - Wine-devel - list.winehq.org

Wine Gecko 1.8-beta1
by Jacek Caban 04 Sep '12

04 Sep '12

Hi all, It's time for another Gecko update. I've uploaded to SourceForge [1] new Gecko builds. These are based on Firefox 16 beta. Other than tons of changes inherited from Firefox and usual fixes to keep it working well for us, it brings a few visible fixes: - Proper <noscript> tag handling - Synchronous ActiveX loading - Possibility to properly call APIs requiring JSContext - Possibility to implement HTMLStyleElement::styleSheet property As usually, to test it you need the attached patch and Gecko build placed in the right place [2]. Any help with testing is appreciated! On related note, I seriously consider dropping debug builds and replace them by unstripped release build or even just a separated package containing only debug symbols for the release build. Here are my thoughts about reasoning (in random order): - People use debug build mostly to retrieve better backtraces. Unstripped builds also give that ability. - If someone really needs debug build, it's easy enough to build it himself (and that's usually a good idea anyway) - Debug builds are seriously different than release build, so it occasionally exposes different set of problems, leading to invalid assumptions. This is really something for developers rather than users. - It costs my time spent builds and tests. And I consider it a serious matter. Amount of work needed to keep Gecko relevant is constantly growing. I try to mitigate it by doing long-term improvements upstream, automating the process and improving my hardware, but that has its limits. And the time spent on Gecko maintenance (as in pure maintenance, not real improvements) costs Wine in terms of improvements I could make in this time. If someone has a reason to keep debug builds, let me know. Any comments are welcomed. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.8-beta1/ [2] http://wiki.winehq.org/Gecko

3 3

vcomp.dll, vcomp90.dll missing on testbot?
by Dan Kegel 03 Sep '12

03 Sep '12

I'm trying to test a better set of stubs for vcomp.dll and its ilk, but those dlls don't seem to be installed on testbot. Is vcomp{,90,100}.dll not installed by default on Windows? If not, should we install it on a few of the VMs?

3 9

Re: [1/16] po: Update Russian translation
by Nikolay Sivov 31 Aug '12

31 Aug '12

On 8/24/2012 10:13, Oleg Yarigin wrote: > > > "To install a new program from a floppy disk, CD-ROM drive, or your hard " > "drive, click Install." > msgstr "" > -"Чтобы установить программу с CD-ROM, дискеты или жёсткого диска, нажмите " > -"Установить." > +"Для установки программы с компакт- или жёсткого диска нажмите «Установить»." You only need to fix quotation marks in original string, the variant you proposed doesn't say what English string is saying. > #: appwiz.rc:62 > -msgid "" > -"The following software can be automatically removed. To remove a program or " > -"to modify its installed components, select it from the list and click Modify/" > -"Remove." > -msgstr "" > -"Перечисленные программы можно автоматически удалить. Чтобы удалить программу " > -"или изменить состав установленных компонентов, выберите её в списке и " > +msgid "The following software can be automatically removed. To remove a " > +"program or to modify its installed components, select it from the list and " > +"click Modify/Remove." > +msgstr "Перечисленные программы могут быть удалены. Для удаления " > +"или изменения состава установленных компонентов, выберите их в списке и " > "нажмите кнопку Изменить/Удалить." Again, don't alter original meaning, no reason to remove 'automatically' here. > #: appwiz.rc:76 > msgid "The following information can be used to get technical support for %s:" > -msgstr "" > -"Указанная информация может быть использована для получения технической " > +msgstr "Указанная информация может быть использована для получения технической " > "поддержки приложения %s:" Nothing changed here. > #: appwiz.rc:35 shell32.rc:141 shell32.rc:238 regedit.rc:122 winefile.rc:104 > msgid "Name" > -msgstr "Имя" > +msgstr "Название" That's questionable. If you really want to change that it will need to depend on context I guess. > #: avifil32.rc:33 > msgid "Wine AVI-default-filehandler" > -msgstr "Обработчик по умолчанию avi-файлов в Wine" > +msgstr "Обработчик avi-файлов по умолчанию в Wine" This alters a meaning a bit, now what you did means that there're some default avi-files in Wine.

3 5

Re: kernel32: Return correct drive type for empty drives
by Alexandre Julliard 31 Aug '12

31 Aug '12

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > Should fix bug #17037 > I followed your advice and now, I only ask the mountmgr when needed. > --- > dlls/kernel32/volume.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) This is failing here when the drive is empty: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so volume.c && touch volume.ok volume.c:132: Tests skipped: can't test removing fake drive volume.c:785: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87 make: *** [volume.ok] Error 1 If I put a DVD in I get: volume.c:813: Test failed: IOCTL_DVD_READ_STRUCTURE should have failed Probably the tests need some fixing. -- Alexandre Julliard julliard(a)winehq.org

4 3

Wine Gecko 1.8-beta1
by Jacek Caban 31 Aug '12

31 Aug '12

Hi all, It's time for another Gecko update. I've uploaded to SourceForge [1] new Gecko builds. These are based on Firefox 16 beta. Other than tons of changes inherited from Firefox and usual fixes to keep it working well for us, it brings a few visible fixes: - Proper <noscript> tag handling - Synchronous ActiveX loading - Possibility to properly call APIs requiring JSContext - Possibility to implement HTMLStyleElement::styleSheet property As usually, to test it you need the attached patch and Gecko build placed in the right place [2]. Any help with testing is appreciated! On related note, I seriously consider dropping debug builds and replace them by unstripped release build or even just a separated package containing only debug symbols for the release build. Here are my thoughts about reasoning (in random order): - People use debug build mostly to retrieve better backtraces. Unstripped builds also give that ability. - If someone really needs debug build, it's easy enough to build it himself (and that's usually a good idea anyway) - Debug builds are seriously different than release build, so it occasionally exposes different set of problems, leading to invalid assumptions. This is really something for developers rather than users. - It costs my time spent builds and tests. And I consider it a serious matter. Amount of work needed to keep Gecko relevant is constantly growing. I try to mitigate it by doing long-term improvements upstream, automating the process and improving my hardware, but that has its limits. And the time spent on Gecko maintenance (as in pure maintenance, not real improvements) costs Wine in terms of improvements I could make in this time. If someone has a reason to keep debug builds, let me know. Any comments are welcomed. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.8-beta1/ [2] http://wiki.winehq.org/Gecko

1 0

Re: kernel32: Add UTF-7 support. (try 5)
by Alexandre Julliard 31 Aug '12

31 Aug '12

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Try 5 adds two tests for the case where srclen < -1 and passes them both. You are still overflowing the source. You need to spend more time on this. You also need to split the patch, and write some sort of table-driven tests so you can test a lot more cases, the ones you have are clearly not sufficient. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Moving pages to/from wiki
by Kyle Auble 31 Aug '12

31 Aug '12

Wed, Aug 29, 2012 16:09, André Hentschel wrote: > get the website source and do "grep -Ri cvs *" > then ignore wwn/ and news/ ... > all that should somehow bring you to http://www.winehq.org/cvs or be deleted grep -r "...." * is rapidly becoming a very good friend of mine ;) I just checked http://cvs.winehq.org and sure enough, there is still a very outdated CVS repository there, but I can't find a template or a PHP applet for it, just the same links you found (most in WWN issues). I've CCed Jeremy Newman because I'm guessing the site admin would have to remove it. As for redirecting to http://www.winehq.org/cvs, since that was designed as a notice page for people trying to browse the source code, I was picturing just redirecting the links to http://source.winehq.org/git and deleting http://www.winehq.org/cvs as only WWN issues and news would still have dangling links. I don't want to remove it if there's another reason for keeping it though. - Kyle

5 6

Re: [PATCH 2/5] hhctrl.ocx: Implement HH_SET_WIN_TYPE (try 7).
by Alexandre Julliard 30 Aug '12

30 Aug '12

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > @@ -1784,11 +1785,25 @@ void ReleaseHelpViewer(HHInfo *info) > OleUninitialize(); > } > > -HHInfo *CreateHelpViewer(LPCWSTR filename, HWND caller) > +static BOOL info_in_list(HHInfo *info) > +{ > + HHInfo *i; > + > + LIST_FOR_EACH_ENTRY(i, &window_list, HHInfo, entry) > + { > + if(i == info) > + return TRUE; > + } > + return FALSE; > +} You should never need that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: Add UTF-7 support. (try 4)
by Alexandre Julliard 30 Aug '12

30 Aug '12

Alex Henrie <alexhenrie24(a)gmail.com> writes: > + do > + { > + if (src[source_index] == 0 && srclen == -1) > + { > + if (dry_run) dest_index++; else if (write_to_w_string(dst, dstlen, &dest_index, 0)) return -1; > + /* when srclen=-1, terminate at the first null character found */ > + break; > + } > + else if (src[source_index] == '+') > + { > + WCHAR byte_pair = 0; > + short offset = 0; > + > + source_index++; /* skip the + sign */ > + > + if (src[source_index] == '-') > + { > + /* just a plus sign escaped as +- */ > + if (dry_run) dest_index++; else if (write_to_w_string(dst, dstlen, &dest_index, '+')) return -1; > + source_index++; > + continue; > + } You are not checking properly for the source string length. Also please add tests for such cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Moving pages to/from wiki
by Kyle Auble 29 Aug '12

29 Aug '12

I'm starting to work on moving static pages to and from the wiki, but I wanted to ask for opinions on a few changes first: 1. Move all static IRC pages to the wiki or add info from the wiki to the static templates? The static pages only mention #winehq and don't describe guidelines, but IRC details shouldn't change much right? 2. For the static About page, some languages also have wiki versions. Do we want to keep the sparser versions currently in use, or add the more detailed information from the wiki version? Both versions seem well-written, and exist for English, Hebrew, & Spanish (I deleted the Polish wiki version; it was a duplicate). 3. Do we still need the static "cvs" page, or should I just redirect any links to it, then delete? On a related note, the WineHQ ToDo on the wiki still claims that a browser for the old CVS source tree is lurking on the site somewhere. Is that true, or do I need to cut that line from the ToDo list? 4. Since licensing tends to be really static could we just redirect the WikiLicense page to the static license page, or should they be kept separate? While I'd think it wouldn't be too hard to reword the static page's intro to include other projects, I'm leery of editing any legal-ese without asking first. By the way, the WikiLicense page says it's LGPL v2.1 in the intro text, but the included license actually looks like v2.0 of the GPL with a modification for libraries. If the wiki version of the page should stay, I'll put in a copy of v2.1 - Kyle

2 1