January 2013 - Wine-devel - list.winehq.org

Re: include: flesh out d3d11.idl
by Nikolay Sivov 10 Jan '13

10 Jan '13

On 1/10/2013 22:35, Austin English wrote: Some minor things. > +typedef enum D3D11_RESOURCE_DIMENSION > +{ > + D3D11_RESOURCE_DIMENSION_UNKNOWN = 0, > + D3D11_RESOURCE_DIMENSION_BUFFER = 1, > + D3D11_RESOURCE_DIMENSION_TEXTURE1D = 2, > + D3D11_RESOURCE_DIMENSION_TEXTURE2D = 3, > + D3D11_RESOURCE_DIMENSION_TEXTURE3D = 4, > +} D3D11_RESOURCE_DIMENSION; > + You could remove values in cases like that, result will be the same. > + D3D11_BIND_VERTEX_BUFFER = 0x00000001L, I think L suffix could be omitted. > +//FIXME: ...

1 0

Re: [PATCH 3/3] d3dx9: Use all 32 bits as mask.
by Matteo Bruni 10 Jan '13

10 Jan '13

2013/1/10 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/texture.c | 6 +++--- > 1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(- > > - DWORD i, v; > + DWORD i, v, mask32 = format->bits[c] == 32 ? -1 : ((1 << format->bits[c]) - 1); Usually we prefer to use ~0U instead of -1 with unsigned variables. Nice cleanups and fixes for larger pixel formats. Is this for Alan Wake?

2 1

Re: Truncate MIDI SysEx messages after termination byte
by Johannes Kroll 10 Jan '13

10 Jan '13

On Wed, 9 Jan 2013 16:10:18 +0100 Christian Costa <titan.costa(a)gmail.com> wrote: > 2013/1/9 Johannes Kroll <jkroll(a)lavabit.com> > > > On Wed, 09 Jan 2013 10:19:54 +0100 > > Christian Costa <titan.costa(a)gmail.com> wrote: > > > > > Le 09/01/2013 04:26, Johannes Kroll a écrit : > > > > Hi, > > > > > > > > On Wed, 09 Jan 2013 03:55:25 +0100 > > > > Christian Costa <titan.costa(a)gmail.com> wrote: > > > > > > > >> Hi, > > > >> > > > >> Please be consistent when using space. 1 space before and after > > > >> operators (<, ==, =, ...). > > > > spaces inserted. HTH. > > > > > > > > J. > > > That's better. You forgot some occurences in the for loop though. > > > > Is it OK if I leave the rest of the formatting to you? Any style is > > fine with me, whatever makes you happy and hopefully gets the patch > > included. > > > > Formatting only patch are not allowed. Clean patch and consistency in code > style help your patch get in. > Alexandre Julliard is the only judge not me. If he is ok with your patch > that's fine. > Anyway having the for loop consistent with rest should not be that hard. > > for(i= 0; i<lpMidiOutHdr->dwBufferLength; i++) The original patch was consistent with my coding style. To make assignments stick out visually, I use no space to the left of the assignment operator, one space to the right. On comparison operators, I use space either on both sides, or none. You will see this in all code I write. I attached another version of the patch. I added 3 more spaces and one line break in a long comment line. You or Alexandre can choose the version they like best. If you still see style issues, please consider changing the style to your liking. If that's not possible, the patch will have to be rejected. If anybody sees non-style-related issues with the patch, please let me know. Please keep any replies on the list(s). Have a nice day. Johannes

2 8

Re: [PATCH] d3dx9: Shift only as much as needed.
by Rico Schüller 10 Jan '13

10 Jan '13

Hi, please don't apply this patch. There are several other occurrences in the same file. I'll send an improved version. Cheers Rico On 10.01.2013 13:55, Rico Schüller wrote: > Hi, > > this patch removes useless shifts, which may result in wrong data when > the shift is bigger than 24. > > Cheers > Rico > > --- > dlls/d3dx9_36/texture.c | 15 ++++++++++++--- > 1 Datei geändert, 12 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) > > > > >

1 0

Re: [2/2] comctl32/listview: Use LVM_SETITEMSTATE directly in tests
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23848 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] ddraw: Don't discard buffers that haven't been used in draws (try 3)
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23842 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9/tests: Merge query.c into device.c.
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23841 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d9/tests: Merge buffer.c into device.c.
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23840 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 17/17] msvcrt: Added read tests on unicode files
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23838 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 13/17] msvcrt: Added _setmode tests
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23836 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0