January 2013 - Wine-devel - list.winehq.org

Re: [1/5] comctl32/tests: more tests for icon spacing calculation
by Alexandre Julliard 25 Jan '13

25 Jan '13

Daniel Jelinski <djelinski1(a)gmail.com> writes: > +#ifdef _WIN64 > + /* NOTE: -1 is not treated the same as (DWORD)-1 by 64bit listview */ > + ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, (DWORD)-1); > +todo_wine { > + expect(100, LOWORD(ret)); > + expect(0xFFFF, HIWORD(ret)); > +} > + ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, 0xBAADF00DDEADBEEFLL); Please avoid ifdefs and long long constants. -- Alexandre Julliard julliard(a)winehq.org

3 2

Wine Wiki needs your help!
by Dimi Paun 24 Jan '13

24 Jan '13

Folks, As we all know, through the years spam has been an ongoing problem. We dealt with it OK, as we valued the openness of our wiki. That's good. However, all this churn has accumulated a lot of garbage on the system, as orphaned pages and dummy users. These have accumulated to such an extent that we are reaching system limits. I need your help to clean them out. First, we have to separate the spam from the real content. I've created a Google Spreadsheet for pages: https://docs.google.com/a/lattica.com/spreadsheet/ccc?key=0AmY-Kp_Ihu3idFNE… and one for users: https://docs.google.com/a/lattica.com/spreadsheet/ccc?key=0AmY-Kp_Ihu3idGdP… We need to mark spam as "Spam" and what's good as "OK" in the "Spam" column. I'll take that data and apply it to the wiki. Please let me know if we can do this any simpler or if there are any problems. Thanks! -- Dimi Paun Lattica, Inc.

8 18

Re: [1/6] windowscodecs: Add tests for IPropertyBag2
by Vincent Povirk 24 Jan '13

24 Jan '13

Other than the 6/6, this series looks good to me. Thanks for breaking this up. It makes it much easier to review.

1 0

Re: [6/6] windowscodecs: Implement IPropertyBag2::Read
by Vincent Povirk 24 Jan '13

24 Jan '13

+ if (idx > -1) + { + VariantInit(pvarValue+i); + res = VariantCopy(pvarValue+i, This->values+idx); + phrError[i] = res; + if (FAILED(res)) + break; + } This looks wrong to me. We have an array of error values to set for each read attempt, so it seems like each read should be independent - one failure shouldn't cause us to give up on the others, nor to free the values we already read successfully. If this is really how Windows works, we need a test for it.

1 0

Re: [5/6] windowscodecs: Implement IPropertyBag2::Write
by Vincent Povirk 24 Jan '13

24 Jan '13

if (This->properties[i].pstrName) { HeapFree(GetProcessHeap(), 0, This->properties[i].pstrName); + VariantClear( This->values+i ); /* Not initialized if pstrName not initialized */ } ... { This->properties = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(PROPBAG2)*count); - - if (!This->properties) + This->values = HeapAlloc(GetProcessHeap(), 0, sizeof(VARIANT)*count); + + if (!This->properties || !This->values) res = E_OUTOFMEMORY; else for (i=0; i < count; i++) Well, that explains why you had the NULL check in the previous patch. If you allocate values with HEAP_ZERO_MEMORY, you don't have to use VariantInit, and you could simplify your Release code (at least in terms of the effort required to verify that it is correct). I think the way it is now is technically correct though. + { + if (pPropBag[i].pstrName) + FIXME("Application tried to set the unknown option %s.\n", + debugstr_w(pPropBag[i].pstrName)); + /* FIXME: Function is not atomar on error, but MSDN does not say anything about it + * (no reset of items between 0 and i-1) */ + return E_FAIL; + } Bit of an indentation glitch there - the return statement isn't (and shouldn't be) in the if statement.

1 0

Re: [4/6] windowscodecs: Implement IPropertyBag2::GetPropertyInfo
by Vincent Povirk 24 Jan '13

24 Jan '13

+ if (This->properties[i].pstrName) + { + HeapFree(GetProcessHeap(), 0, This->properties[i].pstrName); + } HeapFree already checks for NULL, so there's no need for an if statement here.

1 0

Re: [PATCH] ieframe/tests: Don't convert to long path name until the file exists
by Marvin 24 Jan '13

24 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24128 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === Timeout === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2607: Test failed: expected GetOverridesKeyPath webbrowser.c:2612: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2613: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3046: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0

Re: ws2_32: Use assignment instead of memcpy to copy structs.
by Michael Stefaniuc 24 Jan '13

24 Jan '13

Forgot to add the credit for this patch series as I didn't wrote this coccinelle script: Found using the memcpy-assign.cocci script submitted for inclusion into the Linux kernel: https://systeme.lip6.fr/pipermail/cocci/2013-January/000121.html bye michael On 01/24/2013 02:21 PM, Michael Stefaniuc wrote: > --- > dlls/ws2_32/socket.c | 2 +- > dlls/ws2_32/tests/sock.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index c390828..6fd1e34 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -2183,7 +2183,7 @@ static BOOL interface_bind( SOCKET s, int fd, struct sockaddr *addr ) > > if (setsockopt(fd, IPPROTO_IP, IP_UNICAST_IF, &ifindex, sizeof(ifindex)) != 0) > goto cleanup; /* Failed to suggest egress interface */ > - memcpy(&specific_interface_filter, &generic_interface_filter, sizeof(generic_interface_filter)); > + specific_interface_filter = generic_interface_filter; > specific_interface_filter.iface_rule.k = adapter->Index; > filter_prog.len = sizeof(generic_interface_filter)/sizeof(struct sock_filter); > filter_prog.filter = (struct sock_filter *) &specific_interface_filter; > diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c > index 56a64bc..4b4b99a 100644 > --- a/dlls/ws2_32/tests/sock.c > +++ b/dlls/ws2_32/tests/sock.c > @@ -2725,7 +2725,7 @@ static void test_getsockname(void) > return; > } > > - memcpy(&sa_get, &sa_set, sizeof(sa_set)); > + sa_get = sa_set; > if (getsockname(sock, (struct sockaddr*) &sa_get, &sa_get_len) == 0) > ok(0, "getsockname on unbound socket should fail\n"); > else {

1 0

Re: ieframe: Fixed a race in tests
by Marvin 24 Jan '13

24 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24121 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === Timeout === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2607: Test failed: expected GetOverridesKeyPath webbrowser.c:2612: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2613: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3046: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0

Re: [PATCH 2/2] vbscript: Added GetObject tests
by Marvin 24 Jan '13

24 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24115 Your paranoid android. === W2KPROSP4 (32 bit createobj) === createobj.c:999: Test failed: ParseScriptText failed: 8007007e createobj.c:1000: Test failed: expected QI_IObjectWithSite createobj.c:1001: Test failed: expected SetSite createobj.c:1002: Test failed: expected reportSuccess createobj.c:1008: Test failed: hres = 8007007e createobj.c:1009: Test failed: expected QI_IObjectWithSite createobj.c:1010: Test failed: expected SetSite createobj.c:1015: Test failed: ParseScriptText failed: 8007007e createobj.c:1016: Test failed: expected QI_IObjectWithSite createobj.c:1017: Test failed: expected reportSuccess

1 0