March 2013 - Wine-devel - list.winehq.org

Re: [2/2] wmvcore: Stub implementation of IWMMetadataEditor interface (try2)
by Nikolay Sivov 11 Mar '13

11 Mar '13

On 3/11/2013 16:36, Jeff Latimer wrote: > + if (!ppv) return E_INVALIDARG; You don't need this most likely. > + IUnknown_AddRef((IUnknown*)*ppv); A cleaner way is to AddRef original iface, but that's a matter of taste. > +static ULONG WINAPI WMCreateEditor_AddRef(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + return 2; > +} > + > +static ULONG WINAPI WMCreateEditor_Release(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return 1; > +} What's this supposed to mean? > +HRESULT WINAPI WMCreateEditor_flush(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} > + > +HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} I don't think so. > HRESULT WINAPI WMCreateEditor(IWMMetadataEditor **editor) > { > + IWMMetadataEditor *This; > FIXME("(%p): stub\n", editor); > > - *editor = NULL; > + This = HeapAlloc(GetProcessHeap(), 0, sizeof(IWMMetadataEditor)); > + if (!This) return E_OUTOFMEMORY; > > - return E_NOTIMPL; > + This->lpVtbl = &Editor_vtable; > + *editor = This; > + > + return S_OK; > } That's not how it's done, there's plenty of examples already. > -}; > +} That change is ok I think.

1 0

Re: [1/2] include: Implement part of nserror.h
by Nikolay Sivov 11 Mar '13

11 Mar '13

On 3/11/2013 10:27, Jeff Latimer wrote: > --- > include/nserror.h | 226 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 226 insertions(+) > create mode 100644 include/nserror.h > +#ifndef _NSERROR_H > +#define _NSERROR_H This doesn't look right. > +#define NS_S_CALLPENDING_HRESULT_TYPEDEF_(0x000D0000L) This is usually done with a suffix. > + > +#endif Please add a comment here.

2 2

Re: wininet: Skip test_open_url_async on IEs older than 7.
by Marvin 09 Mar '13

09 Mar '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24685 Your paranoid android. === WVISTAADM (32 bit http) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: dpnet/tests: Allow buffersize used by Win8
by Marvin 09 Mar '13

09 Mar '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24682 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF

1 0

Crash confuses me
by Graham 09 Mar '13

09 Mar '13

I use a LD_PRELOAD before running wine so that i can debug my application. The library which is preloaded is able to replace system dlsym and from that, other consequence library call. There is no problem until, i put some Detour code(hot patching) into the kernel32.dll.so address space. But the very funny things is this ** THE PROGRAM CRASHES BEFORE MY HOTPATCH IS APPLIED ** so it seems somehow the order of cause and effect is extremely weird and frightening to me. How can a piece of code which is not excecuted be teh cause for errors PRIOR/BEFORE to its execution. And this is surely happening because when i uncomment the Hotpatch/detour lines the problem goes away. here are some lines from the crashs ... err:module:attach_process_dlls "user32.dll" failed to initialize, aborting err:module:LdrInitializeThunk Main exe initialization for L"C:\\windows\\system32\\winemenubuilder.exe" failed, status c0000005 wine: Unhandled page fault on execute access to 0x7c9e4cd7 at address 0x7c9e4cd7 (thread 000b), starting debugger... err:module:DelayLoadFailureHook failed to delay load user32.dll.BroadcastSystemMessageW wine: Call from 0x7b83ba92 to unimplemented function user32.dll.BroadcastSystemMessageW, aborting wine: Unimplemented function user32.dll.BroadcastSystemMessageW called at address 0x7b83ba92 (thread 001d), starting debugger... Another thing to notice is that this was tested using wine1.4.1 However it DOES work with wine1.5.10 ... to get something to work for me is not the challenge, its to understand the logic behind why something does not. THanks a lot and I am grateful for any who contributes his knowledge to this problem i am a real NOVICE

5 8

Re: comctl32/listview: fix overwriting of item values
by Nikolay Sivov 09 Mar '13

09 Mar '13

On 3/9/2013 10:03, Daniel Jelinski wrote: Makes sense, thanks. I briefly searched for such cases and LISTVIEW_FindItemW() seems to be broken the same way.

1 0

spec file and -arch
by Stefan Leichter 08 Mar '13

08 Mar '13

Hi, when i look into msvcr100.spec file i find lots of different parameters for the switch (?) -arch . So fare i have seen: arm, i386, win32, win64 and x86_64 . To me it is not clear what is the difference between win64 and x86_64. The same for i386 and win32. What are is the criteria to choose the first or the second? If it makes a difference do i have to distinguish between arm and ... ? Does -i386 and -arch=i386 mean the same? Thank you for enlightening me Stefan

2 1

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 3).
by Alexandre Julliard 08 Mar '13

08 Mar '13

Sergey Guralnik <serhio(a)etersoft.ru> writes: > This patch demonstrates the most interest case from previous versions. > When SetWindowPos() moves child window, that has some invalid > area, it also invalidates children of this window according to its > update region, even if moved window has WS_CLIPCHILDREN style. > > Wine doesn't perform this invalidation. > One pretty large application depends on this feature, and now, > runned under Wine, it has broken output. > > Hope this variant is more clear than all previous. It's better, but testing the message sequence doesn't seem very useful, particularly since you don't differentiate parent and child messages. Also you should test the region before the move to show that it's the move that's changing it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcr110: Add VS2012 C/C++ runtime
by Alexandre Julliard 08 Mar '13

08 Mar '13

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -0,0 +1,2260 @@ > +# MS VC++2012 runtime library > + > +@ stub -arch=arm ??0?$_SpinWait@$00(a)details@Concurrency@@QAA(a)P6AXXZ@Z > +@ stub -arch=win32 ??0?$_SpinWait@$00(a)details@Concurrency@@QAE(a)P6AXXZ@Z > +@ stub -arch=win64 ??0?$_SpinWait@$00(a)details@Concurrency@@QEAA(a)P6AXXZ@Z > +@ stub -arch=arm ??0?$_SpinWait@$0A@@details(a)Concurrency@@QAA(a)P6AXXZ@Z > +@ stub -arch=win32 ??0?$_SpinWait@$0A@@details(a)Concurrency@@QAE(a)P6AXXZ@Z > +@ stub -arch=win64 ??0?$_SpinWait@$0A@@details(a)Concurrency@@QEAA(a)P6AXXZ@Z > +@ stub -arch=arm,win32 ??0SchedulerPolicy(a)Concurrency@@QAA(a)IZZ That doesn't make much sense, arm is win32 too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winhttp: Implement WINHTTP_OPTION_CONNECTION_INFO. (try 2)
by Alexandre Julliard 08 Mar '13

08 Mar '13

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/winhttp/session.c | 71 ++++++++++++++++++++++++++++++++++++++++++ > dlls/winhttp/tests/winhttp.c | 62 ++++++++++++++++++++++++++++++++++++ > include/winhttp.h | 16 ++++++++++ > 3 files changed, 149 insertions(+) Now it breaks the Android build... i686-linux-android-gcc -c -I../../../../wine/dlls/winhttp -I. -I../../../../wine/include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -o session.o ../../../../wine/dlls/winhttp/session.c ../../../../wine/dlls/winhttp/session.c: In function 'convert_sockaddr': ../../../../wine/dlls/winhttp/session.c:609:25: error: 'struct WS_sockaddr_in' has no member named '__pad' make[1]: *** [session.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0