May 2013 - Wine-devel - list.winehq.org

Re: msi/tests: Add a trailing '\n' to an ok() call.
by Christian Costa 02 May '13

02 May '13

2013/5/2 Francois Gouget <fgouget(a)free.fr> > --- > dlls/msi/tests/install.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c > index e5d996e..0c322be 100644 > --- a/dlls/msi/tests/install.c > +++ b/dlls/msi/tests/install.c > @@ -3110,7 +3110,7 @@ static void test_continuouscabs(void) > > /* Filename from msi is right and the one from cab is wrong */ > create_cc_test_files(); > - ok(MoveFile("test2.cab", "test2_.cab"), "Cannot rename test3.cab to > test3_.cab"); > + ok(MoveFile("test2.cab", "test2_.cab"), "Cannot rename test3.cab to > test3_.cab\n"); > create_database(msifile, cc3_tables, sizeof(cc3_tables) / > sizeof(msi_table)); > > MsiSetInternalUI(INSTALLUILEVEL_NONE, NULL); > -- > 1.7.10.4 > > > Hi François, Can you fix the typo test3 to test2 as well please ? Thanks Christian

1 0

Re: [1/6] include: add transact.h, txdtc.h and txcoord.h (try 2)
by Alexandre Julliard 02 May '13

02 May '13

Daniel Jeliński <djelinski1(a)gmail.com> writes: > From 6b7cd0b30b3eaf22d9b9bbef733163e74cc04ca8 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Wed, 1 May 2013 20:28:10 +0200 > Subject: include: add transact.h, txdtc.h and txcoord.h > > this time based on minGW headers. Originals found here: > http://sourceforge.net/apps/trac/mingw-w64/browser/experimental/headers_add… This clearly needs to be generated from idl instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine-patches
by Daniel Jeliński 02 May '13

02 May '13

Hello, I sent a ~200KB patch to wine-patches last night and it disappeared without a trace. I'm wondering if it got lost or just went to moderation. Regards, Daniel PS.I just resent it, still no luck.

2 1

Re: [2/4] include: added transact.idl (resend)
by Alexandre Julliard 01 May '13

01 May '13

Daniel Jeliński <djelinski1(a)gmail.com> writes: > +import "unknwn.idl"; > + > +interface ITransaction; > +interface ITransactionDispenser; > +interface ITransactionOptions; > +interface ITransactionOutcomeEvents; > +interface ITransactionCompletionEvents; > + > +/*========================================================================== > + * Transaction related types > + *==========================================================================*/ > + > +[local,pointer_default(unique)] > +interface BasicTransactionTypes > + { > + > + typedef struct BOID { > + byte rgb[16]; > + } BOID; > + > + cpp_quote("#define BOID_NULL (*((BOID*)(&IID_NULL)))") > + > + /* change the following two line together */ > + cpp_quote("#ifndef MAX_TRAN_DESC_DEFINED") /* conflicts with uimsg.h. This is temporary work around */ > + cpp_quote("#define MAX_TRAN_DESC_DEFINED") > + typedef enum TX_MISC_CONSTANTS > + { > + MAX_TRAN_DESC = 40 > + } TX_MISC_CONSTANTS; > + cpp_quote("#endif") > + > + /* Unit Of Work. */ > + > + typedef BOID XACTUOW; > + > + /* Data type for isolation level values. */ > + > + typedef LONG ISOLEVEL; > + > + /* Constants that specifiy isolation level of a transaction. */ > + > + typedef enum ISOLATIONLEVEL { > + ISOLATIONLEVEL_UNSPECIFIED = 0xFFFFFFFF, > + ISOLATIONLEVEL_CHAOS = 0x00000010, > + ISOLATIONLEVEL_READUNCOMMITTED = 0x00000100, > + ISOLATIONLEVEL_BROWSE = 0x00000100, /* Synonym for _READUNCOMITTED */ > + ISOLATIONLEVEL_CURSORSTABILITY = 0x00001000, > + ISOLATIONLEVEL_READCOMMITTED = 0x00001000, /* Synonym for _CURSORSTABILITY */ > + ISOLATIONLEVEL_REPEATABLEREAD = 0x00010000, > + ISOLATIONLEVEL_SERIALIZABLE = 0x00100000, > + ISOLATIONLEVEL_ISOLATED = 0x00100000, /* Synonym for _SERIALIZABLE */ > + } ISOLATIONLEVEL; > + > + /* Transaction information structure, used in ITransaction */ > + > + typedef struct XACTTRANSINFO { > + XACTUOW uow; /* The current unit of work */ > + ISOLEVEL isoLevel; /* The isolation level for the current UOW */ > + ULONG isoFlags; /* Values from ISOFLAG enumeration */ > + DWORD grfTCSupported; /* Flags indicating capabilities */ > + DWORD grfRMSupported; /* ... of this transaction wrt */ > + DWORD grfTCSupportedRetaining; /* ... parameters to Commit */ > + DWORD grfRMSupportedRetaining; /* ... */ > + } XACTTRANSINFO; > + > + typedef struct XACTSTATS { > + ULONG cOpen; /* The number of currently extant transactions. */ > + ULONG cCommitting; /* The number of transactions which are proceding towards committing. */ > + ULONG cCommitted; /* The number of transactions that are have been committed. */ > + ULONG cAborting; /* The number of transactions which are in the process of aborting. */ > + ULONG cAborted; /* The number of transactions that are have been aborted. */ > + ULONG cInDoubt; /* The number of transactions which are presently in doubt. */ > + ULONG cHeuristicDecision; /* The number of transactions that have completed by heuristic decision. */ > + FILETIME timeTransactionsUp; /* The amount of time that this transaction service has been up. */ > + } XACTSTATS; This is clearly a straight copy of the SDK header. You can't do that. -- Alexandre Julliard julliard(a)winehq.org

3 3

GSoC proposal
by George Stephanos 01 May '13

01 May '13

Hello wine-devel! This is my proposal as a student for Google Summer of Code 2013. I'm George Stephanos from the "Arab Academy for Science and Technology" situated in Egypt. gsteph on #winehackers I'm currently about to finish my second semester as a BSc in CS. Previous Experience: I haven't developed for Wine before though I've always been a big fan of the project. I'm fairly good with C/C++ and Python and I think I have enough Win32 API experience. I've previously developed small WinSock, DirectX and classic GUI applications (with and without MFC). I'm a freelancer. I've worked (alone) on around 25-30 projects rating 4+/5 in each. I've enrolled in Google Code-In 2010 and 2011 (which is basically GSoC for high school students) writing lots of ARM assembly code for VideoLAN (#x264dev on freenode). In 2011, I would have ranked 12th if not for an issue that occurred between VideoLAN and Google. Proposal: I've read your ideas page and the only registry task [1] has particularly caught my attention. I'm aware of what I need to do. I've read [2], [3] and [4]. I haven't yet browsed the Wine tree at all and I'll probably be missing implementation strategies but that'll hopefully be worked out with my mentor. [1] - http://wiki.winehq.org/SummerOfCode?#head-40e316e01066b5a129cd65073fa4b89dd… [2] - http://bugs.winehq.org/show_bug.cgi?id=14771 [3] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724475(v=vs.85).a… [4] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724498(v=vs.85).a… Tell me if you need more information. Hope you consider me! Thanks, George

3 2

Re: server: Map update region to children even if window just moved.
by Alexandre Julliard 01 May '13

01 May '13

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -1618,7 +1618,7 @@ static void set_window_pos( struct window *win, struct window *previous, > const rectangle_t old_visible_rect = win->visible_rect; > const rectangle_t old_client_rect = win->client_rect; > rectangle_t rect; > - int client_changed, frame_changed; > + int client_changed, frame_changed, frame_moved = 0; > int visible = (win->style & WS_VISIBLE) || (swp_flags & SWP_SHOWWINDOW); > > if (win->parent && !is_visible( win->parent )) visible = 0; > @@ -1727,9 +1727,10 @@ static void set_window_pos( struct window *win, struct window *previous, > client_rect->bottom - old_client_rect.bottom != y_offset || > !valid_rects || > memcmp( &valid_rects[0], client_rect, sizeof(*client_rect) )); > + frame_moved = x_offset || y_offset; > } > > - if (frame_changed || client_changed) > + if (frame_changed || client_changed || frame_moved) It doesn't make sense to have all these complicated tests if we are going to always repaint anyway, which is essentially what your patch does. There has to be more to it than that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.
by Marvin 01 May '13

01 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25385 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.
by Hans Leidekker 01 May '13

01 May '13

On Wed, 2013-05-01 at 12:40 +0200, Christian Costa wrote: > diff --git a/dlls/msi/media.c b/dlls/msi/media.c > index 612624d..4145c76 100644 > --- a/dlls/msi/media.c > +++ b/dlls/msi/media.c > @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet(FDINOTIFICATIONTYPE fdint, > > if (strcmpiW( mi->cabinet, cab )) > { > - ERR("Continuous cabinet does not match the next cabinet in the Media table\n"); > - goto done; > + LPSTR next_cab; > + > + WARN("Continuous cabinet %s does not match the next cabinet %s in the media table => use latter one\n", debugstr_w(cab), debugstr_w(mi->cabinet)); > + > + /* Use cabinet name from the media table */ > + next_cab = strdupWtoA(mi->cabinet); > + /* Modify path to cabinet file with full filename (psz3 points to a 256 bytes buffer that can be modified contrary to psz1 and psz2) */ > + strcat(pfdin->psz3, "\\"); > + strcat(pfdin->psz3, next_cab); > + /* Path psz3 and cabinet psz1 are concatenated by FDI so just reset psz1 */ > + *pfdin->psz1 = 0; > + msi_free(next_cab); The cabinet name alone can be up 256 characters so you should at least check that you're not overflowing the buffer.

2 1

winex11.drv
by Christopher Cope 01 May '13

01 May '13

I am unsure how the "enum x11drv_atoms" in the file dlls/winex11.dev/x11drv.h works. My /usr/include/Xatom.h defines XA_LAST_PREDEFINED as 68. Presumably, therefore XATOM_Rel_X and XATOM_Rel_X should be 81 and 82 respectively. However, when I dump the values I get 195 and 196. I am attempting to add XATOM_Abs_X and XATOM_Abs_X with values of 480 and 481 for a patch I'm working on. I could simply define the values elsewhere, but I assumed I should try to make it blend with the other code as much as possible. Any help is appreciated thank you.

2 4

GSoC proposal
by George Stephanos 01 May '13

01 May '13

Hello wine-devel! This is my proposal as a student for Google Summer of Code 2013. I'm George Stephanos from the "Arab Academy for Science and Technology" situated in Egypt. gsteph on #winehackers I'm currently about to finish my second semester as a BSc in CS. Previous Experience: I haven't developed for Wine before though I've always been a big fan of the project. I'm fairly good with C/C++ and Python and I think I have enough Win32 API experience. I've previously developed small WinSock, DirectX and classic GUI applications (with and without MFC). I'm a freelancer. I've worked (alone) on around 25-30 projects rating 4+/5 in each. I've enrolled in Google Code-In 2010 and 2011 (which is basically GSoC for high school students) writing lots of ARM assembly code for VideoLAN (#x264dev on freenode). In 2011, I would have ranked 12th if not for an issue that occurred between VideoLAN and Google. Proposal: I've read your ideas page and the only registry task [1] has particularly caught my attention. I'm aware of what I need to do. I've read [2], [3] and [4]. I haven't yet browsed the Wine tree at all and I'll probably be missing implementation strategies but that'll hopefully be worked out with my mentor. [1] - http://wiki.winehq.org/SummerOfCode?#head-40e316e01066b5a129cd65073fa4b89dd… [2] - http://bugs.winehq.org/show_bug.cgi?id=14771 [3] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724475(v=vs.85).a… [4] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724498(v=vs.85).a… Tell me if you need more information. Hope you consider me! Thanks, George

1 0