January 2014 - Wine-devel - list.winehq.org

Re: [PATCH 2/3] ddraw/tests: Rewrite AttachmentTest() and AttachmentTest7().
by Marvin 17 Jan '14

17 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4304 Your paranoid android. === w2008s64 (64 bit ddraw7) === ddraw7.c:5769: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:5795: Test failed: Failed to create surface, hr 0x80004002. === w7pro64 (64 bit ddraw7) === ddraw7.c:5769: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:5795: Test failed: Failed to create surface, hr 0x80004002.

1 0

Re: [5/5] gdiplus: Add test for page transform in metafiles.
by Marvin 17 Jan '14

17 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4302 Your paranoid android. === wxppro (32 bit metafile) === metafile.c:872: Test failed: Expected 72.000000, got 81.279991 metafile.c:880: Test failed: Expected 00000168, got 00000196 === wvista (32 bit metafile) === metafile.c:872: Test failed: Expected 72.000000, got 81.279991 metafile.c:880: Test failed: Expected 00000168, got 00000196 === w2008s64 (32 bit metafile) === metafile.c:872: Test failed: Expected 72.000000, got 81.279991 metafile.c:880: Test failed: Expected 00000168, got 00000196 === w7pro64 (32 bit metafile) === metafile.c:872: Test failed: Expected 72.000000, got 81.279991 metafile.c:880: Test failed: Expected 00000168, got 00000196 === w2008s64 (64 bit metafile) === metafile.c:872: Test failed: Expected 72.000000, got 81.279999 metafile.c:880: Test failed: Expected 00000168, got 00000196 === w7pro64 (64 bit metafile) === metafile.c:872: Test failed: Expected 72.000000, got 81.279991 metafile.c:880: Test failed: Expected 00000168, got 00000196

1 0

Re: [PATCH] widl: Fix pointer size for SYS_WIN64 typelibs
by Alexandre Julliard 16 Jan '14

16 Jan '14

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > --- > tools/widl/write_msft.c | 28 +++++++++++++--------------- > 1 file changed, 13 insertions(+), 15 deletions(-) It breaks the tests: ../../../../wine/tools/runtest -q -P wine -T ../../.. -M oleaut32.dll -p oleaut32_test.exe.so typelib && touch typelib.ok typelib.c:3909: Test failed: typeattr->cbSizeInstance expected 4 got 8 typelib.c:3909: Test failed: typeattr->cbSizeInstance expected 4 got 8 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: tests: Avoid duplicating debugstr_guid()
by Marvin 16 Jan '14

16 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4266 Your paranoid android. === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found

1 0

Re: tests: Avoid duplicating debugstr_guid()
by Marvin 16 Jan '14

16 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4252 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9845: Test failed: got 00244F94

1 0

Re: dpnet: Improve Error checking in Get/Set SP
by Stefan Dösinger 15 Jan '14

15 Jan '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, > + hr = IDirectPlay8Address_GetSP(localaddr, &guidsp); > + ok(hr == DPNERR_DOESNOTEXIST, "got 0x%08x\n", hr); For the sake of completion I'd test setting GUID_NULL, IID_IUnknown and something nonsensical like IID_IDirectDrawGammaControl (or maybe something you have access to without additional headers like IID_IDirectPlay8Address). Some style nitpicks follow. If you end up becoming the de-facto maintainer of dplay it's up to you how important they are: > + sprintf(buf, > + "{%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x}", > + guid->Data1, guid->Data2, guid->Data3, > + guid->Data4[0], guid->Data4[1], guid->Data4[2], guid->Data4[3], > + guid->Data4[4], guid->Data4[5], guid->Data4[6], guid->Data4[7]); In the d3d code we use 8 space indentations. You may want to follow that. Also, there's debugstr_guid in wine/debug.h. It seems you're aware of that and used your own functions because wine/debug.h doesn't work in the tests. Is this correct? > + if(!pguidSP) > + return DPNERR_INVALIDPOINTER; > ... > + if( SUCCEEDED(hr) ) > + { > ... > + if (hr != S_OK) The whitespaces around the () are inconsistent. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS1kqJAAoJEN0/YqbEcdMwfngP/RUrjrAH/vDvQH+jtBSOQwd8 OymWNEWmt4jqzt3febi5Mo15oDGSuuqIjcyoRwpOTPrlmwGYmeAjm/z5JxAcH+o1 XFhZF8zL85u0sAlW8A3bAEuPB/a0nP2/K8y523mt+uFYz/4cOwv11sR/fAJjCgR5 SkkWI29t/JXBkQmPhQHArdyi1CgRTQ+MSNEwzM3B+nudn8zhjV3VH+WYDyLkl8D6 GS3GBJqAAka0Iqo6KdVC4VTdxSVUJVivfAZSlSTZVHcYAlC49k6F5uYtTLd+MQRZ bUlnHSkJtveC1lj9FiIliJexO1M9zLr+lY5/RtD9ntbe4K5i+tgEpjExg6uSNbmD cw6IjE+qcrQsp2x9NBED7j1OetUmjeUgwUQcWo56FoVQBp9N7ynSLF2HOPQ7rf8Q SHroMxtOzwPHxmyXNFDCbDYwnVviq17KqSOXcD46VvY99NbFEmm5nyPBNuLUzPQb JkkakS4i1+eUigD3QnY5eHE5NPWJBq4/WeEF9TYtBUjg30Q0pU5CmDf888fyFPj2 UYsheWKR5LcUIZ3oXFPrzcaiS+1hLAfEiKCH8VXsNCPMV4S6KDS2hIhHJQh3mWEj z//uLe23Ll2bNrZOOfzwWBGfAmLNB+TfW+Q2phXlTTH5lgITxU4N0KR/pNpCkqz8 KrWsuFvS8iZSfT3G+fSw =XG/n -----END PGP SIGNATURE-----

2 1

Re:My ideas of New wine function.
by Akira Nakagawa 15 Jan '14

15 Jan '14

http://wiki.winehq.org/AkiraNakagawa Please write your opinion here. I think the compatibility is the first we maintain. So we should do it optionally.

1 0

Re: wine.inf: Add DirectPlay8 Registry keys
by Bruno Jesus 14 Jan '14

14 Jan '14

On Fri, Jan 10, 2014 at 5:06 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > wine.inf: Add DirectPlay8 Registry keys This patch seems to make Rise of Nations go a lit bit further in it's attempt to get multiplayer running. > Best Regards > Alistair Leslie-Hughes Regards, Bruno

4 7

Re: [bcrypt] add missing definitions
by Dmitry Timoshkov 14 Jan '14

14 Jan '14

Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote: > +#define MS_PRIMITIVE_PROVIDER L"Microsoft Primitive Provider" > + > +/* Algorithm Identifiers */ > +#define BCRYPT_RSA_ALGORITHM L"RSA" This can't work properly in Wine. -- Dmitry.

4 5

[2/4] gdi32: Fix text rotation problem in GM_ADVANCED graphics mode.
by Ralf Habacker 14 Jan '14

14 Jan '14

>On Tue, Jan 07, 2014 at 02:33:32PM +0100, Ralf Habacker wrote: >> @@ -1327,6 +1327,20 @@ BOOL WINAPI GetTextExtentExPointW( HDC hdc, LPCWSTR str, INT count, INT max_ext, >> } >> } >> >> + XFORM old; >> + BOOL exclude_rotation = FALSE; >> + if ( GetGraphicsMode( hdc ) == GM_ADVANCED ) >> + { >> + GetWorldTransform( hdc, &old ); >> + XFORM xf = old; >> + if ( hasRotatedAndSameScaledMatrixOnly( &xf ) ) >> + { >> + exclude_rotation = TRUE; >> + removeRotationFromMatrix( &xf, NULL ); >> + SetWorldTransform( hdc, &xf ); >> + } >> + } > >Does Windows really do this only in the same-scaled, non-sheared case? The updated patch http://www.winehq.org/pipermail/wine-patches/2014-January/129505.html contains a related hint from the developer: "Note: The current implementation only works on matrixes with uniform scale and shear, which has to be checked by a call to xform_has_rotate_and_uniform_scale_and_shear(). Hints how to get *unique* values for non-uniform matrixes are welcome." The application, for which the patch has been written (http://appdb.winehq.org/objectManager.php?sClass=application&iId=13649) works fine with this patches, as it only uses dc rotatation. Regards Ralf

1 0