October 2014 - Wine-devel - list.winehq.org

Re: Assorted spelling/grammar fixes
by Marvin 02 Oct '14

02 Oct '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9197 Your paranoid android. === w8 (32 bit visual) === visual.c:2635: Test failed: unexpected colortable on offscreen surface

1 0

Re: msvcrt: Make the first call to fwrite bufferred (try2)
by Andreas Fuchs 02 Oct '14

02 Oct '14

Hi Piotr, Hi all, I traced down this commit as the origin of the regression, where I cannot parse stdout of wine correctly anymore. See also https://bugs.winehq.org/show_bug.cgi?id=37345 I hope, sombody knowledgable (Piotr maybe you as the author) could help me figure this out or even provide a fix... Description: When calling wine from another process after redirecting stdout to a pipe, wine does not flush the stdout-buffer correctly anymore (Wine 1.6 did correctly). Attached is a usecase. To test do: i686-w64-mingw32-gcc helloworld.c gcc callwine.c ./a.out What will happen is: - on a buggy wine it will take 10 seconds and then all of the stdout-buffer is flushed on the exit of the child. (imagine the child would run longer than the 10 seconds) - on a good wine we will see some stdout-content then 10 second sleep and then the rest of the content. This is a regression that happened between 1.7.4 and 1.7.5. The bisect identified commit afec0b00bd6250fe21e8deccbc8116a4aca6a7a4 "msvcrt: Make the first call to fwrite buffered." as problem. The attached patch is a revert of this commit ported forward to 1.7.27. Unfortunately I don't quite grasp the logics of the offending commit. If somebody who knows that patch could help, I'd highly appreciate it. Cheers, Andreas

3 2

Re: [PATCH 1/3] comctl32: Move TaskDialogIndirect function to separate file
by Nikolay Sivov 02 Oct '14

02 Oct '14

On 10/1/2014 16:35, Joachim Priesner wrote: > +#include <stdarg.h> > +#include <string.h> > + > +#include "comctl32.h" > +#include "shlwapi.h" > + > +#include "windef.h" > +#include "winbase.h" > +#include "wingdi.h" > +#include "winternl.h" > +#include "dlgs.h" > +#include "wine/debug.h" > +#include "wine/unicode.h" It's unlikely you need all of those. > +#define TD_WARNING_ICON MAKEINTRESOURCEW(-1) > +#define TD_ERROR_ICON MAKEINTRESOURCEW(-2) > +#define TD_INFORMATION_ICON MAKEINTRESOURCEW(-3) > +#define TD_SHIELD_ICON MAKEINTRESOURCEW(-4) Where this comes from? I mean particular id values.

2 2

Re: [PATCH 1/6] user32/tests: Test minimizing an unminimizable window.
by Dmitry Timoshkov 02 Oct '14

02 Oct '14

Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This shows that the abesence of a minimization button does not prevent > the application from programmatically minimizing the window. KWin and > fvwm behave like Windows in this regard, whereas Metacity-based WMs > prevent the minimization. My understanding is that not the absence of minimize/maximize button prevents an ability to programmatically minimize/maximize a window, but an item in the system menu. I'd suggest to also add a test for sending WM_SYSCOMMAND/SC_MINIMIZE/SC_MAXIMIZE behaviour. -- Dmitry.

2 2

Re: [PATCH 6/6] d3d8/tests: Test messages on focus loss (v2).
by Marvin 01 Oct '14

01 Oct '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9170 Your paranoid android. === w8 (32 bit device) === device.c:2325: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2330: Test failed: The focus window is active. device.c:2336: Test failed: Got unexpect width 640. device.c:2337: Test failed: Got unexpect height 480. device.c:2477: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3119: Test failed: Expected wndproc 0x413050, got 0x413050.

2 1

Re: [PATCH 1/6] user32/tests: Test minimizing an unminimizable window.
by Marvin 01 Oct '14

01 Oct '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9167 Your paranoid android. === w7u (32 bit msg) === msg.c:12149: Test failed: unexpected hwnd 0017014A msg.c:12171: Test failed: bad time 3077e/3078e

2 1

Re: [2/4] server: Support sending process and thread security descriptors for the "new_process" request in the protocol.
by Alexandre Julliard 01 Oct '14

01 Oct '14

Joris van der Wel <joris(a)jorisvanderwel.com> writes: > + if (req->process_sd_size > get_req_data_size() || > + req->thread_sd_size > get_req_data_size() - req->process_sd_size || > + req->info_size > get_req_data_size() - req->process_sd_size - req->thread_sd_size) > + { > + close( socket_fd ); > + return; > + } You have to return an error. > + req_info = (const startup_info_t *) > + ((char*)get_req_data() + req->process_sd_size + req->thread_sd_size); > + req_env = (const WCHAR *) > + ((char*)get_req_data() + req->process_sd_size + req->thread_sd_size + req->info_size); > + req_env_size = get_req_data_size() - (req->process_sd_size + req->thread_sd_size + req->info_size); These may not be valid pointers (alignment is not checked) so it would be better to avoid declaring them as variables. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine Gecko 2.34-beta1 release
by Jacek Caban 01 Oct '14

01 Oct '14

Hi all, After about a year since the last release, I'm happy to announce that we have a new Wine Gecko packages ready for testing. I'm not attaching a patch this time, because it's quite big and will change over next few weeks (I will be submitting some of those changes, so the patch would be invalid soon). I set up a Wine fork at [1] instead. It contains snapshot of my development tree on top of Wine, so be prepared for forced updates. Let me know if you'd prefer it to be in a different form. This update catches up on development made for 10 Firefox releases that happened meantime. There were many problems that needed to be solved for this to happen. There were tree wide changes breaking our build config as well as API changes, that needed to be fixed. We still have long term problem with API that we use for embedding Gecko (mostly DOM APIs) that is slowly removed from Gecko. We need a long term solution, which means working on auto generated C/C++ bindings based on the new, WebIDL files. I may write a separated mail about that if there is an interest. I decided to make this beta from Gecko tip at the point where it's branched. I usually waited until Gecko enters beta, but I want to catch up on development as much as possible this time. How the final release will look like depends on how testing goes. It will not be sooner than after a bit of Firefox beta. As usually, everything that uses MSHTML is an interesting testing target. Let me know if there are any problems. Thanks, Jacek [1] http://repo.or.cz/w/wine/wine-gecko.git

2 3

Re: [PATCH 4/5] d3d9/tests: Add a test for vs_3_0 shaders using more than 256 constants.
by Stefan Dösinger 01 Oct '14

01 Oct '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-09-30 14:51, schrieb Matteo Bruni: > --- > dlls/d3d9/tests/device.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) I think it would be a good idea to check the behavior of d3d9ex. It may lift some restrictions of plain d3d9. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUK+z6AAoJEN0/YqbEcdMwrrsP/1aU53A4nN8vmohZ4KtnKs42 DYvnr1cJxCjRCTM9c8xcH4t1FAMcbIy0HTygQNrvifvYBZbGqSmkA3vArIRxsIeK t5vSlAFvV14sWi4krsw+sRLzsYtpe1LWji9AW6DpzheJDNl2eaE2oxFRhloPv/KE 9d2O3x/9g0ww/231drtc6RxL5kd7cFs15XKw1LnawurxOB79McuEFkt75OEOFpB6 7wlzQdhe9PI0uiluxhXfKqLF3EehBR4j2KAYQO5O8KpFLMObSUJrdwhvc6Fmlwtb t6vH20mDewuCJF6fliCKyLpM4ujnxuwmBz5sl6D50javzknqX2kzG5PX6jnj8ezR iSBoGZJMY/B+UKKMHgJNzgbP6g3X7LICAs7lBlfuiTdVau+YvUf+8JiNoCkF7NFO aXPuVt/rJ+4k5Q5ZFCq9Vt7dmy9gtJGM8ZJw4z30Nz0v16LSRFQHMfBaqco3HCib todvTsy1/bLwrA6k+ANvWWwJmqKHaLIFm7ZcEZNi5cMxNtAKKHbyPzN19syhFuVU gxlqVtTuB/yT+3Kd7G+1pH2Wr7NZNG1szJfQLVS4ns4PXBtbarINDCYW2fUpfvS6 bpzMjYzWe0ePGN58XRCVqrptx7q6IW3GLueJYq5zSHsRRmawwQx1xJBTA0qAqq7I GworiiALSOo3MMD4YZb+ =42bF -----END PGP SIGNATURE-----

1 0

Re: [PATCH 5/5] jscript: Added support for '-' CC expression.
by Marvin 01 Oct '14

01 Oct '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9163 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0