October 2014 - Wine-devel - list.winehq.org

Re: [PATCH 1/5] d3d9/tests: The device restores the mode settings from the registry.
by Marvin 24 Oct '14

24 Oct '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9731 Your paranoid android. === w8 (32 bit device) === device.c:4008: Test failed: Expected {0, 0, 800, 600}, got {0, 0, 652, 492}.

1 0

Re: [PATCH 4/5] dwrite: Pass raw NAME table pointer to table reading code
by Marvin 24 Oct '14

24 Oct '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9730 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] dwrite: Cache fontface instances at factory level
by Marvin 24 Oct '14

24 Oct '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9729 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/2] ws2_32: Properly implement SO_CONNECT_TIME (try 3)
by Marvin 24 Oct '14

24 Oct '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9727 Your paranoid android. === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:6676: Test failed: failed to create socket 10022 sock.c:6679: Test failed: failed to create completion port 87 sock.c:6684: Test failed: WSAIoctl failed 10038 sock.c:6687: Test failed: failed to get completion status 6

1 0

Re: [PATCH] wininet: remove custom port handling in HTTP_HandleRedirect (try 2)
by Alexandre Julliard 24 Oct '14

24 Oct '14

Daniel Lehman <dlehman(a)esri.com> writes: > HTTP_HandleRedirect updates both: > - the Host: field > - and session->hostname > > If there is a custom port, it is appended to session->hostName. This causes problems for later HttpOpenRequest/process_host_port calls that append the port to the host name (resulting in "foobar:1234:1234") > > There is already logic in HTTP_HandleRequest that will update the > request->server if the new host or port don't match. in that case, > get_server/process_host_port use the updated host and port and store > them appended in server->host_port. If they already match, > server->host_port is left untouched > > The attached change removes the current custom port logic to instead > use server->host_port to update the Host: field It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M wininet.dll -p wininet_test.exe.so http && touch http.ok http.c:693: Test failed: Wrong URL http://test.winehq.org:80/tests/hello.html http.c:693: Test failed: Wrong URL http://test.winehq.org:80/tests/hello.html make[1]: *** [http.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx10_43: Add stub for D3DXCpuOptimizations
by Henri Verbeet 24 Oct '14

24 Oct '14

On 24 October 2014 00:28, André Hentschel <nerv(a)dawncrow.de> wrote: > +typedef enum _D3DX_CPU_OPTIMIZATION > +{ > + D3DX_NOT_OPTIMIZED = 0, > + D3DX_3DNOW_OPTIMIZED = 1, > + D3DX_SSE2_OPTIMIZED = 2, > + D3DX_SSE_OPTIMIZED = 3 > +} D3DX_CPU_OPTIMIZATION; I think this should be in d3dx10math.h. > + FIXME("%i - stub\n", enable); I'd like to see that as "FIXME("enable %#x stub!\n", enable);" for consistency with other D3D code, but I don't think it's a big deal.

1 0

[PATCH] mshtml: check null before release the elem object
by Hao Peng 24 Oct '14

24 Oct '14

Check null pointer before release the script elem object, prevent to release them twice. --- dlls/mshtml/script.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)

1 0

Fw:[PATCH] mlang: add gbk to Chinese Simplified codepage
by Hao Peng 24 Oct '14

24 Oct '14

Add gbk to Chinese Simplified codepage data array in mlang, to make sure GBK encoded strings were decoded in codepage 936. --- dlls/mlang/mlang.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-)

1 0

Re: [PATCH] vbscript: Implemented String
by Nikolay Sivov 23 Oct '14

23 Oct '14

> + str = SysAllocStringLen(NULL, 1023); > + newstr = SysAllocStringLen(NULL, 1023); Where this length comes from? > + switch(V_VT(arg + 1)) { > + case VT_NULL: > + return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE); > + case VT_BSTR: > + str = V_BSTR(arg + 1); > + break; > + case VT_ARRAY|VT_BYREF|VT_VARIANT: > + return DISP_E_TYPEMISMATCH; > + default: > + hres = to_short(arg + 1, &tmp); > + if(FAILED(hres)) > + return hres; > + str[0] = (char)tmp; > + break; > + } You only need first character, right? Then why do you need a full BSTR pointer in VT_BSTR case? And assigning it to 'str' you leak a previously allocated buffer. Why cast to (char)tmp? > + else if(len == 0) > + newstr = '\0'; Same way you're losing pointer to allocated buffer.

2 4

Re: [PATCH 2/2] dwrite/tests: Some tests for local font file loader
by Marvin 23 Oct '14

23 Oct '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9714 Your paranoid android. === wvistau64 (32 bit font) === font.c:943: Test failed: got 0x88985006 font.c:945: Test failed: got 0x80070057 === w2008s64 (32 bit font) === font.c:943: Test failed: got 0x88985006 font.c:945: Test failed: got 0x80070057 === wvistau64 (64 bit font) === font.c:943: Test failed: got 0x88985006 font.c:945: Test failed: got 0x80070057 === w2008s64 (64 bit font) === font.c:943: Test failed: got 0x88985006 font.c:945: Test failed: got 0x80070057

1 0