November 2014 - Wine-devel - list.winehq.org

Re: [PATCH 5/5] d3d8/tests: Call TestCooperativeLevel after Present.
by Marvin 26 Nov '14

26 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10483 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2517: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2522: Test failed: The focus window is active. device.c:2530: Test failed: Got unexpected hr 0x88760869. device.c:2536: Test failed: Got unexpect screen size 800x600. device.c:2551: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2560: Test failed: Got unexpect screen size 800x600. device.c:2573: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2580: Test failed: Got unexpect width 640. device.c:2581: Test failed: Got unexpect height 480.

1 0

Wine web down?
by Bruno Jesus 26 Nov '14

26 Nov '14

It's been around 2 hours that I cannot access the web site, source, bugzilla or appdb. Only wiki stands on (AFAIR it's in a different server). Not even ping works. Is this a known maintenance operation? Bruno

2 1

Re: [PATCH 2/2] winealsa: implement GetPropValue and return device path (try 3)
by Andrew Eikum 26 Nov '14

26 Nov '14

These two patches look OK to me. Andrew On Wed, Nov 19, 2014 at 07:07:57PM +0000, Mark Harmstone wrote: > --- > dlls/winealsa.drv/mmdevdrv.c | 114 ++++++++++++++++++++++++++++++++++++ > dlls/winealsa.drv/winealsa.drv.spec | 1 + > 2 files changed, 115 insertions(+) > > > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index 5ad72f9..6b1456e 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -3823,3 +3823,117 @@ HRESULT WINAPI AUDDRV_GetAudioSessionManager(IMMDevice *device, > > return S_OK; > } > + > +enum AudioDeviceConnectionType { > + AudioDeviceConnectionType_Unknown = 0, > + AudioDeviceConnectionType_PCI, > + AudioDeviceConnectionType_USB > +}; > + > +HRESULT WINAPI AUDDRV_GetPropValue(GUID *guid, const PROPERTYKEY *prop, PROPVARIANT *out) > +{ > + static const PROPERTYKEY devicepath_key = { /* undocumented? - {b3f8fa53-0004-438e-9003-51a46e139bfc},2 */ > + {0xb3f8fa53, 0x0004, 0x438e, {0x90, 0x03, 0x51, 0xa4, 0x6e, 0x13, 0x9b, 0xfc}}, 2 > + }; > + > + TRACE("%s, (%s,%u), %p\n", wine_dbgstr_guid(guid), wine_dbgstr_guid(&prop->fmtid), prop->pid, out); > + > + if(IsEqualPropertyKey(*prop, devicepath_key)) > + { > + char name[256], uevent[MAX_PATH]; > + EDataFlow flow; > + FILE *fuevent; > + int card, device; > + > + if(!get_alsa_name_by_guid(guid, name, sizeof(name), &flow)) > + { > + WARN("Unknown interface %s\n", debugstr_guid(guid)); > + return E_NOINTERFACE; > + } > + > + /* only implemented for identifiable devices, i.e. not "default" */ > + if(!sscanf(name, "plughw:%u,%u", &card, &device)) > + return E_NOTIMPL; > + > + sprintf(uevent, "/sys/class/sound/card%u/device/uevent", card); > + fuevent = fopen(uevent, "r"); > + > + if(fuevent){ > + enum AudioDeviceConnectionType connection = AudioDeviceConnectionType_Unknown; > + USHORT vendor_id = 0, product_id = 0; > + char *line = NULL; > + > + while(!feof(fuevent)) { > + char *val; > + size_t val_len, len = 0; > + > + if(getline(&line, &len, fuevent)<0) > + break; > + > + if((val = strchr(line, '='))) { > + val[0] = 0; > + val++; > + > + val_len = strlen(val); > + if(val_len > 0 && val[val_len - 1] == '\n') { val[val_len - 1] = 0; } > + > + if(!strcmp(line, "PCI_ID")){ > + connection = AudioDeviceConnectionType_PCI; > + if(sscanf(val, "%hX:%hX", &vendor_id, &product_id)<2){ > + WARN("Unexpected input when reading PCI_ID in uevent file.\n"); > + connection = AudioDeviceConnectionType_Unknown; > + break; > + } > + }else if(!strcmp(line, "DEVTYPE") && !strcmp(val,"usb_interface")) > + connection = AudioDeviceConnectionType_USB; > + else if(!strcmp(line, "PRODUCT")) > + if(sscanf(val, "%hx/%hx/", &vendor_id, &product_id)<2){ > + WARN("Unexpected input when reading PRODUCT in uevent file.\n"); > + connection = AudioDeviceConnectionType_Unknown; > + break; > + } > + } > + } > + > + if(line) > + free(line); > + > + fclose(fuevent); > + > + if(connection == AudioDeviceConnectionType_USB || connection == AudioDeviceConnectionType_PCI){ > + static const WCHAR usbformatW[] = { '{','1','}','.','U','S','B','\\','V','I','D','_', > + '%','0','4','X','&','P','I','D','_','%','0','4','X','\\', > + '%','u','&','%','0','8','X',0 }; /* "{1}.USB\VID_%04X&PID_%04X\%u&%08X" */ > + static const WCHAR pciformatW[] = { '{','1','}','.','H','D','A','U','D','I','O','\\','F','U','N','C','_','0','1','&', > + 'V','E','N','_','%','0','4','X','&','D','E','V','_', > + '%','0','4','X','\\','%','u','&','%','0','8','X',0 }; /* "{1}.HDAUDIO\FUNC_01&VEN_%04X&DEV_%04X\%u&%08X" */ > + UINT serial_number; > + > + /* As hardly any audio devices have serial numbers, Windows instead > + appears to use a persistent random number. We emulate this here > + by instead using the last 8 hex digits of the GUID. */ > + serial_number = (guid->Data4[4] << 24) | (guid->Data4[5] << 16) | (guid->Data4[6] << 8) | guid->Data4[7]; > + > + out->vt = VT_LPWSTR; > + out->u.pwszVal = CoTaskMemAlloc(128 * sizeof(WCHAR)); > + > + if(!out->u.pwszVal) > + return E_OUTOFMEMORY; > + > + if(connection == AudioDeviceConnectionType_USB) > + sprintfW( out->u.pwszVal, usbformatW, vendor_id, product_id, device, serial_number); > + else if(connection == AudioDeviceConnectionType_PCI) > + sprintfW( out->u.pwszVal, pciformatW, vendor_id, product_id, device, serial_number); > + > + return S_OK; > + } > + }else{ > + WARN("Could not open %s for reading\n", uevent); > + return E_NOTIMPL; > + } > + } > + > + TRACE("Unimplemented property %s,%u\n", wine_dbgstr_guid(&prop->fmtid), prop->pid); > + > + return E_NOTIMPL; > +} > diff --git a/dlls/winealsa.drv/winealsa.drv.spec b/dlls/winealsa.drv/winealsa.drv.spec > index 04fa05a..bd83ea2 100644 > --- a/dlls/winealsa.drv/winealsa.drv.spec > +++ b/dlls/winealsa.drv/winealsa.drv.spec > @@ -8,3 +8,4 @@ > @ stdcall -private GetEndpointIDs(long ptr ptr ptr ptr) AUDDRV_GetEndpointIDs > @ stdcall -private GetAudioEndpoint(ptr ptr ptr) AUDDRV_GetAudioEndpoint > @ stdcall -private GetAudioSessionManager(ptr ptr) AUDDRV_GetAudioSessionManager > +@ stdcall -private GetPropValue(ptr ptr ptr) AUDDRV_GetPropValue > >

1 0

Re: [PATCH 4/5] d3d/tests: Table fog does not abs the fog coordinate.
by Marvin 26 Nov '14

26 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10452 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:8138: Test failed: Got unexpected color 0x000000ff, case 3. ddraw7.c:8138: Test failed: Got unexpected color 0x000000ff, case 4.

2 1

Re: [PATCH 5/5] d3d8/tests: Call TestCooperativeLevel after Present.
by Marvin 25 Nov '14

25 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10453 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2517: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2522: Test failed: The focus window is active. device.c:2530: Test failed: Got unexpected hr 0x88760869. device.c:2536: Test failed: Got unexpect screen size 800x600. device.c:2551: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2560: Test failed: Got unexpect screen size 800x600. device.c:2573: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2580: Test failed: Got unexpect width 640. device.c:2581: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 4/5] d3d/tests: Table fog does not abs the fog coordinate.
by Marvin 25 Nov '14

25 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10451 Your paranoid android. === w8 (32 bit visual) === visual.c:17111: Test failed: Got unexpected color 0x000000ff, case 3. visual.c:17111: Test failed: Got unexpected color 0x000000ff, case 4.

1 0

Re: [PATCH 4/5] d3d/tests: Table fog does not abs the fog coordinate.
by Marvin 25 Nov '14

25 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10450 Your paranoid android. === w8 (32 bit visual) === visual.c:5508: Test failed: Got unexpected color 0x000000ff, case 3. visual.c:5508: Test failed: Got unexpected color 0x000000ff, case 4.

1 0

Re: [PATCH 3/3] d3d8: Only one fullscreen swapchain is allowed (v2).
by Marvin 25 Nov '14

25 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10437 Your paranoid android. === w8 (32 bit device) === device.c:1217: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1262: Test failed: Reset failed, hr 0x88760868. device.c:1264: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1268: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1275: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1276: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1277: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1278: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1279: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1280: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1285: Test failed: Screen width is 640, expected 800. device.c:1286: Test failed: Screen height is 480, expected 600. device.c:1292: Test failed: Back buffer width is 640, expected 800. device.c:1294: Test failed: Back buffer height is 480, expected 600. device.c:1324: Test failed: Screen width is 640, expected 1024. device.c:1325: Test failed: Screen height is 480, expected 768. device.c:2512: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2517: Test failed: The focus window is active. device.c:2525: Test failed: Got unexpected hr 0x88760869. device.c:2531: Test failed: Got unexpect screen size 800x600. device.c:2546: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2555: Test failed: Got unexpect screen size 800x600. device.c:2568: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2575: Test failed: Got unexpect width 640. device.c:2576: Test failed: Got unexpect height 480.

1 0

Re: user32/tests: Ensure ShowWindow returns false when window is already hidden
by Marvin 24 Nov '14

24 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10433 Your paranoid android. === w7u (32 bit msg) === msg.c:12214: Test failed: unexpected hwnd 00080150 msg.c:12236: Test failed: bad time 30a5c/30a6b

1 0

first patches from a new developer
by Marc Bessières 24 Nov '14

24 Nov '14

Hello, I'm new to wine development. I've just sent my first 2 patches: http://source.winehq.org/patches/data/107855 http://source.winehq.org/patches/data/107856 The second patch passed successfully on testbot: https://testbot.winehq.org/JobDetails.pl?Key=10426 I read the wiki beforehand, so hopefully I didn't make too many mistakes. But please don't hesitate to give any comments so I can improve. Marc

1 0