February 2014 - Wine-devel - list.winehq.org

Re: [PATCH 2/2] mshtml: Use IWebBrowserPriv2IE9 instead of IWebBrowserPriv2IE8 in tests on IE9+.
by Marvin 14 Feb '14

14 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4905 Your paranoid android. === w8 (32 bit htmldoc) === htmldoc.c:2858: Test failed: unexpected command 74 htmldoc.c:2858: Test failed: unexpected command 74

1 0

Re: ws2_32: Fix some edge cases for getaddrinfo in BSD and OSX
by Dmitry Timoshkov 14 Feb '14

14 Feb '14

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > + /* servname tweaks required by OSX and BSD kernels */ > + if (!servname) > + serv = NULL; > + else if (!servname[0]) > + serv = "0"; > + else > + serv = servname; Shouldn't 'serv = "0"' be 'serv = ""' ? -- Dmitry.

2 1

Re: [PATCH 5/5] tests: Allow broken results to cause failures on the "windows" platform as well.
by Alexandre Julliard 14 Feb '14

14 Feb '14

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > include/wine/test.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/wine/test.h b/include/wine/test.h > index f8b608f..c81fe11 100644 > --- a/include/wine/test.h > +++ b/include/wine/test.h > @@ -208,6 +208,9 @@ const char *winetest_platform = "windows"; > /* report successful tests (BOOL) */ > static int report_success = 0; > > +/* fail on broken() */ > +static int fail_broken = 0; > + > /* passing arguments around */ > static int winetest_argc; > static char** winetest_argv; > @@ -289,7 +292,7 @@ void winetest_set_location( const char* file, int line ) > > int broken( int condition ) > { > - return (strcmp(winetest_platform, "windows") == 0) && condition; > + return !fail_broken && condition; > } > > /* > @@ -636,6 +639,8 @@ int main( int argc, char **argv ) > if (GetEnvironmentVariableA( "WINETEST_DEBUG", p, sizeof(p) )) winetest_debug = atoi(p); > if (GetEnvironmentVariableA( "WINETEST_INTERACTIVE", p, sizeof(p) )) winetest_interactive = atoi(p); > if (GetEnvironmentVariableA( "WINETEST_REPORT_SUCCESS", p, sizeof(p) )) report_success = atoi(p); > + if (GetEnvironmentVariableA( "WINETEST_FAIL_BROKEN", p, sizeof(p) )) fail_broken = atoi(p); > + else fail_broken = strcmp( winetest_platform, "windows" ); Couldn't you simply set the platform to "windows_broken" or something like that? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ws2_32: Fix some edge cases for getaddrinfo in BSD and OSX
by Marvin 14 Feb '14

14 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4901 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (b34): unexpectedly at the OOB mark: 0 === wvistau64 (32 bit sock) === sock.c:557: Test failed: oob_server (744): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 753E9799 === w2008s64 (32 bit sock) === sock.c:547: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock.c:557: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 757C9799 === wvistau64 (64 bit sock) === sock.c:557: Test failed: oob_server (b5c): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w7pro64 (64 bit sock) === sock.c:547: Test failed: oob_server (a54): unexpectedly at the OOB mark: 0 sock.c:557: Test failed: oob_server (a54): unexpectedly at the OOB mark: 0 sock.c:326: Test failed: do_synchronous_recv (a54): error 10054: sock.c:572: Test failed: oob_server (a54): not at the OOB mark: 1

1 0

Re: ntdll: add a stub for NtSetLdtEntries/ZwSetLdtEntries
by Dmitry Timoshkov 14 Feb '14

14 Feb '14

Austin English <austinenglish(a)gmail.com> wrote: > On Mon, Jan 27, 2014 at 3:48 PM, Austin English <austinenglish(a)gmail.com>wrote: > > > Fixes http://bugs.winehq.org/show_bug.cgi?id=26268 (tested with Kwik > > Support). > > > > -- > > -Austin > > > > Any comments on this patch? It's clearly wrong. -- Dmitry.

1 0

Re: dpnet: Use registry for lookup in IDirectPlay8Peer (try 2)
by Bruno Jesus 14 Feb '14

14 Feb '14

On Thu, Feb 13, 2014 at 1:23 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Corrected pointer arithmetic. > Corrected assign memory for RegGetValueW calls. > > Changelog: > dpnet: Use registry for lookup in IDirectPlay8Peer > > > Best Regards > Alistair Leslie-Hughes > > > Hi, here are my thoughts about this patch, as I told you before I'm really looking forward for your dpnet work =) I'm not used to review patches so if I do something wrong I ask for sorry in advance. + if(!pcReturned || !pcbEnumData) + return E_POINTER; This checks together with the error tests could be in a different patch as they are not related to the main subject of the patch. + while(nextKeyNameResult == ERROR_SUCCESS) + { + res = RegGetValueW(key, provider, friendly, RRF_RT_REG_SZ, NULL, NULL, &size); + if(res == ERROR_SUCCESS) + { + WCHAR *buf = HeapAlloc(GetProcessHeap(), 0, size); + if(buf) + { + res = RegGetValueW( key, provider, friendly, RRF_RT_REG_SZ, NULL, buf, &size); + if(res == ERROR_SUCCESS) + { + TRACE("%s=%s\n", debugstr_w(provider), debugstr_w(buf)); + + req_size += sizeof(DPN_SERVICE_PROVIDER_INFO) + (size * sizeof(WCHAR)); + + (*pcReturned)++; + } You are only reading the key value in the first loop to trace it, maybe you could simplify this loop with a single RegGetValueW call and no memory allocation just to get the size required and in the next loop where you really copy the data you could trace it. + char *infoend = ((char *)pSPInfoBuffer + (sizeof(DPN_SERVICE_PROVIDER_INFO) * (*pcReturned))); Since you are copying WCHAR data infoend should be a WCHAR pointer and it could be done like this AFAICS: WCHAR *infoend = (WCHAR *)(pSPInfoBuffer + *pcReturned); + while(nextKeyNameResult == ERROR_SUCCESS) + { + res = RegGetValueW(key, provider, friendly, RRF_RT_REG_SZ, NULL, NULL, &size); + + if(res == ERROR_SUCCESS) + { + WCHAR *buf = HeapAlloc(GetProcessHeap(), 0, size); + if(buf) + { + res = RegGetValueW(key, provider, friendly, RRF_RT_REG_SZ, NULL, buf, &size); + if(res == ERROR_SUCCESS) + { + pSPInfoBuffer[count].guid = CLSID_DP8SP_TCPIP; + pSPInfoBuffer[count].pwszName = (LPWSTR)(infoend + offset); + lstrcpyW(pSPInfoBuffer[count].pwszName, buf); + What if you read data directly over infoend buffer? This would eliminate the need for buf memory allocation and the strcpy. You would only have to set the pwszName. + offset += size-1; If you do a -1 here the next string will overwrite the NULL terminator from the previous string, won't it? If you decide to copy directly over the infoend buffer you could also get rid from the offset variable since you could do infoend += size instead. Best regards, Bruno

2 3

Re: [PATCH 1/5] d3d9/tests: Clean up yuv_color_test.
by Marvin 14 Feb '14

14 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4882 Your paranoid android. === w8 (32 bit visual) === visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 2/1, expected 0x00b30000, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 1/1, expected 0x000030e1, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 2/1, expected 0x000030e1, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel 2/1, expected 0x00ffd01c, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0xff00ff00: Got color 0x00000000 for pixel 1/1, expected 0x00b300e1, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0xff00ff00: Got color 0x00000000 for pixel 2/1, expected 0x00b300e1, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0xff0000ff: Got color 0x00000000 for pixel 1/1, expected 0x00ffd01c, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0xff0000ff: Got color 0x00000000 for pixel 2/1, expected 0x00b30000, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0x00ffff00: Got color 0x00000000 for pixel 1/1, expected 0x000030e1, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0x00ffff00: Got color 0x00000000 for pixel 2/1, expected 0x004bffff, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0x00ff00ff: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0x00ff00ff: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0x0000ffff: Got color 0x00000000 for pixel 1/1, expected 0x004bffff, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0x0000ffff: Got color 0x00000000 for pixel 2/1, expected 0x000030e1, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0xffffff00: Got color 0x00000000 for pixel 1/1, expected 0x00b300e1, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0xffffff00: Got color 0x00000000 for pixel 2/1, expected 0x00ff79ff, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0xffff00ff: Got color 0x00000000 for pixel 1/1, expected 0x00ffd01c, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0xffff00ff: Got color 0x00000000 for pixel 2/1, expected 0x00ffd01c, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0xffffffff: Got color 0x00000000 for pixel 1/1, expected 0x00ff79ff, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0xffffffff: Got color 0x00000000 for pixel 2/1, expected 0x00ff79ff, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0x4cff4c54: Got color 0x00000000 for pixel 1/1, expected 0x000b8b00, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0x4cff4c54: Got color 0x00000000 for pixel 2/1, expected 0x00b6ffa3, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0x00800080: Got color 0x00000000 for pixel 1/1, expected 0x0000ff00, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0x00800080: Got color 0x00000000 for pixel 2/1, expected 0x0000ff00, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0xff80ff80: Got color 0x00000000 for pixel 1/1, expected 0x00ff00ff, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0xff80ff80: Got color 0x00000000 for pixel 2/1, expected 0x00ff00ff, format D3DFMT_YUY2. visual.c:10474: Test failed: Failed to draw surface onto backbuffer, hr 0x8876086c. visual.c:10483: Test failed: Input 0x1c6b1cff: Got color 0x00000000 for pixel 1/1, expected 0x006dff45, format D3DFMT_YUY2. visual.c:10487: Test failed: Input 0x1c6b1cff: Got color 0x00000000 for pixel 2/1, expected 0x0000d500, format D3DFMT_YUY2.

2 1

Re: [PATCH 5/7] ddraw/tests: Test that DirectDraw4 doesn't modify the pixel format of the window it targets.
by Marvin 14 Feb '14

14 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4892 Your paranoid android. === w8 (32 bit ddraw4) === ddraw4.c:3462: Test failed: SetDisplayMode failed, hr 0x80004001.

2 1

Re: [PATCH 3/7] d3d8/tests: Test that Direct3D8 doesn't modify the pixel format of the window it targets.
by Marvin 14 Feb '14

14 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4890 Your paranoid android. === w8 (32 bit device) === device.c:2572: Test failed: Expected foreground window 00030196, got 0002004E. device.c:3268: Test failed: Expected wndproc 0x4100c0, got 0x4100c0.

2 1

Re: [PATCH 5/5] ddraw/tests: Port test_private_data to ddraw4.
by Marvin 14 Feb '14

14 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4886 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:3185: Test failed: SetDisplayMode failed, hr 0x80004001.

1 0