March 2014 - Wine-devel - list.winehq.org

Re: [PATCH 1/6] wininet: Fixed tests for the new winehq.org cert.
by Marvin 03 Mar '14

03 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5325 Your paranoid android. === w2000pro (32 bit http) === http.c:4477: Test failed: HttpSendRequest failed: 12037 http.c:4482: Test failed: expected secure flag to be set http.c:4536: Test failed: HttpSendRequest failed: 12037 http.c:4541: Test failed: expected secure flag to be set, got 0 === w8 (32 bit http) === http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:4308: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800000, expected 800000 http.c:4308: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800000, expected 800000 http.c:4311: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800080, expected 800080 http.c:4311: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800080, expected 800080 http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:957: Test failed: expected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 2 times, received 1 times http.c:958: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 2 times, received 1 times http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:4477: Test failed: HttpSendRequest failed: 12037 http.c:4482: Test failed: expected secure flag to be set http.c:4076: Test failed: dwKeySize = 0 http.c:4513: Test failed: expected a non-zero key size http.c:4536: Test failed: HttpSendRequest failed: 12037 http.c:4541: Test failed: expected secure flag to be set, got 0 http.c:4565: Test failed: expected a non-zero key size http.c:4597: Test failed: expected a non-zero key size http.c:4636: Test failed: expected ERROR_HTTP_HEADER_NOT_FOUND, got 0

1 0

Re: kernel32/time: Implement GetSystemTimes using /proc/stat.
by André Hentschel 03 Mar '14

03 Mar '14

Am 03.03.2014 14:44, schrieb Bernard Ladenthin: > Hi André, > > you wrote me a few suggestions for my patch at 29.09.2013 20:08. > > I wrote a new patch and tried it three times, the patch is always > "pending". Maybe you can examine the patch and write to me what is > wrong? Thank you for any help. > > http://source.winehq.org/patches/data/102340 > > From: Bernard Ladenthin <bernard.ladenthin(a)gmail.com> > Subject: kernel32/time: Implement GetSystemTimes using /proc/stat. > Message-Id: <52F9075B.4000601(a)gmail.com> > Date: Mon, 10 Feb 2014 18:07:39 +0100 mostly code style, spaces, variable names, variable types think about the use of ERR, FIXME, WARN, TRACE

1 0

Re: patch:add HANDLE
by Nikolay Sivov 03 Mar '14

03 Mar '14

On 3/3/2014 16:32, Akira Nakagawa wrote: > It was a little hurtful that you have said... > what did you mean of "dead code"? I mean that code that your patch adds is not used. > > I've checked Windows itself uses it as public handle. What does a public handle mean and what did you check exactly? > My patch is not enough,you say,to be send,then I send after finished > eventlog functions works. You shouldn't send everything as one patch either, it needs to be incremental but without dead parts. Please CC wine-devel(a)winehq.org if you want my reply. > 2014年3月3日月曜日、Nikolay Sivov<bunglehead(a)gmail.com > <mailto:bunglehead(a)gmail.com>> さんは書きました: > > On 3/2/2014 15:18, 中川祥 wrote: >> Hum? >> I thought all the HANDLEs are hosted by server. > I don't think you need event log handles to be handled by server, > I'd rather had a service handling them. >> Hence,I did. >> It need be hosted by server because you need to distinguish one >> eventlog from the ohter,any way. >> > I'm not sure I follow you here.Anyway, you'll need some plan for > all parts involved (advapi32, logging service, something else?) > before sending such dead code patches. > > Please keep wine-devel CC. >> 2014年3月2日日曜日、Nikolay Sivov<bunglehead(a)gmail.com >> <javascript:_e(%7B%7D,'cvml','bunglehead(a)gmail.com');>> さんは書 >> きました: >> >> On 3/2/2014 14:13, 中川祥 wrote: >>> Handle for eventlog. >>> It is different from event. >>> It's almost same as hfile,but more info needed. >>> Is it implemented? >> What event log API are you talking about? Why does this >> handle have to be maintained by a server? >>> >>> >>> 2014-03-02 16:19 GMT+09:00 Nikolay Sivov <bunglehead(a)gmail.com>: >>> >>> On 3/2/2014 10:44, Akira Nakagawa wrote: >>> >>> What's that about? >>> >>> >> >

1 0

About GSoC 2014
by Nemina Amarasinghe 03 Mar '14

03 Mar '14

Hi, I am willing to participate GSoC this year. I looked through the accepted organization list and I'm interested in wine. So I would like to know how to connect with mentors to get more details. I would really appreciate if someone help me to get above information Best regards, Nemina

2 1

Re: patch:add HANDLE
by Nikolay Sivov 02 Mar '14

02 Mar '14

On 3/2/2014 15:18, 中川祥 wrote: > Hum? > I thought all the HANDLEs are hosted by server. I don't think you need event log handles to be handled by server, I'd rather had a service handling them. > Hence,I did. > It need be hosted by server because you need to distinguish one > eventlog from the ohter,any way. > I'm not sure I follow you here.Anyway, you'll need some plan for all parts involved (advapi32, logging service, something else?) before sending such dead code patches. Please keep wine-devel CC. > 2014年3月2日日曜日、Nikolay Sivov<bunglehead(a)gmail.com > <mailto:bunglehead(a)gmail.com>> さんは書きました: > > On 3/2/2014 14:13, 中川祥 wrote: >> Handle for eventlog. >> It is different from event. >> It's almost same as hfile,but more info needed. >> Is it implemented? > What event log API are you talking about? Why does this handle > have to be maintained by a server? >> >> >> 2014-03-02 16:19 GMT+09:00 Nikolay Sivov <bunglehead(a)gmail.com >> <javascript:_e(%7B%7D,'cvml','bunglehead(a)gmail.com');>>: >> >> On 3/2/2014 10:44, Akira Nakagawa wrote: >> >> What's that about? >> >> >

1 0

Re: dpnet: Check if DirectDplay is installed
by Marvin 02 Mar '14

02 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5312 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: patch:add HANDLE
by Nikolay Sivov 02 Mar '14

02 Mar '14

On 3/2/2014 14:13, 中川祥 wrote: > Handle for eventlog. > It is different from event. > It's almost same as hfile,but more info needed. > Is it implemented? What event log API are you talking about? Why does this handle have to be maintained by a server? > > > 2014-03-02 16:19 GMT+09:00 Nikolay Sivov <bunglehead(a)gmail.com > <mailto:bunglehead(a)gmail.com>>: > > On 3/2/2014 10:44, Akira Nakagawa wrote: > > What's that about? > >

1 0

Re: patch:add HANDLE
by Nikolay Sivov 02 Mar '14

02 Mar '14

On 3/2/2014 10:44, Akira Nakagawa wrote: What's that about?

1 0

Re: [PATCH 3/3] gdiplus/tests: Added tests for GdipCreateStreamOnFile.
by Dmitry Timoshkov 01 Mar '14

01 Mar '14

Qian Hong <qhong(a)codeweavers.com> wrote: > +static void test_gdipstream(void) > +{ > + IStream *stream; > + WCHAR nonexistentW[] = {'n','o','n','e','x','i','s','t','.','b','m','p','\0'}; > + WCHAR nonshareW[] = {'n','o','n','s','h','a','r','e','.','b','m','p','\0'}; > + GpStatus stat; > + HANDLE hfile; > + > + hfile = CreateFileW(nonshareW, GENERIC_READ, 0, NULL, CREATE_NEW, FILE_FLAG_DELETE_ON_CLOSE, 0); > + ok(hfile != INVALID_HANDLE_VALUE, "failed to create file\n"); Same problem with temp files in current directory. > + stream = (IStream *)0xdeadcafe; > + stat = GdipCreateStreamOnFile(nonexistentW, GENERIC_READ, &stream); > + todo_wine ok(stat == NotImplemented, "returned %d, expected NotImplemented\n", stat); > + todo_wine ok(stream == (IStream *)0xdeadcafe, "returned %p\n", stream); > + > + stream = (IStream *)0xdeadcafe; > + stat = GdipCreateStreamOnFile(nonshareW, GENERIC_READ, &stream); > + todo_wine ok(stat == NotImplemented, "returned %d, expected NotImplemented\n", stat); > + todo_wine ok(stream == (IStream *)0xdeadcafe, "returned %p\n", stream); > + > + CloseHandle(hfile); > +} Please use common 0xdeadbeef instead of new inventions. -- Dmitry.

1 0

Re: [PATCH 1/3] gdiplus/tests: Added more tests for image loading functions.
by Dmitry Timoshkov 01 Mar '14

01 Mar '14

Qian Hong <qhong(a)codeweavers.com> wrote: > + WCHAR nonexistentW[] = {'n','o','n','e','x','i','s','t','.','b','m','p','\0'}; > + WCHAR nonshareW[] = {'n','o','n','s','h','a','r','e','.','b','m','p','\0'}; > + HANDLE hfile; > + > + hfile = CreateFileW(nonshareW, GENERIC_READ, 0, NULL, CREATE_NEW, FILE_FLAG_DELETE_ON_CLOSE, 0); > + ok(hfile != INVALID_HANDLE_VALUE, "failed to create file\n"); Please use official temporary storage instead of creating files in current directory. -- Dmitry.

1 0