March 2014 - Wine-devel - list.winehq.org

Re: [2/4] widl: Pass type attributes from write_array_tfs to write_pointer_description.
by Alexandre Julliard 20 Mar '14

20 Mar '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This allows to differentiate strings and write appropriate rpc type > (FC_C_C[W]STRING instead of FC_[W]CHAR). It also changes some pointers from UP to RP, that doesn't look right. -- Alexandre Julliard julliard(a)winehq.org

2 7

wintab32: fixing a typo which prevented sending correct pkSerialNumber
by Eriks Dobelis 20 Mar '14

20 Mar '14

This submission Obsoletes patch id#103302. I split it into parts for easier review and will later submit the rest of patches, but each of them will resolve a single issue and they are not interdependent. Common goal is to resolve http://bugs.winehq.org/show_bug.cgi?id=18517. This patch fixes a typo in a code, which was a cause for wrong pkSerialNumber values to be sent in messages. TRACE entries showed correct values, because TRACE statement was executed before actual sending of the packet. Due to this it took quite a time to spot the problem :) dlls/wintab32/context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

2 1

wintab: Incorrectly classifying cursor as stylus instead of eraser
by Eriks Dobelis 20 Mar '14

20 Mar '14

Did not attach the patch in my last email :( For Wacom Pen & Touch Intuos tablet eraser cursor is incorrectly detected as stylus. The tablet returns its eraser cursor name as: Wacom Intuos PT S Pen eraser and type as: ERASER Current code classifies this as STYLUS, because name of the cursor contains the word 'Pen'. It is very unlikely that a cursor with type ERASER is STYLUS. With the patch eraser is correctly detected. Without the patch eraser works as stylus. dlls/winex11.drv/wintab.c | 3 +++ 1 file changed, 3 insertions(+)

1 0

wintab: Incorrectly classifying cursor as stylus instead of eraser
by Eriks Dobelis 20 Mar '14

20 Mar '14

For Wacom Pen & Touch Intuos tablet eraser cursor is incorrectly detected as stylus. The tablet returns its eraser cursor name as: Wacom Intuos PT S Pen eraser and type as: ERASER Current code classifies this as STYLUS, because name of the cursor contains the word 'Pen'. It is very unlikely that a cursor with type ERASER is STYLUS. With the patch eraser is correctly detected. Without the patch eraser works as stylus. dlls/winex11.drv/wintab.c | 3 +++ 1 file changed, 3 insertions(+)

1 0

Re: [4/4] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Marvin 20 Mar '14

20 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5800 Your paranoid android. === build (build) === Make failed

2 1

Re: [PATCH]msvcr110: added missing functions in msvcr110.spec
by Piotr Caban 20 Mar '14

20 Mar '14

On 03/19/14 23:39, Natalino Cordeiro wrote: > +@ stub -arch=arm ?_NewTokenState(a)_CancellationTokenState@details(a)Concurrency@@SAPAV123(a)XZ > @ stub -arch=win32 ?_NewTokenState(a)_CancellationTokenState@details(a)Concurrency@@SAPAV123(a)XZ The ?_NewTokenState(a)_CancellationTokenState@details(a)Concurrency@@SAPAV123(a)XZ function is already exported on arm (there's other entry with the same name and -arch=win32 specifier). > -@ stub -arch=i386,win64 __crtCompareStringEx > +@ stub -arch=arm,i386,win64 __crtCompareStringEx It's not really important but in this case -arch option may be removed. Cheers, Piotr

1 0

Re: gdi32/tests: GetGlyphOutlineA is broken for johab charset on windows.
by Marvin 19 Mar '14

19 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5782 Your paranoid android. === w8 (32 bit font) === font.c:3609: Test failed: W: tmLastChar for Nirmala UI Semilight got a839 expected 262c font.c:3609: Test failed: W: tmLastChar for Nirmala UI got a839 expected 262c

1 0

Re: riched20/tests: Add tests for ITextDocument::Open about dealing with rtf.
by Alexandre Julliard 19 Mar '14

19 Mar '14

Jactry Zeng <jactry92(a)gmail.com> writes: > From 4b124d86198a9ed553a5f6cfd924584769495a1f Mon Sep 17 00:00:00 2001 > From: Jactry Zeng <jactry92(a)gmail.com> > Date: Sat, 15 Mar 2014 00:39:57 +0800 > Subject: riched20/tests: Add tests for ITextDocument::Open about dealing with > rtf. > > --- > dlls/riched20/tests/richole.c | 70 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M riched20.dll -p riched20_test.exe.so richole && touch richole.ok richole.c:445: Test failed: ITextDocument_Open: Should return an ERROR_HANDLE_EOF error. make[1]: *** [richole.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] user32: Improve SetFocus implementation
by Alexandre Julliard 19 Mar '14

19 Mar '14

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/user32/focus.c | 1 + > dlls/user32/tests/win.c | 4 ++++ > 2 files changed, 5 insertions(+) > > > > diff --git a/dlls/user32/focus.c b/dlls/user32/focus.c > index bd2e572..c47a82d 100644 > --- a/dlls/user32/focus.c > +++ b/dlls/user32/focus.c > @@ -277,6 +277,7 @@ HWND WINAPI SetFocus( HWND hwnd ) > HWND parent; > LONG style = GetWindowLongW( hwndTop, GWL_STYLE ); > if (style & (WS_MINIMIZE | WS_DISABLED)) return 0; > + if (!(style & WS_CHILD)) break; It doesn't look right to allow setting focus if a parent is disabled. This would need more tests. Also please write a better description of the change, "improve implementation" is not very helpful. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] user32: Improve SetFocus implementation
by Marvin 19 Mar '14

19 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5775 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005009E fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030160 fg 00060064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040264 fg 00010054 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040184 fg 0001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0006019E fg 00010048 in hook HCBT_ACTIVATE win.c:6410: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6432: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6410: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6432: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6410: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6432: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6193: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040184 fg 000000000001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

2 1