July 2014 - Wine-devel - list.winehq.org

Re: [website] German translation for release 1.7.22
by Rico Schüller 23 Jul '14

23 Jul '14

On 16.07.2014 00:24, Julian Rüger wrote: > + <p>Der Quelltext ist ab sofort <a href="http://prdownloads.sourceforge.net/wine/wine-1.7.22.tar.bz2">verfügbar</a>. > +15 Binärpakete werden gerade erstellt und stehen bald auf den jeweiligen <a href="{$root}/download">Downloadseiten</a> zur Verfügung. There is a 15 too much...

2 1

Re: [PATCH] riched20: Implement ITextSelection::GetChar.
by Huw Davies 23 Jul '14

23 Jul '14

On Tue, Jul 22, 2014 at 06:11:07PM +0800, Jactry Zeng wrote: > --- > dlls/riched20/richole.c | 13 +++++++++-- > dlls/riched20/tests/richole.c | 51 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 62 insertions(+), 2 deletions(-) > Before you start implementing the ITextSelection methods, have you thought about how the ITextRange returned by ITextDocument::GetStoryRanges would work? It seems to me it would be useful to have a text range object that could be used by both, rather than implementing two lots of ITextRange methods. Huw.

2 4

Re: winetest: Consistently use strict and warnings in the main CGI scripts.
by Alexandre Julliard 22 Jul '14

22 Jul '14

Francois Gouget <fgouget(a)codeweavers.com> writes: > diff --git a/winetest/winetest.cgi b/winetest/winetest.cgi > index 8c72e02..61dba49 100755 > --- a/winetest/winetest.cgi > +++ b/winetest/winetest.cgi > @@ -1,4 +1,4 @@ > -#!/usr/bin/perl > +#!/usr/bin/perl -w Any reason for adding this? I thought you wanted to remove them... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] msi/tests: Add non-existence value tests for mixed package. (try 2)
by Alexandre Julliard 22 Jul '14

22 Jul '14

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > This is part 1 of 2 of retrying `[7/8] msi/tests: Add more registry > tests.' (Patch 105588). > In this try, I divided the previous patch into two pieces because the > test was failed on Alexandre's 64-bit environment due to some uncertain > reason. With this series we can figure out failure points. If part 1 > (this patch) is failed, existing table is broken. Otherwise, additional > entries trigger failures. Of course now it's no longer failing, even with all the patches ;-) -- Alexandre Julliard julliard(a)winehq.org

2 1

imagehlp: Implement (parts of) BindImageEx
by Bernhard Reiter 22 Jul '14

22 Jul '14

Okay, on to the implementation. Grateful for any reviews!

1 0

Re: quartz: Destroy BaseFilter after child class.
by Austin English 21 Jul '14

21 Jul '14

On Mon, Jul 21, 2014 at 12:04 PM, Thomas Faber <thomas.faber(a)reactos.org> wrote: > For the AsyncReader, this is a use after free on the critical section > again. > > The NullRenderer doesn't have any pins, so that change is mostly > cosmetical to align it with the other classes. > > The Parser change fixes a memory leak in addition to the use after free, > because AVISplitter_Release manually decrements the refCount and calls > Parser_Destroy instead of using Parser_Release -- so the filter's > members were never released in this code path. > > > You forgot the patch. Cheers, -Austin

1 0

imagehlp/tests: Add test for BindImageEx
by Bernhard Reiter 21 Jul '14

21 Jul '14

Still struggling to get my first patch ready to be committed. I've removed all the typecasts I was able to, fixed variable names, and tried to initialize variables whereever required, as told by people on #winehackers. Having been told on that channel to only post to wine-patches@ after having the patch reviewed on this list, I'd be grateful for a (hopefully final) review. Bernhard

2 1

Re: [PATCH] vbscript: Implemented IsNumeric(try 2)
by Marvin 21 Jul '14

21 Jul '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8046 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText. (try 3)
by Huw Davies 21 Jul '14

21 Jul '14

On Thu, Jul 03, 2014 at 04:45:42PM +0800, Jactry Zeng wrote: > index 6f2d579..2553b50 100644 > --- a/dlls/riched20/richole.c > +++ b/dlls/riched20/richole.c > @@ -783,11 +783,31 @@ static HRESULT WINAPI ITextSelection_fnInvoke( > static HRESULT WINAPI ITextSelection_fnGetText(ITextSelection *me, BSTR *pbstr) > { > ITextSelectionImpl *This = impl_from_ITextSelection(me); > + ME_Cursor *start = NULL, *end = NULL; > + int nChars; > + > if (!This->reOle) > return CO_E_RELEASED; > + TRACE("%p\n", pbstr); > + if (!pbstr) > + return E_INVALIDARG; > > - FIXME("not implemented\n"); > - return E_NOTIMPL; > + ME_GetSelection(This->reOle->editor, &start, &end); > + nChars = ME_GetCursorOfs(end) - ME_GetCursorOfs(start); > + if (!nChars) > + { > + *pbstr = NULL; > + return S_OK; > + } > + > + *pbstr = SysAllocStringLen(NULL, nChars); > + if (!*pbstr) > + return E_OUTOFMEMORY; > + /* FIXME: a '\r' should be appended at the end of a story */ > + ME_GetTextW(This->reOle->editor, *pbstr, nChars, start, nChars, 0); Actually, perhaps you could fix the FIXME. GetTextW already has the ability to add \r\n, so extending this to add just \r shouldn't be too difficult. Also, in the tests, you leak the BSTRs. Huw.

2 17

Re: vbscript: Use VariantChangeType in to_int.
by Marvin 21 Jul '14

21 Jul '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8043 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0