October 2015 - Wine-devel - list.winehq.org

Re: [4/6] widl: Attributes of the alias are supposed to replace attributes of a tag in the typelib.
by Huw Davies 26 Oct '15

26 Oct '15

On Thu, Oct 15, 2015 at 08:47:04PM +0800, Dmitry Timoshkov wrote: > diff --git a/tools/widl/parser.y b/tools/widl/parser.y > index db5897e..1bd9565 100644 > --- a/tools/widl/parser.y > +++ b/tools/widl/parser.y > @@ -1893,6 +1893,10 @@ static type_t *reg_typedefs(decl_spec_t *decl_spec, declarator_list_t *decls, at > { > if (!type->name) > type->name = gen_name(); > + > + /* replace exisitng attributes when generating a typelib */ > + if (do_typelib) > + type->attrs = attrs; > } > > LIST_FOR_EACH_ENTRY( decl, decls, const declarator_t, entry ) I think this is actually correct (typedefs in typelibs are just strange). However, it would be more convincing if you could add version and helpcontext attributes to the typedefs and show that the base type gets those too. Something like: [uuid(016fe2ec-b2c8-45f8-b23b-39e53a753901),restricted] struct _n { int n1; }; [uuid(016fe2ec-b2c8-45f8-b23b-39e53a753902),hidden] typedef struct _n n; [uuid(016fe2ec-b2c8-45f8-b23b-39e53a753903),version(1), helpcontext(1)] typedef struct _n nn; struct _n gets both version and helpcontext from nn (which is interesting as you can't set version or helpcontext attributes on a structure). and also: [uuid(016fe2ec-b2c8-45f8-b23b-39e53a753904),restricted] struct _m { int m1; }; [uuid(016fe2ec-b2c8-45f8-b23b-39e53a753905),hidden, version(2)] typedef struct _m m; [uuid(016fe2ec-b2c8-45f8-b23b-39e53a753906),helpcontext(1)] typedef struct _m mm; To show that _m doesn't get a version. i.e. it doesn't get the union of attributes from m and mm, it just gets the attributes from the last typedef to reference it. Huw.

1 0

Re: [PATCH] d3dx9_36: Supplying a AnimationController isn't an error
by Stefan Dösinger 26 Oct '15

26 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-26 um 09:56 schrieb Alistair Leslie-Hughes: > + if (anim_controller) { > + *anim_controller = NULL; > + > + FIXME("Animation controller creation not implemented\n"); > + } Do you have an easy way to write this FIXME only if the file has an AnimationSet node? Or maybe even keep returning E_NOTIMPL if the output should be non-NULL? Also the style doesn't follow the general d3d style ('{' goes in its own line). > + ok(frame_hier->Name == NULL, "Expected NULL, got '%s'\n", frame_hier->Name); > + D3DXMatrixIdentity(&transform); > + check_matrix(&frame_hier->TransformationMatrix, &transform); It looks like these are the same tests as the ones right above the call. I'd skip them and only have controller-related test. A test input that should result in a non-NULL controller would be helpful as well. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWLfs5AAoJEN0/YqbEcdMwAM4P/1NSVVxBt3HGXPjqeF1Z6o93 6qV+C/MJB/82evJpf34zARYBXd6WzdeL+YbUl9K9G2iDZ/KLKf5l5opMnMD7cL1h 841dtZQu4IA3mJtwSY345+7YLcRV0qfYEHwFxvlO7JVqk9UIcsaE/kp+7tUvrFHD V5IIKSQrN6IhcGJDC51XIwcL2xxhgyco+5UOus6m6kKDBr+mpTxCVYpMOA4O/MjB fXoZl3S4SWkmJQwh8l9azycmRQ3y6xtQA8EksOWXxLv1lPhtdeb2LtP5w14vM4dC 3z3rC0NzDIAC+a5uNlhRbH8jb6SIlcdgInKaCaTSo9s8944eagaEh/ED2K4Q47Ub QaTz7JITa55ZnPuhgzms+Y3W8yW4QaEjgAo3L7/C91bVdBvwkBW0NBxIaMEgUU0M r+ZhjZPA2XsJ700k3SpB3BFHyFVT/qOtYLceNcE3d+8uJlmiqCu5xj6N4hojv1g2 gz8Map0/30mtA4b6IWD/kmnETYIZYYz28bzo8p56q25XFMGT1huArqW3JAlEe5Ic cKCUiNp3Visnzk9XJvmuW8wGVPk2Pta6UzdMCRiCF67Elb8Id8qqZc+GKsOm/FLV kSCvrXMaodeWqjnnyQIyI1QBo7Hoc4Q/V0iKiIVsPqvuY1wbmyTeVBdhqc+yKFw3 0llsQI07wd6TIWXgklAM =Xuvx -----END PGP SIGNATURE-----

1 0

Re: [PATCH 01/3] msvcp110: Add tr2_sys__Open_dir implementation.(try2)
by Piotr Caban 26 Oct '15

26 Oct '15

Hi, On 10/15/15 06:57, YongHao Hu wrote: > + char temppath[MAX_PATH]; > + TRACE("(%s %s %p %p)\n", debugstr_a(target), debugstr_a(dest), err_code, type); > + if(strlen(dest) > MAX_PATH) { > + *err_code = ERROR_BAD_PATHNAME; > + return NULL; > + } > + strcpy(temppath, dest); > + strcat(temppath, "\\*.*"); There's still possible buffer overflow if e.g. strlen(dest)==MAX_PATH-2. Thanks, Piotr

1 0

Re: [PATCH] oledb32: Support VT_NULL on all conversions (resend)
by Marvin 26 Oct '15

26 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17692 Your paranoid android. === wvistau64 (64 bit convert) === convert.c:2995: Test failed: got 24 === w2008s64 (64 bit convert) === convert.c:2995: Test failed: got 24 === w7pro64 (64 bit convert) === convert.c:2995: Test failed: got 24 === w864 (64 bit convert) === convert.c:2995: Test failed: got 24 === w1064 (64 bit convert) === convert.c:2995: Test failed: got 24

1 0

Re: d3dx10_43: Added D3DXCpuOptimizations stub sync
by Henri Verbeet 26 Oct '15

26 Oct '15

On 25 October 2015 at 12:31, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=39501 > Perhaps this is not any worse than what we have now, but presumably D3DXCpuOptimizations() is supposed to set global dll state like an ops table. I don't think forwarding will work very well once the implementation actually does something.

1 0

Re: [PATCH 7/7] kernel32/tests: Add tests for GetConsoleFontSize
by Marvin 26 Oct '15

26 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17688 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Re: [PATCH 2/7 v3] kernel32/tests: Add tests for the FALSE pathway of GetCurrentConsoleFont
by Marvin 26 Oct '15

26 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17687 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Wine Staging patch submission
by Hugh McMaster 26 Oct '15

26 Oct '15

On Friday, 23 Oct 2015 18:55:18 +0200, Sebastian Lackner wrote: >The development branch has more infrastructure for patch management than just >the wine-patches and wine-devel mailing list, you also have to take into account >the patch status page for example. Even the development branch of Wine, where >most of the patches go upstream right on the next day, needs a way to keep track >of the patch status. > >[...] > >I also think that the suggested solution does not hide anything from the rest of >the Wine developers. The WineHQ bugtracker is publicly available to everyone, >and flexible enough to configure all kind of notifications you want to receive. >I would guess most people are not really interested in Staging tree related >submissions, because even in the month after WineConf, I didn't receive any >offers from "new people" to help cleaning up our patches for example... but if >there is, it doesn't sound like something which is impossible to solve. > >I have no problem with alternative suggestions, but just saying "use the mailing >lists" doesn't work. Mailing lists do not replace proper patch tracking, which >is what we are really talking about here. To bring this discussion full circle, how will Staging pick up patches from wine-patches? And how will this be signified? Will the upstream patch tracker have a "Staged" status assigned by one of the maintainers?

1 0

Re: [PATCH 2/3] dxgi/tests: Add test for maximum frame latency.
by Marvin 26 Oct '15

26 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17680 Your paranoid android. === w1064 (32 bit device) === device.c:1147: Test failed: Got unexpected hr 0, test 16. device.c:1201: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1201: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1201: Test failed: Got usage 160, expected 60, test 35, buffer 1. device.c:1201: Test failed: Got usage 160, expected 60, test 36, buffer 2. device.c:1147: Test failed: Got unexpected hr 0, test 39. device.c:1201: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1201: Test failed: Got usage 160, expected 60, test 42, buffer 15.

1 0

Re: include: Add d3dx10.h file
by Stefan Dösinger 25 Oct '15

25 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-25 um 19:02 schrieb Andrey Gusev: > +enum _D3DX10_ERR { > + D3DX10_ERR_CANNOT_MODIFY_INDEX_BUFFER = MAKE_DDHRESULT(2900), > + D3DX10_ERR_INVALID_MESH = MAKE_DDHRESULT(2901), > + D3DX10_ERR_CANNOT_ATTR_SORT = MAKE_DDHRESULT(2902), > + D3DX10_ERR_SKINNING_NOT_SUPPORTED = MAKE_DDHRESULT(2903), > + D3DX10_ERR_TOO_MANY_INFLUENCES = MAKE_DDHRESULT(2904), > + D3DX10_ERR_INVALID_DATA = MAKE_DDHRESULT(2905), > + D3DX10_ERR_LOADED_MESH_AS_NO_DATA = MAKE_DDHRESULT(2906), > + D3DX10_ERR_DUPLICATE_NAMED_FRAGMENT = MAKE_DDHRESULT(2907), > + D3DX10_ERR_CANNOT_REMOVE_LAST_ITEM = MAKE_DDHRESULT(2908), > +}; Do you have code that uses this enum? This file doesn't exist in my Windows Kit installation, but it seems to be part of the old DirectX SDK headers. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWLUGTAAoJEN0/YqbEcdMwom8P/RVZQofM7SWgQxCXHBNtoIgJ MbsFqCxC5FE8GFkq/omgzCtqCnXFVdEkdfhP+NHmM3J03iOQZJB5yVpq7rmM+rUi 4/otHGsDlo+SCUIS0RmybXTNilQtbIHN7aweJ44j3jfjDxc81MFpLQyL652wltEj 91G4zQgYHl58XZ4XGMPMLxqo+bvl/YzICH/5TqrmLHWdxELypCUU36v4/50/fLua 55qfGflbYyHz/lulWh4qy1LJk0pxkOp+l2H2tqzAvfNjI02WzEK+BOjJOO780vWj +hs3aQPTZSxPIQZVm8nVONPwAFm7Yut4mDo4gSFfXU9PSiKFcFf++7IJdXsQOhzy HTRX+iIUY8bcIyENJ9+0VdRw9m5azeHeaVnn6cs/VJoxcFshnnANeV4MmF4PSzsA UiJpSoAn95+LQL07c2wShFSSQq4CjDczyfDjUq2zSia4DS4J3aFXzvT3lYSThVIr kBzJAbFdKNGzcGe+CkBTRY0QgurJgXA6o4lg5rjm3eiQHUjDi9rQEbfdclF7pd2h 0pgkXxqKycPVPy48VumZE0B6wqiuf60EhKd2iPSJsPiDlTcSxSAEgL2wPxRkYUj0 U/XKOTwAxbackYzSyh/zCKjb+XicKeMoFCwdBXRpTcz7yT+jx/j28pX8yUGwXUc3 LdqniHTL3wiq8r/Tp4hL =nZMZ -----END PGP SIGNATURE-----

1 0