November 2015 - Wine-devel - list.winehq.org

Re: tdi.sys: add a stub dll (try 2)
by Sebastian Lackner 16 Nov '15

16 Nov '15

On 17.11.2015 02:10, Austin English wrote: > @@ -2512,6 +2512,7 @@ HKLM,%CurrentVersion%\Telephony\Country List\998,"SameAreaRule",,"G" > 12,,fltmgr.sys,- > 12,,mountmgr.sys,- > 12,,ndis.sys,- > +12,,tdi.sys,- > ; skip .NET fake dlls in Wine Mono package > 11,,aspnet_regiis.exe,- > 11,,ngen.exe,- There are two sections where you have to add it, [FakeDllsWow64] and [FakeDlls].

1 0

Re: ws2_32: Add WSAPoll() implementation
by Austin English 16 Nov '15

16 Nov '15

On Mon, Nov 16, 2015 at 7:30 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > > Still some todos to fix but fixes https://bugs.winehq.org/show_bug.cgi?id=38600 > > Thanks to Sebastian for keeping it in the staging for long time. I think you meant https://bugs.winehq.org/show_bug.cgi?id=386001 ;)

2 1

Re: [PATCH 2/2] explorer: use winediag for some error messages
by Sebastian Lackner 16 Nov '15

16 Nov '15

On 16.11.2015 06:04, Austin English wrote: > case ERROR_MOD_NOT_FOUND: > - strcpy( error, "The graphics driver is missing. Check your build!" ); > + ERR_(winediag)( error, "The graphics driver is missing. Check your build!" ); > break; This can't work, you pass an uninitialized string to ERR(). Also, the current implementation just saves the error in the registry, and it is later loaded and printed by user32/driver.c. What you probably wanted to do is to replace both MESSAGE() calls with ERR_(winediag) in patch 1/2: --- snip --- - MESSAGE( "Application tried to create a window, but no driver could be loaded.\n"); + ERR_(winediag)( "Application tried to create a window, but no driver could be loaded.\n"); if (driver_load_error[0]) MESSAGE( "%s\n", driver_load_error ); <---------------------------- --- snip --- Regards, Sebastian

1 0

Re: gdi.exe: Reset devmode->dmDriverExtra to avoid invalid memory accesses.
by Alexandre Julliard 16 Nov '15

16 Nov '15

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > ChangeDisplaySettingsA/W already handle passed in DEVMODE this way. I'm not sure I see the relationship with ChangeDisplaySettingsA, not to mention that according to the test it doesn't do this on Win9x, which is probably relevant here. In any case, removing the const and writing to the app's buffer is very suspicious and would require a convincing test case, which of course is a bit tricky here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: loader/wine.inf.in: add HKEY_LOCAL_MACHINE\System\CurrentControlSet\Services\RpcSs subkeys
by Alexandre Julliard 16 Nov '15

16 Nov '15

Austin English <austinenglish(a)gmail.com> writes: > @@ -3249,6 +3249,14 @@ HKLM,%CurrentVersionNT%\SvcHost,"netsvcs",0x00010008,"Schedule" > HKLM,%CurrentVersion%\RunServices,"winemenubuilder",2,"%11%\winemenubuilder.exe -a -r" > HKLM,"System\CurrentControlSet\Services\Eventlog\Application",,16 > HKLM,"System\CurrentControlSet\Services\RpcSs",,16 > +HKLM,"System\CurrentControlSet\Services\RpcSs","Description",2,"Provides the endpoint mapper and other miscellaneous RPC services." > +HKLM,"System\CurrentControlSet\Services\RpcSs","DisplayName",2,"Remote Procedure Call (RPC)" > +HKLM,"System\CurrentControlSet\Services\RpcSs","ErrorControl",0x10003,1 > +HKLM,"System\CurrentControlSet\Services\RpcSs","ImagePath",0x20000,"%systemroot%\system32\svchost -k rpcss' > +HKLM,"System\CurrentControlSet\Services\RpcSs","ObjectName",2,"LocalSystem" > +HKLM,"System\CurrentControlSet\Services\RpcSs","PreshutdownTimeout",0x10003,0 > +HKLM,"System\CurrentControlSet\Services\RpcSs","Start",0x10003,2 > +HKLM,"System\CurrentControlSet\Services\RpcSs","Type",0x10003,20 This should be done by creating a proper service. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wine.inf: Add HKLM\Software\Microsoft\MediaPlayer\Installation DirectoryLFN key
by Alexandre Julliard 16 Nov '15

16 Nov '15

Andrey Gusev <andrey.goosev(a)gmail.com> writes: > @@ -635,6 +635,7 @@ HKLM,Software\Microsoft\DFS,,16 > HKLM,Software\Microsoft\Driver Signing,,16 > HKLM,Software\Microsoft\EnterpriseCertificates,,16 > HKLM,Software\Microsoft\EventSystem,,16 > +HKLM,Software\Microsoft\MediaPlayer,"Installation DirectoryLFN",2,"" You should set the value to the correct path. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: setupapi: Add a manifest to indicate the tests don't need elevation.
by Marvin 15 Nov '15

15 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18264 Your paranoid android. === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w1064 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found === w1064 (64 bit) === No test summary line found

1 0

Google Code-In / FOSSASIA
by André Hentschel 14 Nov '15

14 Nov '15

Hi, At the GSoC Mentor Summit last weekend I gathered some information on what's required for Code-In* and also talked with Mario Behling and Hong Phuc Dang from FOSSASIA. As we would need a lot of tasks and a lot of mentors to participate as our own organization/project it seems much easier to join FOSSASIA with a view tasks and a some mentors covering the most important time zones. And yes, they invited us to join them for Code-In. I think this is a great chance for dipping a toe in the water and gather experience for upcoming Code-Ins. This year it runs from December 7th to January (I think 7-8 weeks). If there are no objections I think we should take that chance. We then would need some Mentors in Asian time zones, too. For now it looks like Stefan D., Austin E. and I would volunteer. (One in USA, two in Europe) *Code-In ( https://developers.google.com/open-source/gci/ ) is a project similar to Summer of Code, but for pre-university students ages 13 to 17. They get tasks they can claim and can then submit them or abandon them. This can be done for multiple orgs, but if a student decides to accomplish a lot of tasks for one org, the org can nominate it as a grand price winner. A grand price winner then travels with parents and one mentor of that org to Google. Possible task categories are: Coding Documentation / Training Outreach / Research Quality Assurance User Interface (translation tasks are not allowed) To sign up as a FOSSASIA Mentor use this form: https://docs.google.com/forms/d/1kDEZNyGGEblrLgZ2QyZcfcBjG0I9zXbk6NamjsE1O9…

2 1

Re: [PATCH] wined3d: Turn magic values into static constants.
by Henri Verbeet 14 Nov '15

14 Nov '15

The patch isn't wrong, but I don't think the subject is an appropriate description of what it does.

3 2

Re: [PATCH] wined3d: Avoid double initialization.
by Henri Verbeet 13 Nov '15

13 Nov '15

On 13 November 2015 at 07:45, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > @@ -4962,7 +4960,7 @@ static GLuint generate_param_reorder_function(struct shader_glsl_priv *priv, > BOOL per_vertex_point_size, const struct wined3d_gl_info *gl_info) > { > struct wined3d_string_buffer *buffer = &priv->shader_buffer; > - GLuint ret = 0; > + GLuint ret; > DWORD ps_major = ps ? ps->reg_maps.shader_version.major : 0; > unsigned int i; > const char *semantic_name; This fails to apply.

2 1