November 2015 - Wine-devel - list.winehq.org

Re: [PATCH] crypt32/tests: Added a simple CA test for CertOpenStore.
by Alexandre Julliard 10 Nov '15

10 Nov '15

Qian Hong <qhong(a)codeweavers.com> writes: > Signed-off-by: Qian Hong <qhong(a)codeweavers.com> > --- > dlls/crypt32/tests/cert.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) It fails here: ../../../tools/runtest -q -P wine -T ../../.. -M crypt32.dll -p crypt32_test.exe.so cert && touch cert.ok cert.c:1758: Test succeeded inside todo block: CertEnumCertificatesInStore should have worked cert.c:1762: Test succeeded inside todo block: Expected CRYPT_E_SELF_SIGNED or CRYPT_E_NOT_FOUND, got 80092007 make[1]: *** [cert.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v2 PATCH 1/4] kernel32: GetLocaleInfoA() doesn't support LOCALE_SSHORTTIME
by Marvin 10 Nov '15

10 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18066 Your paranoid android. === w1064 (32 bit locale) === locale.c:2337: Test failed: LCMapStringEx should fail with bad locale name locale.c:2338: Test failed: unexpected error code -559038737 locale.c:2429: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4155: Test failed: IsValidLocaleName should have failed locale.c:4157: Test failed: IsValidLocaleName should have failed locale.c:4522: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4524: Test failed: For id 7, Expected IVC, got ''

2 1

Re: [v2 PATCH 3/4] kernel32: Added support for TIME_NOSECONDS, restructured EnumTimeFormats implementation
by Marvin 10 Nov '15

10 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18068 Your paranoid android. === w1064 (32 bit locale) === locale.c:2337: Test failed: LCMapStringEx should fail with bad locale name locale.c:2338: Test failed: unexpected error code -559038737 locale.c:2429: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4152: Test failed: IsValidLocaleName should have failed locale.c:4154: Test failed: IsValidLocaleName should have failed locale.c:4519: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4521: Test failed: For id 7, Expected IVC, got ''

1 0

Re: [v2 PATCH 2/4] kernel32: EnumTimeFormatsA() doesn't support TIME_NOSECONDS
by Marvin 10 Nov '15

10 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18067 Your paranoid android. === w1064 (32 bit locale) === locale.c:2337: Test failed: LCMapStringEx should fail with bad locale name locale.c:2338: Test failed: unexpected error code -559038737 locale.c:2429: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4154: Test failed: IsValidLocaleName should have failed locale.c:4156: Test failed: IsValidLocaleName should have failed locale.c:4521: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4523: Test failed: For id 7, Expected IVC, got ''

1 0

Re: [v2 PATCH 3/4] kernel32: Added support for TIME_NOSECONDS, restructured EnumTimeFormats implementation
by Dmitry Timoshkov 10 Nov '15

10 Nov '15

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > -BOOL WINAPI EnumTimeFormatsW(TIMEFMT_ENUMPROCW proc, LCID lcid, DWORD flags) > +BOOL WINAPI EnumTimeFormatsA(TIMEFMT_ENUMPROCA proc, LCID lcid, DWORD flags) > { > - WCHAR buf[256]; > + struct enumtimeformats_context ctxt; > > - if (!proc) > + /* EnumTimeFormatsA doesn't support flags, EnumTimeFormatsW does. */ > + if (flags & ~LOCALE_USE_CP_ACP) > { > - SetLastError(ERROR_INVALID_PARAMETER); > + SetLastError(ERROR_INVALID_FLAGS); This change doesn't seem to be confirmed by a test case. -- Dmitry.

2 2

test
by André Hentschel 10 Nov '15

10 Nov '15

please ignore, sorry for the noise

1 0

Re: [PATCH 3/4] kernel32: Added support for TIME_NOSECONDS, restructured EnumTimeFormats implementation
by Dmitry Timoshkov 10 Nov '15

10 Nov '15

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +BOOL WINAPI EnumTimeFormatsA(TIMEFMT_ENUMPROCA proc, LCID lcid, DWORD flags) > { > - WCHAR buf[256]; > + struct enumtimeformats_context ctxt; > > - if (!proc) > + /* EnumTimeFormatsA doesn't support flags, EnumTimeFormatsW does. */ > + if (flags & ~LOCALE_USE_CP_ACP) > { > - SetLastError(ERROR_INVALID_PARAMETER); > + SetLastError(ERROR_INVALID_FLAGS); Is there any particular reason that you need 3/4 in order to fix something you've added in 2/4? This looks like badly tested code. -- Dmitry.

1 0

Re: [PATCH 3/4] kernel32: Added support for TIME_NOSECONDS, restructured EnumTimeFormats implementation
by Marvin 10 Nov '15

10 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18065 Your paranoid android. === w1064 (32 bit locale) === locale.c:2337: Test failed: LCMapStringEx should fail with bad locale name locale.c:2338: Test failed: unexpected error code -559038737 locale.c:2429: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4152: Test failed: IsValidLocaleName should have failed locale.c:4154: Test failed: IsValidLocaleName should have failed locale.c:4519: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4521: Test failed: For id 7, Expected IVC, got ''

1 0

Re: [PATCH 1/4] kernel32: GetLocaleInfoA() doesn't support LOCALE_SSHORTTIME
by Marvin 10 Nov '15

10 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18064 Your paranoid android. === w1064 (32 bit locale) === locale.c:2337: Test failed: LCMapStringEx should fail with bad locale name locale.c:2338: Test failed: unexpected error code -559038737 locale.c:2429: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4155: Test failed: IsValidLocaleName should have failed locale.c:4157: Test failed: IsValidLocaleName should have failed locale.c:4522: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4524: Test failed: For id 7, Expected IVC, got ''

1 0

Re: [v7 07/10] ddraw7/tests: Test SetColorKey() on cubemap surfaces.
by Marvin 10 Nov '15

10 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18063 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2243: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw7.c:3084: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3086: Test failed: Got unexpected screen width 1024. ddraw7.c:3088: Test failed: Got unexpected screen height 768. ddraw7.c:3101: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3103: Test failed: Got unexpected screen width 1024. ddraw7.c:3105: Test failed: Got unexpected screen height 768. ddraw7.c:3109: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3111: Test failed: Got unexpected screen width 1024. ddraw7.c:3113: Test failed: Got unexpected screen height 768. ddraw7.c:3132: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3134: Test failed: Got unexpected screen width 1024. ddraw7.c:3136: Test failed: Got unexpected screen height 768. ddraw7.c:3140: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3142: Test failed: Got unexpected screen width 1024. ddraw7.c:3144: Test failed: Got unexpected screen height 768. ddraw7.c:3164: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3166: Test failed: Got unexpected screen width 1024. ddraw7.c:3168: Test failed: Got unexpected screen height 768. ddraw7.c:3173: Test failed: Got unexpected screen width 1024. ddraw7.c:3175: Test failed: Got unexpected screen height 768. ddraw7.c:3188: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3190: Test failed: Got unexpected screen width 1024. ddraw7.c:3192: Test failed: Got unexpected screen height 768. ddraw7.c:3196: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3198: Test failed: Got unexpected screen width 1024. ddraw7.c:3200: Test failed: Got unexpected screen height 768. ddraw7.c:3208: Test failed: Got unexpected screen width 1024. ddraw7.c:3210: Test failed: Got unexpected screen height 768. ddraw7.c:3222: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3224: Test failed: Got unexpected screen width 1024. ddraw7.c:3226: Test failed: Got unexpected screen height 768. ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4081: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4094: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4110: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4129: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:5937: Test failed: Failed to set display mode, hr 0x80004001. === w864 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000 === w1064 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000

1 0