February 2015 - Wine-devel - list.winehq.org

Re: [PATCH 3/3] dwrite/tests: Fix couple of leaks when creating test font instance
by Marvin 04 Feb '15

04 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11424 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: [1/1] wine3d3: dxgi 1.2 add missing functions and structs to the idl
by Stefan Dösinger 04 Feb '15

04 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, On 02/04/15 11:11, Martell Malone wrote: > In terms of the order only the winapifamily.h patch needs to be > applied first. The rest can be applied in any order as they are > all independent of each other > > Is that okay of do you want me to resend them all with numbers ?? I'd say wait until tomorrow. Give Henri a chance to comment on what he wants regarding the code style inconsistencies, and give Alexandre a chance to state his opinion on winapifamily.h. Adding another copy of the patches to the list doesn't make it easier to follow them. If you have no reply by tomorrow resend them in a proper order and numbering. (Note that I haven't checked your header patches for correctness yet. I'll do that after I've retested the Marco d3d window minimization bug. It was a bit difficult to figure out which patches need review and which are outdated.) Also, please be careful about reply vs reply to list / all. You have dropped wine-devel from CC, that makes it impossible for others to follow the discussion. I've taken the liberty to re-add the CC. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU0fcJAAoJEN0/YqbEcdMwbtsP/RE6rtCtTF7uR4VOVjPwTjMz gV8NLhpBHuyin0vGR19l2f3FPm5SmRs2kXx9IWHofiOP//9fgPq6UhEXbLTHNvr8 YPodrahaRgryH2EcCRqZyNIVsA2JfYtEoweYUFPavHuOF+bQRdXrVYhEAhWye78o jjY0v6j7xd2vhJZ0yy3bNWNqetOHbH7HxOcBUVn2m0vIvEimONLidbCce5nh+51G 7xPP1dLbhvrFTWn9105z+TE1ewKCH1sbWkiJCcS4s+BBawhYEd4JUout0zNPG2A5 kOjEOXn3Zbu9mCoZMhg8VsbpVnyXTziZizfQmRGYOl8W9KRzQj155w/MZw4OvUa7 szVXkrDLTaVC6Qiv0UdxvgdlQKEG7C7iXaMK3jyIYo/NdwWQ4tP+3sv0ABUgQym4 UB1Fh5n72EZQULmjayRssUaj9pIv8mp+qQaPN37XE92ltoGvZvJ508ByhWln5ISH 65SixDTcvwkodOhNwPJyu63xYl/XHTt8vmp165H/KbMjPnaLwh1gjKSKmDSthLcq wcoKEgA2Pinu0Nbu4moR8GalA5LJPn9DgGsIIQSLvswnfcEd2YtAElijZYGnDysz DR2m8yBwpIqKmwPc0CJCK902RkbhtEu2YlQI6LEpwsAqnjVp+E7S3Yug3LmzHx8N becMTAgSQ0QabsodzW5K =YbZR -----END PGP SIGNATURE-----

1 0

Re: [1/1] wine3d3: dxgi 1.2 add missing functions and structs to the idl
by Stefan Dösinger 04 Feb '15

04 Feb '15

Am 03.02.2015 um 20:02 schrieb Martell Malone <martellmalone(a)gmail.com>: > wined3d and not win3d3 in the commit message Actually, the proper thing would be "include". Your d3d11 patch should state "d3d11: ...", but you don't have to resend because of this. Overall your patch submissions are difficult to follow. It isn't really clear to me in which order they should be applied, and which patch supersedes which. Generally, when a patch supersedes a previous patch please state so in the header line, e.g. "Include: Add missing dxgi 1.2 functions and structs to the idl (try 2)" . When patches depend on each other, like the dxgi and winapifamily patches, submit them in a series and mark them [1/3], [2/3] and [3/3]. git-send-email takes care of that if you use it, and git-format-patch will also create appropriate headers.

1 0

Re: Add d3d11_CreateDeviceAndSwapChain
by Stefan Dösinger 04 Feb '15

04 Feb '15

Hi, Am 03.02.2015 um 18:38 schrieb Martell Malone <martellmalone(a)gmail.com>: > 3rd Revision of the patch with input from both > Stefan and Bruno > Thanks Guys Looks good to me. I noticed that the d3d11_main.c file does not follow the general d3d code style. Bleh. I think it's best to commit your patch, then I'll send a patch tomorrow that fixes the other function and the function headers while the file is still small. Henri Verbeet has the final word on changes to d3d code. I'll wait for a word from him.

1 0

Re: wine.inf: Add substitution for font MS Serif
by Dmitry Timoshkov 04 Feb '15

04 Feb '15

Stefan Leichter <Stefan.Leichter(a)camline.com> wrote: > --- a/loader/wine.inf.in > +++ b/loader/wine.inf.in > @@ -562,6 +562,7 @@ HKLM,%FontSubStr%,"Courier New Greek,161",,"Courier New,161" > HKLM,%FontSubStr%,"Courier New TUR,162",,"Courier New,162" > HKLM,%FontSubStr%,"Helv",,"MS Sans Serif" > HKLM,%FontSubStr%,"Helvetica",,"Arial" > +HKLM,%FontSubStr%,"MS Serif",,"Liberation Serif" > HKLM,%FontSubStr%,"MS Shell Dlg 2",,"Tahoma" > HKLM,%FontSubStr%,"Times",,"Times New Roman" > HKLM,%FontSubStr%,"Times New Roman Baltic,186",,"Times New Roman,186" Font substitutions are supposed to replicate what Windows have there and therefore list only fonts available under Windows. There is Wine\Fonts\Replacements for host to Wine font mappings. -- Dmitry.

1 0

Re: [PATCH 1/2] ntdll: Support 64-bit Mac OS.
by Alexandre Julliard 04 Feb '15

04 Feb '15

Charles Davis <cdavis5x(a)gmail.com> writes: > diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec > index 51de6e7..acd0271 100644 > --- a/dlls/ntdll/ntdll.spec > +++ b/dlls/ntdll/ntdll.spec > @@ -1429,6 +1429,7 @@ > > # signal handling > @ cdecl __wine_set_signal_handler(long ptr) > +@ cdecl -arch=x86_64 __wine_current_teb() That's not better than exporting NtCurrentTeb. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Add d3d11_CreateDeviceAndSwapChain
by Stefan Dösinger 03 Feb '15

03 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-02-02 um 20:24 schrieb Martell Malone: > + FIXME("stub: adapter %p, driver_type %s, swrast %p, flags > %#x, feature_levels %p, levels %#x, sdk_version %d, " You're still printing sdk_version as a signed value. Please use %u instead of %d. Otherwise this looks good to me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU0IM3AAoJEN0/YqbEcdMw5v8P/3A5kt9fIPCVCTgXfM0A6uKS 8cCXPITuKmeub7obw7EiEhsQH/4pw80bKOhmFKZvpK0knrKeU7wZvojbP18n39j1 vVqpqvtzbkfsBwLZ/Z0AeC/evVACfMmw1Al3BMBTDhxFb+uv+rVI9spG06XRPx8P e3pWlzoGniaZG8YP6TguA0gfrcMcGWEOWT59nstWW0HXlMFdsE1OoMM5Wd+XrpB+ AuEHGNFiHacgNxVfpnk6wQw5TK2uXW79ZbjX2wnrDiXkYvUZBts34Xo5cTdXNMXp DugbwLQtoC3Yu4rHxymjZTNbJLDY0bAOgBo4YwMCVnfLj7zbwvNABqtEIKtVs5Mx XsovTKzLD5sPmWnCxMtC5Qmz/aQebOYWF9bB3vYju876h69J5aJt4OjGU0HfLd4g 26uQEWgT+UbU0Lavofn3w9jcO4qEBl3NbmTs4egsw8n5Ry5f+N58BX1OdaOSdkmy a3Io6NgV48I/FjbxdlqpMz10I+06VlWiMdlmQSKxWTN1t5AxTm8/dTHLMC4+D7nn FOeWvOr3Wy4ocBWoOpT94etIBxut8IMfSHzEKsoll7kib3daYVDPv97pAbKdV3fT tZhzhWif+sqneVpk9QnCqhd9v9Kd29axqTBy7JiZ9t8TYxFTrXu50ZgC5oX/zKBV 4jVGoA2kY+Gtv9KR6SH0 =R0+9 -----END PGP SIGNATURE-----

2 3

Directx 11.2 idl's created
by Martell Malone 03 Feb '15

03 Feb '15

Hi guys, I create 2 patches that I posted to win-patches. [1/2] Directx 11.2 idl's dxgi1_3.idl and [2/2] Directx 11.2 idl's d3d11_2.idl I can update the commit msg to "wind3d: Added x idl" As Bruno explained to me this is the structure. Other than that however does anyone have any feedback ? Kind Regards Martell

1 2

Re: Add d3d11_CreateDeviceAndSwapChain
by Martell Malone 03 Feb '15

03 Feb '15

Hi guys, I updated the patch on wine-patches to reflect bruno's input on the commit message and I changed the %d to %u. Thanks guys Martell On Tue, Feb 3, 2015 at 5:28 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Hi, this is just a hint. You are not following the standards for the > patch subject. If you see http://wiki.winehq.org/SubmittingPatches > There is: > > If you are fixing a specific component or part, write the component's > name followed by a colon: > > [1/2] msvcrt: First change... > [2/2] msvcrt: Second change... > wined3d: Separate change... > > Take a look at the patches list and you will see what I'm saying: > http://source.winehq.org/patches/ > > Best regards, > Bruno > > On Tue, Feb 3, 2015 at 3:22 PM, Martell Malone <martellmalone(a)gmail.com> > wrote: > > D3D11CreateDevice also has "sdk_version %d" > > I used that as a reference. > > Does this mean that the other stub is wrong also ?? > > > > On Tue, Feb 3, 2015 at 8:13 AM, Stefan Dösinger < > stefandoesinger(a)gmail.com> > > wrote: > >> > >> -----BEGIN PGP SIGNED MESSAGE----- > >> Hash: SHA1 > >> > >> Am 2015-02-02 um 20:24 schrieb Martell Malone: > >> > + FIXME("stub: adapter %p, driver_type %s, swrast %p, flags > >> > %#x, feature_levels %p, levels %#x, sdk_version %d, " > >> You're still printing sdk_version as a signed value. Please use %u > >> instead of %d. > >> > >> Otherwise this looks good to me. > >> > >> -----BEGIN PGP SIGNATURE----- > >> Version: GnuPG v2 > >> > >> iQIcBAEBAgAGBQJU0IM3AAoJEN0/YqbEcdMw5v8P/3A5kt9fIPCVCTgXfM0A6uKS > >> 8cCXPITuKmeub7obw7EiEhsQH/4pw80bKOhmFKZvpK0knrKeU7wZvojbP18n39j1 > >> vVqpqvtzbkfsBwLZ/Z0AeC/evVACfMmw1Al3BMBTDhxFb+uv+rVI9spG06XRPx8P > >> e3pWlzoGniaZG8YP6TguA0gfrcMcGWEOWT59nstWW0HXlMFdsE1OoMM5Wd+XrpB+ > >> AuEHGNFiHacgNxVfpnk6wQw5TK2uXW79ZbjX2wnrDiXkYvUZBts34Xo5cTdXNMXp > >> DugbwLQtoC3Yu4rHxymjZTNbJLDY0bAOgBo4YwMCVnfLj7zbwvNABqtEIKtVs5Mx > >> XsovTKzLD5sPmWnCxMtC5Qmz/aQebOYWF9bB3vYju876h69J5aJt4OjGU0HfLd4g > >> 26uQEWgT+UbU0Lavofn3w9jcO4qEBl3NbmTs4egsw8n5Ry5f+N58BX1OdaOSdkmy > >> a3Io6NgV48I/FjbxdlqpMz10I+06VlWiMdlmQSKxWTN1t5AxTm8/dTHLMC4+D7nn > >> FOeWvOr3Wy4ocBWoOpT94etIBxut8IMfSHzEKsoll7kib3daYVDPv97pAbKdV3fT > >> tZhzhWif+sqneVpk9QnCqhd9v9Kd29axqTBy7JiZ9t8TYxFTrXu50ZgC5oX/zKBV > >> 4jVGoA2kY+Gtv9KR6SH0 > >> =R0+9 > >> -----END PGP SIGNATURE----- > > > > > > > > > > >

1 0

Any interest for SOE Landmark?
by Joni Larsen-Haikarainen 03 Feb '15

03 Feb '15

Hi Question to the Wine developer community will follow. But first some background info: I bought in to the EverQuest Next Landmark Alpha just cus I wanted to support it. Did not expect it to run at all under Wine until long after official launch. But to my surprise the game ran just fine when it was in Alpha. (Videos of me running it can be found on Youtube under the Channel "Let's Play on Linux") After the game went in to closed beta I could only run the game on Low graphical settings. And after an update to the game late summer of 2014 I can not get in to the world at all. (See bug: http://bugs.winehq.org/show_bug.cgi?id=37853 ) The scroll wheel on my mouse would not work at all in game, but that's something I learned to live with. (See bug: http://bugs.winehq.org/show_bug.cgi?id=35542 ) Now to the question! I realize that it must be very hard to try to solve a problem that occurs in a software one might not have. Landmark is still closed beta, so one needs to pay to get access. Now, I really love Landmark. So I wonder is there any Wine developer that has any interest in trying to solve the problems with running it in Wine, IF you had Free (as in beer) access to it? If someone actually have an interest in the game, but doesn't want to buy in to the closed beta. I would consider gifting you a Closed Beta access. I'm not rich, so can't do this for many people. But one or two that find the game interesting I could do. Regards. Joni

3 2