March 2015 - Wine-devel - list.winehq.org

Re: [PATCH 3/5] d3d9/tests: Relax the fog range test a bit.
by Marvin 12 Mar '15

12 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12106 Your paranoid android. === w8 (32 bit visual) === visual.c:926: Test failed: Expected clear value 0xefefefef, got 0x00000000, fmt=D3DFMT_P8.

1 0

Re: [PATCH 2/5] d3d9/tests: Extend the colorfill test.
by Marvin 12 Mar '15

12 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12105 Your paranoid android. === w8 (32 bit visual) === visual.c:926: Test failed: Expected clear value 0xefefefef, got 0x00000000, fmt=D3DFMT_P8.

1 0

Re: [PATCH 9/9] gdiplus: Add pixel format test for transparent non-animated gif (try3)
by Dmitry Timoshkov 12 Mar '15

12 Mar '15

Piotr Caban <piotr(a)codeweavers.com> wrote: > --- > dlls/gdiplus/tests/image.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) Please add the tests similar to the animated case which checks pixel data, also add the tests for the palette to see that it actually has a trasparent color. Otherwise it's hard to see what is going on, and my skills of reading binary gif data becomes rusty with time. -- Dmitry.

3 3

Re: [PATCH 7/7] gdiplus/tests: Add gif frames composition tests
by Dmitry Timoshkov 12 Mar '15

12 Mar '15

Piotr Caban <piotr(a)codeweavers.com> wrote: > --- > dlls/gdiplus/tests/image.c | 99 > +++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 97 insertions(+), 2 deletions(-) It would be interesting to test this on the WIC side first. -- Dmitry.

2 1

Re: [PATCH 6/7] gdiplus: Fix animated gif frames composition
by Dmitry Timoshkov 12 Mar '15

12 Mar '15

Piotr Caban <piotr(a)codeweavers.com> wrote: > + hr = IWICBitmapFrameDecode_QueryInterface(frame, &IID_IWICBitmapSource, (void**)&bmp_source); > + if(FAILED(hr)) > + return hr; > + hr = IWICBitmapSource_GetSize(bmp_source, width, height); > + IWICBitmapSource_Release(bmp_source); What's wrong with calling appropriate IWICBitmapFrameDecode method directly? -- Dmitry.

2 2

Re: [PATCH 5/7] gdiplus: Convert animated gif to PixelFormat32bppARGB on load
by Dmitry Timoshkov 12 Mar '15

12 Mar '15

Piotr Caban <piotr(a)codeweavers.com> wrote: > + status = decode_frame_wic(decoder, frame_count>1 ? TRUE : FALSE, > + 0, gif_metadata_reader, image); The format probably doesn't depend on a frame count but on a presence of transparent color. -- Dmitry.

2 1

Re: [PATCH 4/7] gdiplus: Don't store stream reference in GpImage, it's done by IWICBitmapDecoder
by Dmitry Timoshkov 12 Mar '15

12 Mar '15

Piotr Caban <piotr(a)codeweavers.com> wrote: > @@ -3808,12 +3816,6 @@ GpStatus WINGDIPAPI GdipImageSelectActiveFrame(GpImage *image, GDIPCONST GUID *d > if (image->current_frame == frame) > return Ok; > > - if (!image->stream) > - { > - TRACE("image doesn't have an associated stream\n"); > - return Ok; > - } It doesn't make much sence to add this piece of code in previous patch. -- Dmitry.

2 1

Re: [PATCH 6/7] gdiplus: Fix animated gif frames composition (try2)
by Vincent Povirk 12 Mar '15

12 Mar '15

I'm pretty sure you can just cast IWICBitmapFrameDecode to IWICBitmapSource, and you don't need to use QueryInterface.

2 1

Re: [PATCH 1/7] gdiplus: Don't create new instance of IWICBitmapDecoder to encode every frame of animation (try2)
by Vincent Povirk 12 Mar '15

12 Mar '15

@@ -4288,7 +4341,8 @@ static const struct image_codec codecs[NUM_CODECS] = { /* SigMask */ emf_sig_mask, }, NULL, - decode_image_olepicture_metafile + decode_image_olepicture_metafile, + select_frame_wic }, { { /* WMF */ @@ -4307,7 +4361,8 @@ static const struct image_codec codecs[NUM_CODECS] = { /* SigMask */ wmf_sig_mask, }, NULL, - decode_image_olepicture_metafile + decode_image_olepicture_metafile, + select_frame_wic }, You have a later patch changing these to NULL, I'm guessing you meant to do that in this one?

2 1

Re: ws2_32/tests: Add more select() tests related to OOB handling
by Marvin 12 Mar '15

12 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12094 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0