April 2015 - Wine-devel - list.winehq.org

Re: [PATCH 4/4] d3drm/tests: Add tests to compare vtables for frame{1-3}, object and visual
by Stefan Dösinger 01 Apr '15

01 Apr '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-04-01 um 18:15 schrieb Aaryaman Vasishta: > +struct vtable_test > +{ > + REFIID iid; > + BOOL equal; > + BOOL todo; > +}; You should be able to integrate this into the existing qi test table, similar to how the refcount_iid field works. If you need more than one TODO field (e.g. one for refcount_iid and one for vtable inheritance) use flags. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVHHR+AAoJEN0/YqbEcdMwNa4P/08HSs3DE722aHW2nyx0Zfs1 KPeEn3yqm32PUrBbFs8gptp5+KxKqpsd7mzN3OgHxx+ipRCbcSrVEFhMYuels/Sl YX8rYrpGam+kKOSBOV8mnwjR1Fc9K3KDi5vyODmi4hFWb+gWArtONOVTm8HQwk/P S339yQDjsRArCugbVywmAMEi8J4ImTvuG102vZIyHFysmPG9CQQ5ndE7naE+B58s MJ557ErCWtDdazOis3CtFFVe1jBvwcZyfKi+6LSTyhVxVOiP3Mc84k+5cdT7929u UzXlHkJlS7qxAjxHz0gF1gdvCS/jlUQV5pGNrwoLg4FQEY7I5jPqR8QkseccygYC bHH/JaNfFcaELF5OTkyJCCH0Xa7hAPSWk8/RRcutzboe2s6n3SRUXuM9lAE9tBZL lopYNRYqb7wuxMFzdsRD5MG9zyqOGdg1dx/t75WMcniD36g65CDHkTaIRDX1nrCE 4ZTBhmXoAQxz60nrMHbZDye9rxTd1+RPvs45X9BOFpolfUAJt6luX8+ib0v5myMf qL8QzYT+lsNiFtZMwGrSRb3Wj4nm+KWeH2E8WBx3oYrQZe1LWFH6ZlkyTRamEKDY ooC8tNxrhOqQOV5eD8+Y3DDN+jE6jI53vpC3RAUMUtHXYrYHLiwKKpgyCjXU/vBi Ym2oC3yNbzOon0NQZ9UR =E3pj -----END PGP SIGNATURE-----

1 0

Re: [PATCH] uxtheme: Load MUI file when theme loaded.
by Nikolay Sivov 01 Apr '15

01 Apr '15

On 04/02/2015 12:00 AM, Mark Harmstone wrote: > Version 4 uxthemes, as used in Vista and above, are split over two files - the > msstyles file, and a language-dependent MUI file storing the theme's name, the > fonts it uses, etc. In preparation for v4 support, this patch adds MUI loading > to uxtheme. > > --- > dlls/uxtheme/msstyles.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++- > dlls/uxtheme/msstyles.h | 1 + > 2 files changed, 98 insertions(+), 1 deletion(-) > Path resolution you've implemented looks very similar to what GetFileMUIPath() is supposed to return. It would be great to have it at least partially implemented instead of potentially duplicating it. It'd be perfectly fine if you implement only subset of flags that you'll actually need for uxtheme.

1 0

Re: comctl32/tests: Fix couple of metrics tests that fail on some systems (try2)
by Marvin 01 Apr '15

01 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12597 Your paranoid android. === w2008s64 (32 bit listview) === listview.c:5190: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5195: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w7u (32 bit listview) === listview.c:3933: Test failed: got right 112, bottom 19 listview.c:5190: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5195: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w2008s64 (64 bit listview) === listview.c:5190: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5195: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

1 0

Re: d3dx9_36: Add D3DXFrameFind stub.
by Nikolay Sivov 01 Apr '15

01 Apr '15

On 04/01/2015 08:59 PM, Andrey Gusev wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=38334 > > Thanks to Matteo Bruni for valuable help. > > +D3DXFRAME * WINAPI D3DXFrameFind(const D3DXFRAME *frame_root, const char *name) > +{ > + FIXME("frame_root %p, name %s stub.\n", frame_root, debugstr_a(name)); > + > + return NULL; > +} > + If it's just a matter of searching for a name in a tree, I think it's better to add actual implementation instead of a stub.

1 0

Re: [PATCH] undefined symbols compiling for macosx >10.8
by Ken Thomases 01 Apr '15

01 Apr '15

If you were having problems building Wine without this patch, then you have a system configuration problem. Or you're configuring Wine incorrectly. -Ken On Apr 1, 2015, at 11:52 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: > Sorry but I committed the patch make me compilation be possible. > > On 01 апр. 2015 г., at 18:34, Ken Thomases <ken(a)codeweavers.com> wrote: > >> Hi, >> >> This patch makes no sense. Wine builds just fine for OS X versions greater than 10.8. Indeed, as near as I know, it still builds just fine for 10.5 and up (the Mac driver requires 10.6 or later, but on 10.5 it just will be skipped; it won't break anything). >> >> On Apr 1, 2015, at 6:48 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: >> >>> Undefined symbols for architecture i386: >>> "_kCGDisplayShowDuplicateLowResolutionModes", referenced from: >>> -[WineApplicationController modeMatchingMode:forDisplay:] in cocoa_app.o >>> ld: symbol(s) not found for architecture i386 >> >> If you're getting this error, you're not building against a 10.8+ SDK properly. The compiler is seeing the headers for a 10.8+ SDK but the linker is seeing libraries and frameworks from some pre-10.8 SDK. >> >> >>> Instead of checking for NULL we should check #ifdef >> >> No. The things being tested are not macros in any version of the SDK. Your #ifdef checks will never pass. You have effectively done "#if 0". >> >> Finally, changes to separate DLLs (secur32 and winemac.drv, in this case) should be in separate patches unless they are inter-dependent. >> >> -Ken >> >

1 0

Re: [PATCH 3/4] d3drm/tests: Split tests seperately for IDirect3DRM{1-3} interfaces
by Stefan Dösinger 01 Apr '15

01 Apr '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-04-01 um 18:15 schrieb Aaryaman Vasishta: > +++ b/dlls/d3drm/tests/d3drm.c > @@ -1841,6 +1841,104 @@ static void test_d3drm_qi(void) > IDirect3DRM_Release(d3drm); > } > > +static void test_frame_qi(void) > +{ There's no need to add this to d3drm.c and d3drm3.c. The versions in d3drm1.c, d3drm2.c and d3drm3.c are enough. Ideally d3drm.c will go away at some point. > + hr = Direct3DRMCreate(&d3drm); > + ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", hr); > + > + test_qi("d3drm_qi", (IUnknown *)d3drm, &IID_IDirect3DRM, tests, sizeof(tests) / sizeof(*tests)); > + > + IDirect3DRM_Release(d3drm); This test is version independent because there is only one way to create the d3drm object. You can just keep it in d3drm.c for now, or move it to d3drm1.c in a separate patch if you want. > --- a/dlls/d3drm/tests/Makefile.in > +++ b/dlls/d3drm/tests/Makefile.in > @@ -2,4 +2,7 @@ TESTDLL = d3drm.dll > IMPORTS = d3drm dxguid ddraw user32 uuid > C_SRCS = \ > d3drm.c \ > + d3drm1.c \ > + d3drm2.c \ > + d3drm3.c \ > vector.c This doesn't match the Makefile.in file I have. You have a reordered IMPORTS line. This is why the testbot failed. Do you have other patches in your tree? > +* Copyright 2012 Andr� Hentschel This shows up wrong in my mail client. It may be a setup issue on my side. It shows up OK on http://source.winehq.org/patches/data/110484 when viewed with the browser, but if I download the patch with wget it is broken as well. Please make sure your text editor is configured to save the files as UTF8. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVHCwnAAoJEN0/YqbEcdMwqsMP/1pigFRsvxOMAYpIHbPoQzda rnKNX4egG04IFvrlObvEVNm6GUW02hgm7SB5+UcdCkXclbGbDjxW0R8M4RqoYOHs swdSxFIZX9s/wPqHJOv33oK8TDPKYUX2SwXyhyOEN7rh3LKJF4DeYGP0uW+wSMed bCXeJ9bx3X55cAGMJhP9jVdcq8ADTh8z0sYANHLBkD80OCac+KxFMmsGrxUD2e2H l6ATINj9BKlgAYGbFnoweNkiv4+O9y6zXBgOQu8Df6Jlr+mu86Jv0zi5S7MHEj4h tWwNyNyaDjTIUlfMdF3cCrKDhLhgYuuwQqij/iAdrEcGFEFn+QKeX0THCGwLeto8 nzwmEZFKYT2keJsMoHQ5tf0U6tT0xedsOjHHTHg/cg1BBj7ogtJ0YcEaxIYtF7uP 47tkjEL9iKXaN7bfdugH1D4buvufUzlZYIvehdbyNcWs3/HYHdiBAbER1ah3yAn9 TlpYdHpZstimuDkMMMLCExW/nlnGZlxz+orF9RNMm/SowtAe1aMVGGHMS5+6ZBfb 4z85+OWG8bR9D+e7+OeOYr/3Z62wiKLppRVQiJ4NgrGgv4ex2rIjqkiKBTEgSZm7 WTptfVrMCQ8zHEpos8iZHZOcoOLVFX4ylQaNNXmssGtwcLqH/P8o7KAk3o6RO+g0 qlkMVFMPEn7fE9h8WJfj =Jeuf -----END PGP SIGNATURE-----

3 3

Re: [PATCH 4/4] d3drm/tests: Add tests to compare vtables for frame{1-3}, object and visual
by Marvin 01 Apr '15

01 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12593 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] d3drm/tests: Split tests seperately for IDirect3DRM{1-3} interfaces
by Marvin 01 Apr '15

01 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12592 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] undefined symbols compiling for macosx >10.8
by Ken Thomases 01 Apr '15

01 Apr '15

Hi, This patch makes no sense. Wine builds just fine for OS X versions greater than 10.8. Indeed, as near as I know, it still builds just fine for 10.5 and up (the Mac driver requires 10.6 or later, but on 10.5 it just will be skipped; it won't break anything). On Apr 1, 2015, at 6:48 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: > Undefined symbols for architecture i386: > "_kCGDisplayShowDuplicateLowResolutionModes", referenced from: > -[WineApplicationController modeMatchingMode:forDisplay:] in cocoa_app.o > ld: symbol(s) not found for architecture i386 If you're getting this error, you're not building against a 10.8+ SDK properly. The compiler is seeing the headers for a 10.8+ SDK but the linker is seeing libraries and frameworks from some pre-10.8 SDK. > Instead of checking for NULL we should check #ifdef No. The things being tested are not macros in any version of the SDK. Your #ifdef checks will never pass. You have effectively done "#if 0". Finally, changes to separate DLLs (secur32 and winemac.drv, in this case) should be in separate patches unless they are inter-dependent. -Ken

1 0

Re: [PATCH] vbscript: Implemented Oct(try 4)
by Marvin 01 Apr '15

01 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12481 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

3 2