May 2015 - Wine-devel - list.winehq.org

Re: msvcr120: Add erf functions (try 2)
by Alexandre Julliard 20 May '15

20 May '15

Daniel Lehman <dlehman(a)esri.com> writes: > @@ -73,6 +73,32 @@ int CDECL MSVCRT__set_SSE2_enable(int flag) > return sse2_enabled; > } > > +#if _MSVCR_VER>=120 > +/********************************************************************* > + * erff (MSVCRT.@) > + */ > +float CDECL MSVCRT_erff( float num ) > +{ > + return erff(num); > +} > + > +/********************************************************************* > + * erf (MSVCRT.@) > + */ > +double CDECL MSVCRT_erf( double num ) > +{ > + return erf(num); > +} Please add configure checks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 7/7] riched20: Implement GetFont() for selection range
by Marvin 20 May '15

20 May '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13500 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 6/7] riched20: Implement GetLanguageID()
by Marvin 20 May '15

20 May '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13499 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/7] riched20: Implement GetSize()
by Marvin 20 May '15

20 May '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13498 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] wined3d: Check resource types separately in check_fbo_compat.
by Henri Verbeet 19 May '15

19 May '15

On 16 May 2015 at 15:29, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static void delete_fbo_attachment(const struct wined3d_gl_info *gl_info, > + enum wined3d_gl_resource_type d3d_type) > +{ > + switch (d3d_type) > + { > + case WINED3D_GL_RES_TYPE_TEX_1D: > + gl_info->fbo_ops.glFramebufferTexture1D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_1D, 0, 0); > + break; > + > + case WINED3D_GL_RES_TYPE_TEX_2D: > + case WINED3D_GL_RES_TYPE_TEX_RECT: > + gl_info->fbo_ops.glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, > + wined3d_gl_type_to_enum(d3d_type), 0, 0); > + break; > + > + case WINED3D_GL_RES_TYPE_TEX_3D: > + gl_info->fbo_ops.glFramebufferTexture3D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_3D, 0, 0, 0); > + break; > + > + case WINED3D_GL_RES_TYPE_TEX_CUBE: > + gl_info->fbo_ops.glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, > + GL_TEXTURE_CUBE_MAP_POSITIVE_X_ARB, 0, 0); > + break; > + > + case WINED3D_GL_RES_TYPE_BUFFER: > + case WINED3D_GL_RES_TYPE_COUNT: > + break; > + } > +} > + This is kind of pointless. Any of the FramebufferTexture*() calls with a 0 texture will detach the current attachment. You shouldn't need to detach the current attachment before attaching a new one either, but I suppose the existing code already does that.

2 1

Re: [PATCH 3/5] riched20: Implement GetSize() (resend)
by Marvin 19 May '15

19 May '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13468 Your paranoid android. === w7u (32 bit richole) === richole.c:1287: Test failed: got weight 400

1 0

Re: [PATCH 2/5] riched20: Implement GetWeight() (resend)
by Marvin 19 May '15

19 May '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13467 Your paranoid android. === w7u (32 bit richole) === richole.c:1283: Test failed: after 400

1 0

Re: [PATCH 1/5] riched20: Implement GetBold()/GetItalic()
by Marvin 19 May '15

19 May '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13451 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: kernel32/tests: Add tests for delete behaviour of CopyFileEx.
by Marvin 19 May '15

19 May '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13465 Your paranoid android. === wvistau64 (32 bit file) === file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: dmusic: Remove "keep in sync with oneself" comments
by Michael Stefaniuc 18 May '15

18 May '15

Hello Frederic, why would you want to do this? Keeping the files identical just allows to copy it as is. Or easily verify it by just checking the SHA1 sum. On 05/18/2015 02:47 AM, Frédéric Delanoy wrote: > --- > dlls/dmusic/dmobject.c | 1 - > dlls/dmusic/dmobject.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/dlls/dmusic/dmobject.c b/dlls/dmusic/dmobject.c > index cabb6f7..8e9f58e 100644 > --- a/dlls/dmusic/dmobject.c > +++ b/dlls/dmusic/dmobject.c > @@ -1,6 +1,5 @@ > /* > * Base IDirectMusicObject Implementation > - * Keep in sync with the master in dlls/dmusic/dmobject.c > * > * Copyright (C) 2003-2004 Rok Mandeljc > * Copyright (C) 2014 Michael Stefaniuc > diff --git a/dlls/dmusic/dmobject.h b/dlls/dmusic/dmobject.h > index ad6bf6d..ffc683c 100644 > --- a/dlls/dmusic/dmobject.h > +++ b/dlls/dmusic/dmobject.h > @@ -1,6 +1,5 @@ > /* > * Base IDirectMusicObject Implementation > - * Keep in sync with the master in dlls/dmusic/dmobject.h > * > * Copyright (C) 2014 Michael Stefaniuc > * > bye michael

1 0