August 2015 - Wine-devel - list.winehq.org

Re: d3dcompiler_43: Define BWRITER_SM1_VS and BWRITER_SM1_PS as unsigned constants.
by Józef Kucia 10 Aug '15

10 Aug '15

Hi Gerald, On Sun, Aug 9, 2015 at 1:47 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > -#define BWRITER_SM1_VS 0xfffe > -#define BWRITER_SM1_PS 0xffff > +#define BWRITER_SM1_VS 0xFFFEu > +#define BWRITER_SM1_PS 0xFFFFu > > Lowercase hex literals are preferred in D3D code.

2 1

Re: [PATCH 2/7] d3d11/tests: Port test_create_texture2d() from d3d10core.
by Henri Verbeet 10 Aug '15

10 Aug '15

On 10 August 2015 at 01:11, Józef Kucia <jkucia(a)codeweavers.com> wrote: > --- > configure | 3 +- > configure.ac | 3 +- It's not a problem to include these, but it's not necessary either. Alexandre will generate these with tools/make_makefiles before committing the patch. > + if (!(device = create_device())) > + { > + skip("Failed to create device, skipping tests.\n"); > + return; > + } > + There's nothing necessarily wrong with these tests, but you may want to consider waiting with submitting them until after they pass. Right now you're depending on create_device() to fail so the tests are skipped, but that means that once D3D11CreateDevice() is implemented you'd need to add todo_wine's and error handling to every test.

2 2

Re: [PATCH 9/9] msvcp110: Add tr2_sys__Statvfs_wchar implementation and test.
by Marvin 10 Aug '15

10 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15925 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: m[PATCH 8/9] svcp110: Add tr2_sys__Rename_wchar implementation and test.
by Marvin 10 Aug '15

10 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15924 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 7/9] msvcp110: Add tr2_sys__Copy_file_wchar implementation and test.
by Marvin 10 Aug '15

10 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15923 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 7/7] d3d11/tests: Add test for device feature level.
by Józef Kucia 10 Aug '15

10 Aug '15

Please ignore this patchset. I've sent it before subscribing to wine-patches and hoped that it won't reach the mailing list. It should be superseded by the version which reached the mailing list earlier. I'm sorry for the inconvenience. -- Józef Kucia

1 0

Re: msxml3: Handle NULL parameter in IXMLDOMElement::get_ownerDocument(). (try 4)
by Nikolay Sivov 09 Aug '15

09 Aug '15

This looks okay to me (assuming it passes testbot of course).

1 0

Re: comctl32/tests: Add ARM and ARM64 arch strings
by Marvin 09 Aug '15

09 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15887 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] mshtml: Add IHTMLSelectElement::name property implementation.
by Jacek Caban 07 Aug '15

07 Aug '15

On 08/07/15 12:12, Zhenbo Li wrote: > - if(NS_SUCCEEDED(nsres)) { > - static const WCHAR wszGarbage[] = {'g','a','r','b','a','g','e',0}; > > - nsAString_GetData(&name_str, &name); > + nsAString_GetData(&name_str, &name); > + if(*name) > + *p = SysAllocString(name); > + else > + *p = NULL; > + nsAString_Finish(&name_str); > > - /* > - * Native never returns empty string here. If an element has no name, > - * name of previous element or ramdom data is returned. > - */ > - *p = SysAllocString(*name ? name : wszGarbage); > - }else { > + if(NS_FAILED(nsres)) { > ERR("GetName failed: %08x\n", nsres); > + return E_FAIL; > } > - > - nsAString_Finish(&name_str); > - > - TRACE("name=%s\n", debugstr_w(*p)); > return S_OK; Why don't you use return_nsstr? Jacek

1 0

Assorted spelling fixes.
by Hugh McMaster 07 Aug '15

07 Aug '15

Hi Francois, Just some suggestions to improve your patch. Feel free to use the suggestions (or not). On Friday, 7 August 2015 11:56:27 +0200 (CEST), Francois Gouget wrote: >- /* for keyframes allow to consume all unused bytes */ >+ /* for keyframes allow consuming all the unused bytes */ What about "allow keyframes to consume all unused bytes"? >- /* must we check for framesize to gain requested >- * datarate or could we trust codec? */ >+ /* must we check for frame size to gain requested >+ * data rate or could we trust the codec? */ "must we check for frame size to gain the requested data rate or can we trust the codec?" >+ * This would allow framing items (iterator_frameditems), >+ * and finding the nearest item (LVFI_NEARESTXY) a lot more efficiently. "This would allow us to frame items (iterator_frameditems) and find the nearest item (LVFI_NEARESTXY) far more efficiently." >- /* to make tests pass we follow Windows behaviour and allow to read these fields only >+ /* to make tests pass we follow Windows behaviour and allow reading these fields only "...we follow Windows' behaviour..." (apostrophe) >- * Since, we're also allow to load ELF (pure) libraries and Wine ELF libraries >+ * Since, we also allow loading ELF (pure) libraries and Wine ELF libraries "Since we also allow..." (no comma) >- /* XP doesn't allow to create bitmaps larger than 128 Mb */ >+ /* XP doesn't allow creating bitmaps larger than 128 MB */ "XP doesn't allow the creation of bitmaps larger than 128 MB" >- FIXME("Mode doesn't allow to wrap. However, we should allow to overwrite current string\n"); >+ FIXME("Mode doesn't allow wrapping. However, we should allow overwriting the current string\n"); "... However, we should allow the current string to be overwritten\n" >- /* win7 doesn't allow to create a thread during process shutdown, >+ /* win7 doesn't allow creating a thread during process shutdown but "win7 doesn't allow threads to be created during process shutdown, but..." >- /* win7 doesn't allow to create a thread during process shutdown, >- * earlier Windows versions allow it, and DLL_THREAD_DETACH is >+ /* win7 doesn't allow creating a thread during process shutdown but >+ * earlier Windows versions allow it. In that case DLL_THREAD_DETACH is Same here. >- * Native localui does not allow to delete a COM / LPT - Port (ERROR_NOT_SUPPORTED) >+ * Native localui does not allow deleting a COM / LPT - Port (ERROR_NOT_SUPPORTED) "...does not allow COM/LPT-Ports to be deleted..."

1 0