August 2015 - Wine-devel - list.winehq.org

Re: [2/4] comdlg32: Implement open dropdown menu.
by Alexandre Julliard 27 Aug '15

27 Aug '15

Vincent Povirk <madewokherd(a)gmail.com> writes: > This implements the open dropdown button as a separate button, rather > than using BS_SPLITBUTTON, which is unimplemented in Wine. This adds > some complexity, but I don't think it changes things enough to get in > the way of other work on this component. > > I have an implementation using BS_SPLITBUTTON that works on Windows, > and could theoretically be used once we have support for window class > redirection and BS_SPLITBUTTON. I will send that to wine-devel so you > can see how much complexity this approach adds, and what the correct > approach will look like. It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M comdlg32.dll -p comdlg32_test.exe.so itemdlg && touch itemdlg.ok itemdlg.c:2088: Test succeeded inside todo block: got 0x00000000. itemdlg.c:2089: Test succeeded inside todo block: got 0. Makefile:270: recipe for target 'itemdlg.ok' failed make: *** [itemdlg.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] dxgi/tests: Add a Test presentation parameter combinations.
by Marvin 26 Aug '15

26 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16348 Your paranoid android. === wvistau64 (32 bit device) === device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 12. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 13. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 19. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 24. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 25. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 27. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 28. device.c:1173: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 29. device.c:1173: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 35. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 36. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 40. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 41. device.c:1173: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 42. === w2008s64 (32 bit device) === device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 12. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 13. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 19. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 35. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 36. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 42. === w7u (32 bit device) === device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 24. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 25. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 27. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 28. device.c:1173: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 29. device.c:1173: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 35. device.c:1173: Test failed: Got usage 160, expected 60, test 35, buffer 1. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 36. device.c:1173: Test failed: Got usage 160, expected 60, test 36, buffer 2. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 40. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 41. device.c:1173: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 42. device.c:1173: Test failed: Got usage 160, expected 60, test 42, buffer 15. === w8 (32 bit device) === device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 24. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 25. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 27. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 28. device.c:1173: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 29. device.c:1173: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 35. device.c:1173: Test failed: Got usage 160, expected 60, test 35, buffer 1. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 36. device.c:1173: Test failed: Got usage 160, expected 60, test 36, buffer 2. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 40. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 41. device.c:1173: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 42. device.c:1173: Test failed: Got usage 160, expected 60, test 42, buffer 15. === wvistau64 (64 bit device) === device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 12. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 13. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 19. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 35. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 36. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 42. === w2008s64 (64 bit device) === device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 12. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 13. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 19. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 35. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 36. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 42.

1 0

Re: [PATCH 4/5] d3d8/tests: Test presentation parameter combinations.
by Marvin 26 Aug '15

26 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16347 Your paranoid android. === w8 (32 bit device) === device.c:1216: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1261: Test failed: Reset failed, hr 0x88760868. device.c:1263: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1267: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1274: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1275: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1276: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1277: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1278: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1279: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1284: Test failed: Screen width is 640, expected 800. device.c:1285: Test failed: Screen height is 480, expected 600. device.c:1291: Test failed: Back buffer width is 640, expected 800. device.c:1293: Test failed: Back buffer height is 480, expected 600. device.c:1323: Test failed: Screen width is 640, expected 1024. device.c:1324: Test failed: Screen height is 480, expected 768. device.c:2571: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2576: Test failed: The focus window is active. device.c:2584: Test failed: Got unexpected hr 0x88760869. device.c:2590: Test failed: Got unexpect screen size 800x600. device.c:2605: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2614: Test failed: Got unexpect screen size 800x600. device.c:2627: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2635: Test failed: Got unexpect width 640. device.c:2636: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 5/5] dxgi/tests: Add a Test presentation parameter combinations.
by Henri Verbeet 26 Aug '15

26 Aug '15

On 26 August 2015 at 21:50, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + wc.lpfnWndProc = DefWindowProcA; > + wc.lpszClassName = "dxgi_test_wc"; > + RegisterClassA(&wc); Do we really need that?

1 0

Winelib and C++ static initialization
by Luke Dunstan 26 Aug '15

26 Aug '15

Hi, I am new to Winelib and I have crashes with very basic C++ code. Consider the following code: #include <windows.h> struct MyInit { MyInit() { OutputDebugStringA("Init ctor\n"); } }; MyInit InitObj; extern "C" int CALLBACK WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow) { OutputDebugStringA("WinMain()\n"); return 0; } If I compile it on Ubuntu 32-bit with wine-1.6.2 with: wineg++ -c -mno-cygwin -o hello.o hello.cpp wineg++ -mwindows -mno-cygwin -o hellocpp.exe hello.o The result is: $ ./hellocpp.exe Segmentation fault (core dumped) On Windows this program obviously outputs "Init ctor\n" followed by "WinMain()\n", as viewed in DbgView. Removing the call to OutputDebugStringA from the static constructor prevents the crash in Winelib. How do I get C++ static initialization to work properly in Winelib? Thanks, Luke

2 1

Re: [1/2] msi: Don't add the same environment string more than once.
by Marvin 26 Aug '15

26 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16331 Your paranoid android. === w7u (32 bit action) === The test timed out === w8 (32 bit action) === The test timed out === wvistau64 (64 bit action) === The test timed out

1 0

Re: [PATCH 3/3] kernel32/tests: Add tests for Invariant
by Alexandre Julliard 26 Aug '15

26 Aug '15

Daniel Lehman <dlehman(a)esri.com> writes: > + { X(LOCALE_SNATIVEDIGITS), "0123456789" }, > + { X(LOCALE_SCURRENCY), "" }, Please avoid non-ASCII characters in source code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] reg: simplify root key search
by Stefan Dösinger 26 Aug '15

26 Aug '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Something is still wrong with the submission: $ git am ~/Desktop/\[PATCH\ 1_2\]\ reg\:\ simplify\ root\ key\ search\ -\ Michel\ Zou\ \<xantares09\(a)hotmail.com\>\ -\ 2015-08-25\ 2150.eml Applying: reg: simplify root key search /home/stefan/src/wine/.git/rebase-apply/patch:33: trailing whitespace. static const WCHAR short_hklm[] = {'H','K','L','M',0}; /home/stefan/src/wine/.git/rebase-apply/patch:34: trailing whitespace. static const WCHAR short_hkcu[] = {'H','K','C','U',0}; /home/stefan/src/wine/.git/rebase-apply/patch:35: trailing whitespace. static const WCHAR short_hkcr[] = {'H','K','C','R',0}; /home/stefan/src/wine/.git/rebase-apply/patch:36: trailing whitespace. static const WCHAR short_hku[] = {'H','K','U',0}; /home/stefan/src/wine/.git/rebase-apply/patch:37: trailing whitespace. static const WCHAR short_hkcc[] = {'H','K','C','C',0}; error: patch failed: programs/reg/reg.c:22 error: programs/reg/reg.c: patch does not apply Patch failed at 0001 reg: simplify root key search It looks like the patch has Windows line endings, but AFAIK that shouldn't break git am. I strongly recommend to use git send-email to make git send the patches directly to the SMTP server instead of going through text files and MUAs. That avoids issues like that pretty reliably. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJV3as6AAoJEN0/YqbEcdMwEfYP/1ibDcxPQ9VF6tKyfQKVeuVW cC1rFbAbbXdWPxALIiJa/qEz/3DKV4j1tIvU68GA6SE5gh4XLsVfH1Li66PX3KQy 6ytqG263r677dDxjTPIJHOTsl4ncFvCVHkVz3cn9zBLM3G6V8BLeL4rCVFq1Wso0 pNS5abhVQNzDTY+gLG2oh9XqtLuI2oAmF6YO/VklVKF8pVwN50RX7FXJuGwlhScn +6GvzOLrkirbTL1jKW+v+4BZ22CjzGRZPVMGPlmgGIdyexVjoG8nAlfvLoH6+Qds 6WQatGcHFNnJjE275Snl9EjnspfedMLcYWspbbC7IsWDvdMrt8LawUGDOyZsqxzC yUYnMHNaotC7K0FpqHG+OKTRgrJy8dX10xSkTAhj6FtLj49BFhNb7hWsqc3T//g6 GlcmCYxWXNmseOt5t5E/v4eb9XowBab9Mv4zNU8sFZWlfUvbv3vMnhfzjslZnHNY h+yBR9OQZiKInPsHxW3wsuIIt0xBjPE1RHUac9vfPc031PvjqYulQ2PfQkUyljo2 vHwqCU6i9S8Y2INd7PwOggoHqE9SKMFvaRg9Tf5vOiG9YQHtaTWHj+xgQsb5DRxd QWV+uK0gZW2UX0ozxzrCK2Kd5mEhTRd/dVZK75/ALoprf2r7aqU7gS+4aQYActlL LIk5K82tvISRR7QdN0KN =cTjQ -----END PGP SIGNATURE-----

2 1

Re: [PATCH v2 2/2] ucrtbase: Hook up some functions with new names to existing implementations
by Alexandre Julliard 26 Aug '15

26 Aug '15

Martin Storsjo <martin(a)martin.st> writes: > These are some functions that on a first glance seem to have a > matching signature even though the exact symbol name isn't the > same as in msvcr120. It would be better to create a separate function, unless there is strong evidence that they are doing the exact same thing. For example, I expect that there's a reason for having both malloc and malloc_base; mapping them to the same function would make any difference hard to spot. -- Alexandre Julliard julliard(a)winehq.org

2 2

FW: [PATCH 2/2] kernel32: add Invariant string table wrc: add support for LANG_INVARIANT
by Daniel Lehman 25 Aug '15

25 Aug '15

-----Original Message----- From: wine-patches [mailto:wine-patches-bounces(a)winehq.org] On Behalf Of Daniel Lehman Sent: Monday, August 24, 2015 12:27 PM To: 'wine-patches(a)winehq.org' Subject: [PATCH 2/2] kernel32: add Invariant string table wrc: add support for LANG_INVARIANT I noticed this was marked as "Superseded". What is it superseded by? https://source.winehq.org/patches/data/113923 (I also noticed the subject got messed up, so I can resubmit if needed) thanks daniel

2 1