August 2015 - Wine-devel - list.winehq.org

Re: [1/2] kernel32/tests: Fix compilation with PSDK.
by Marvin 21 Aug '15

21 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16143 Your paranoid android. === w7u (32 bit process) === process.c:2663: Test failed: WaitForSingleObject returned 258 process.c:2680: Test failed: WaitForSingleObject returned 258

1 0

Re: [PATCH] mshtml: Add IHTMLXMLHttpRequest::abort() method implementation.
by Marvin 21 Aug '15

21 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16139 Your paranoid android. === w2000pro (32 bit xmlhttprequest) === xmlhttprequest: unhandled exception c0000005 at 00475F35

1 0

Re: [1/3] comdlg32: Implement SetControlItemState for menu controls.
by Marvin 20 Aug '15

20 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16136 Your paranoid android. === w7u (32 bit itemdlg) === itemdlg: unhandled exception c0000005 at 76A81EA3 === wvistau64 (64 bit itemdlg) === No test summary line found

1 0

Re: [PATCH 4/5] d3d11/tests: Add test for device interfaces. (try 2)
by Marvin 20 Aug '15

20 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16232 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: [PATCH 14/16] msvcp110: Add tr2_sys__Stat_wchar and tr2_sys__Lstat_wchar implementation and test.(resend)
by Marvin 20 Aug '15

20 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16129 Your paranoid android. === w2008s64 (64 bit msvcp120) === msvcp120.c:176: Test failed: Export '?_Lstat(a)sys@tr2(a)std@@YA?AW4file_type(a)123@PB_WAAH(a)Z' not found msvcp120: unhandled exception c0000005 at 0000000000000000

1 0

CreateDeviceFromD3D implementations, device QI tests and some other patches.
by Aaryaman Vasishta 20 Aug '15

20 Aug '15

Hello! Attached are patches related to implementations of CreateDeviceFromD3D and device QI tests along with fixes to return values for GetDirect3DDevice2 and device QueryInterface. Cheers, Jam

2 5

Re: [PATCH 3/4] wined3d: Add a slop for color keying.
by Henri Verbeet 20 Aug '15

20 Aug '15

On 20 August 2015 at 10:03, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -6332,7 +6332,8 @@ static GLuint shader_glsl_generate_ffp_fragment_shader(struct shader_glsl_priv * > } > > if (settings->color_key_enabled) > - shader_addline(buffer, "if (all(equal(tex0, color_key))) discard;\n"); > + shader_addline(buffer, "if (all(lessThan(abs(tex0 - color_key), vec4(%s)))) discard;\n", > + wined3d_color_key_precision); > ... > +/* Normalization of B5G6R5_UNORM textures is horribly imprecise if we don't have > + * GL_RGB_565 support. 1 / 256 (~0.0039) works in practice, but is awfully close > + * to the next possible value in 8 bit formats. 1 / 384 is too precise for some > + * 5 and 6 bit channel values at least on Nvidia. > + * > + * An exact comparison isn't reliable for any format, except for the normalized > + * values 0.0 and 1.0. */ > +const char *wined3d_color_key_precision = "0.003"; > Shouldn't you just pass the color key as a range to the shader instead? E.g. in a 6 bpc format anything between 0.484f and 0.500f would get quantized to 0x1f. (Which, other floating point issues aside, would correspond to about 0.008 slop here. For a 5 bpc format you'd even have 0.016.)

2 3

Re: [PATCH 02/16] msvcp110: Add tr2_sys__Rename_wchar implementation and test.(try 2)
by Marvin 20 Aug '15

20 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16121 Your paranoid android. === w2000pro (32 bit msvcp120) === The test timed out

1 0

Re: [PATCH 6/7] d3d10core: Implement D3D10CoreCreateDevice using D3D11CoreCreateDevice.
by Henri Verbeet 20 Aug '15

20 Aug '15

On 20 August 2015 at 01:47, Józef Kucia <jkucia(a)codeweavers.com> wrote: > DXGID3D10* functions will be dropped once IDXGIDevice is moved to d3d11. > > D3D10CoreRegisterLayers returns E_NOTIMPL on modern Windows systems. > --- I think the general idea of this patchset works (I haven't looked at all the details yet), but I don't think you can use d3d11 source files in d3d10core like that. If there's really no better way you can probably temporarily use PARENTSRC (look at e.g. d3dcompiler_47 for an example of how to use that), but it may be better to reorder things a bit so that you can essentially merge this patch with the one moving the files.

2 2

Re: [PATCH 7/7] d3d11/tests: Add test for device interfaces.
by Henri Verbeet 20 Aug '15

20 Aug '15

On 20 August 2015 at 01:48, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + hr = ID3D11Device_QueryInterface(device, &IID_ID3D10Device1, (void **)&iface); > + todo_wine ok(hr == E_NOINTERFACE, "Device should not ID3D10Device1 interface, hr %#x.\n", hr); I think you're missing an "implement" here.

1 0