January 2016 - Wine-devel - list.winehq.org

Re: [PATCH] shell32/tests: Explicitly compare to HRESULT values
by Marvin 02 Jan '16

02 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19335 Your paranoid android. === w1064 (32 bit shlfolder) === shlfolder.c:1578: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057

2 1

Re: [3/3] ntdll/tests: Add tests for setting debug registers with NtSetContextThread.
by Marvin 02 Jan '16

02 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19333 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002D0000/002D0001 exception: unhandled exception 80000004 at 002D0000 exception.c:485: Test failed: 42: Wrong exception address 77BAED97/002D0001 === w7u (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:485: Test failed: 42: Wrong exception address 77CDE34F/003D0001 === w1064 (32 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9) === w1064 (64 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9)

2 1

Re: [PATCH] user32: Allow WM_CAPTURECHANGE indicating SetCapture() parameter. (try 2)
by Sebastian Lackner 02 Jan '16

02 Jan '16

On 01.01.2016 23:50, Christopher Thielen wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=13683 > > A window may be notified with WM_CAPTURECHANGED about itself > gaining mouse capture if it calls SetCapture() twice. > > Tested on Windows XP and Fedora Workstation 22. > > Re-submitting to simplify based on wine-devel feedback. > Re-submitting after 1.8 release. > > Signed-off-by: Christopher Thielen <cthielen(a)gmail.com> > Where are the tests you initially had in your patch? I assume you accidentially resent an old version. The tests are still useful to make sure, that noone will break this fix again. Also, please review all the occurances of WM_CAPTURECHANGED, and fix them accordingly. If the code doesn't look like it can handle the double notification, then just ignore them based on the condition lParam == hWnd. This could also be done in separate patches before. Regards, Sebastian

1 0

Re: [PATCH 3/3] ddraw/tests: Use a slop for test_shademode.
by Marvin 01 Jan '16

01 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19330 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2337: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2186: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2253: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2522: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH] d3drm/tests: Add tests for IDirect3DRM*::LoadTexture (try 5).
by Stefan Dösinger 01 Jan '16

01 Jan '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-12-27 um 10:23 schrieb Aaryaman Vasishta: > + if (info_header.biWidth % 4 != 0) > + expected = (info_header.biWidth & ~0x03) + 4; > + else > + expected = info_header.biWidth; This is more complicated than it needs to be: expected = (info_header.biWidth + 3) & ~3 should work as well. > + k++; > + /* Take into account padded bytes after every row for odd widths */ > + if ((w % 2 == 1) && (j == w - 1)) > + k = (k & ~0x03) + 4; Wouldn't this also apply for e.g. a width of 10 that is a multiple of 2, but not a multiple of 4? The canonical way is to advance bytes_per_line bytes every line, e.g. buffer1[i * bytes_per_line + j] Or do k += bytes_per_line in the outer loop and then just do buffer1[k + j] to avoid re-doing the multiplication every time. I'd expect the compiler to optimize it anyway though. Other than that the patch looks good :-) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWhnqDAAoJEN0/YqbEcdMwiLYP/1eERxdjpnqfm2CX3dPF4wmx 3BQjdvH8LLxlS9HNG9PcGXs6gnyhPtsXL3DTSJtsl6UnHn7Ws9EWrjNFrnLEkoDB K7JwHNCPBvuOGb4YHDo4+9NeIXn3Kg6r3yorPGEu0NvWO98FcbhTJWbfhPq4y0uD WvQSCUcqufusFRUFUlOAks5zUXEmEVimxtMgaAYMqul3rsD22pT9CIOPd7Pxp+tc 6AzROoxTA0OoyMpH33APRKCLSwXET6KsMsrV7V83DblE5T9GrIz1ufRYQ155yUpe 3sBG9cGtPJ9KgjEdwp2Gy4hSFOSNVZJauNG3NhYf55cpngnYGU2W7Om9hkGQ6lOF IkjlBDWdKTX6WpC3Yiitw8DfNtRy7S1syEfhkqscYEiDRKYKILHB/njrbdj8q3so SRGAO/g8WSltCfUzlPHU3Jjmb/QjHl6JUV7JkqmJkrmqtd5mrOqPO+YFlDVCwtKl 79DWf5gbF7MbDBQQ82pBy30dy7+a4W9/cmls8x6EeZVr9zBvojfnxbR9xgy7tAVp EWaSUvUJWIoTTxMh4KEbVrH2LxJcEKGocHdXL22h5pMvpk02oCoj8nx1hUtHqMTW mvfYJDGV/DKiaYoSxUjuLqiB1wtNzg4BQcDNCzojRWQD4xS/yHC22rV9/4jG/+b4 F11LmyZfBxp83t+SpGjk =BnPO -----END PGP SIGNATURE-----

2 1

Re: [PATCH] ieframe: Don't write icon file path and index to storage if not specified in shortcut (Valgrind)
by Dmitry Timoshkov 01 Jan '16

01 Jan '16

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > - U(pv[1]).iVal = iconIndex; > + U(pv[1]).lVal = iconIndex; This change is wrong and doesn't match the code below it in the patch. -- Dmitry.

2 1

Re: user32/tests: Add message tests for EM_SETSEL when getting/losing focus in combo boxes
by Marvin 01 Jan '16

01 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19318 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:10877: Test failed: expected PeekMessage to return FALSE, got 1 msg.c:10889: Test failed: msg.message = 275 instead of WM_USER msg.c:10891: Test failed: expected PeekMessage to return FALSE, got 1 msg.c:10900: Test failed: msg.message = 1024 instead of WM_TIMER msg.c:10902: Test failed: expected PeekMessage to return FALSE, got 1 msg.c:13824: Test failed: 0: WaitForSingleObject failed === w1064 (32 bit msg) === msg.c:6290: Test failed: Update region shouldn't be empty msg.c:6524: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6526: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6296: Test failed: Regions are different msg.c:6296: Test failed: Regions are different msg.c:6296: Test failed: Regions are different

2 1