November 2016 - Wine-devel - list.winehq.org

Re: hnetcfg: Improve INetFwAuthorizedApplication::get_ProcessImageFileName stub.
by Alistair Leslie-Hughes 29 Nov '16

29 Nov '16

On 24/11/16 07:22, Bruno Jesus wrote: > From: Michael Müller <michael(a)fds-team.de> > > Manually tested using vbscript. > > @@ -250,7 +252,18 @@ static HRESULT WINAPI fw_app_get_ProcessImageFileName( > fw_app *This = impl_from_INetFwAuthorizedApplication( iface ); > > FIXME("%p, %p\n", This, imageFileName); > - return E_NOTIMPL; > + > + if (!imageFileName) > + return E_INVALIDARG; The return value here is incorrect. I've sent an updated patch+tests to wine-patches Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 2/2] hnetcfg/tests: Add INetFwAuthorizedApplication tests
by Marvin 29 Nov '16

29 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26959 Your paranoid android. === wxppro (32 bit policy) === policy.c:85: Test failed: got: 80070008 policy.c:89: Test failed: got: 80070003 policy.c:92: Test failed: got: 80070003 === w2003std (32 bit policy) === policy.c:85: Test failed: got: 80070008 policy.c:89: Test failed: got: 80070003 policy.c:92: Test failed: got: 80070003 === wvistau64 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w2008s64 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w7u (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w7pro64 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w8 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w864 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w1064 (32 bit policy) === policy.c:92: Test failed: got: 80070003

1 0

Re: [PATCH] wincodecs: Trigger conversion to target format in WriteSource()
by Dmitry Timoshkov 28 Nov '16

28 Nov '16

Vincent Povirk <madewokherd(a)gmail.com> wrote: > Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Does this even fix a real application? What exactly this patch is supposed to fix? -- Dmitry.

1 0

Re: [v3] cmd/tests: chaining rules of pipe and else
by Marvin 28 Nov '16

28 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26946 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Undocumented function prototype
by Marco Savelli 28 Nov '16

28 Nov '16

Hi everybody! I'm new to this list. I found this page (in deutsch) which seems to document an otherwise undocumented function, namely GetPermLayers from aphelp.dll. I don't know where they got it, but seems a realistic definition. Hope it helps. And thanks for your development effort, go on this way! :D P.S. It' in delphi, there's a "var" keyword, which should means (from google, I'm not a delphist) an optional argument. IDA PRO gives error when given the last two args. Hope you can figure out where's the problem

3 4

Re: [PATCH 3/3] wintrust/tests: Remove a test that crashes on Windows 8 amd 10.
by Marvin 28 Nov '16

28 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26944 Your paranoid android. === w1064 (64 bit softpub) === softpub.c:254: Test failed: Expected S_OK, got 00000001 softpub.c:257: Test failed: Expected S_OK, got 00000001

1 0

Re: [PATCH 2/3] wintrust/tests: Initialize the pSigState member to prevent Windows 8 and 10 from crashing.
by Marvin 28 Nov '16

28 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26943 Your paranoid android. === w8 (32 bit softpub) === softpub: unhandled exception c0000005 at 7511A63B === w864 (32 bit softpub) === softpub: unhandled exception c0000005 at 7772A63B === w1064 (32 bit softpub) === softpub: unhandled exception c0000005 at 768B0B90 === w864 (64 bit softpub) === softpub: unhandled exception c0000005 at 00007FFB7AFF9B8F === w1064 (64 bit softpub) === softpub.c:254: Test failed: Expected S_OK, got 00000001 softpub.c:257: Test failed: Expected S_OK, got 00000001 softpub: unhandled exception c0000005 at 00007FFC77A7F593

1 0

Re: [2/5] strmbase: Add validation checks when updating source rectangle.
by Andrew Eikum 28 Nov '16

28 Nov '16

On Sun, Nov 20, 2016 at 03:33:22PM +0900, Akihiro Sagawa wrote: > @@ -53,6 +53,26 @@ HRESULT WINAPI BaseControlVideo_Destroy(BaseControlVideo *pControlVideo) > return BaseDispatch_Destroy(&pControlVideo->baseDispatch); > } > > +static HRESULT BaseControlVideoImpl_CheckSourceRect(BaseControlVideo *This, RECT *pSourceRect) > +{ > + LONG VideoWidth, VideoHeight; > + HRESULT hr; > + > + if (pSourceRect->top < 0 || pSourceRect->left < 0 || > + pSourceRect->top >= pSourceRect->bottom || > + pSourceRect->left >= pSourceRect->right) > + return E_INVALIDARG; I'm not opposed to spelling it out, but you could use IsRectEmpty() here instead. > + > + hr = BaseControlVideoImpl_GetVideoSize((IBasicVideo *)This, &VideoWidth, &VideoHeight); > + if (FAILED(hr)) > + return hr; > + > + if (pSourceRect->bottom > VideoHeight || pSourceRect->right > VideoWidth) > + return E_INVALIDARG; > + Shouldn't these use (bottom - top) and (right - left)? Andrew

2 2

Do we delete spammers accounts from bugzilla?
by Bruno Jesus 28 Nov '16

28 Nov '16

Today we had one more piece of spam, the bot registered the account a few moments before creating a bug. In this case should we use bugzilla's admin features to delete the user? Best wishes, Bruno

3 3

Re: [v2] cmd/tests: chaining rules of pipe and else
by Marvin 28 Nov '16

28 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26937 Your paranoid android. === wxppro (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w2003std (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') batch.c:313: Test failed: unexpected char 0x27 position 0 in line 540 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === w2008s64 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w7u (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w7pro64 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w8 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w864 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w1064 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') batch.c:313: Test failed: unexpected char 0x27 position 0 in line 540 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === w2008s64 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w7pro64 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w864 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w1064 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]')

1 0