February 2016 - Wine-devel - list.winehq.org

Re: [v2] shell32: fix two bugs in IQueryAssocations
by Nikolay Sivov 07 Feb '16

07 Feb '16

On 08.02.2016 3:07, Theodore Dubois wrote: > >> On Feb 7, 2016, at 4:25 AM, Nikolay Sivov <bunglehead(a)gmail.com> wrote: >> >> Why do you need this? > > So I can assert in Init. That's not necessary. > >> >>> This->hkeyProgID = This->hkeySource; >> >> I know it's not something you introduced, but it's dirty and should be >> fixed, because it leads to double free on a same handle. > > I’ll fix that in the next version. > >> Basically you remove everything, and tests don't show that you should do >> that. For example looking at Win7 registry I see HKCR\.exe with default >> value of "exefile", then default value for HKCR\exefile is Application >> (and also there is a FriendlyTypeName key that's most likely localized). >> Current code will return "Application" and that seems like a better >> candidate for a friendly name. > > In that case, hkeyProgID would refer to HKCR\exefile, and then I return the > default value from that key which is “Application”. It used to start with hkeySource > (would point to HKCR\.exe) and do some digging, but my code does that work in Init. > + if (*pszAssoc == '.') > + { > + /* for a file extension, the progid is the default value */ > + hr = ASSOC_GetValue(This->hkeySource, NULL, (void**)&progId, NULL); > + if (FAILED(hr)) > + return hr; > + } What happens if default value is not set? > + else /* if (*pszAssoc == '{') */ > + { > + assert(*pszAssoc == '{'); > + > + HKEY progIdKey; > + /* for a clsid, the progid is the default value of the ProgID subkey */ > + ret = RegOpenKeyExW(This->hkeySource, > + szProgID, > + 0, > + KEY_READ, > + &progIdKey); > + if (ret != ERROR_SUCCESS) > + return HRESULT_FROM_WIN32(ret); > + hr = ASSOC_GetValue(progIdKey, NULL, (void**)&progId, NULL); > + if (FAILED(hr)) > + return hr; > + RegCloseKey(progIdKey); > + } Now Init() will fail on missing progid subkey, and it didn't before. Also this introduces leaks. > >> A convincing test should create a custom extension key, and test all >> possible combinations of empty default values, missing keys with default >> value name etc. > > Yes, more tests is always good. I’ll try and figure out how to test things on Windows and add some more tests in the next version. > > ~Theodore >

2 1

Re: [v2] shell32: fix two bugs in IQueryAssocations
by Theodore Dubois 07 Feb '16

07 Feb '16

> On Feb 7, 2016, at 4:25 AM, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > > Why do you need this? So I can assert in Init. > >> This->hkeyProgID = This->hkeySource; > > I know it's not something you introduced, but it's dirty and should be > fixed, because it leads to double free on a same handle. I’ll fix that in the next version. > Basically you remove everything, and tests don't show that you should do > that. For example looking at Win7 registry I see HKCR\.exe with default > value of "exefile", then default value for HKCR\exefile is Application > (and also there is a FriendlyTypeName key that's most likely localized). > Current code will return "Application" and that seems like a better > candidate for a friendly name. In that case, hkeyProgID would refer to HKCR\exefile, and then I return the default value from that key which is “Application”. It used to start with hkeySource (would point to HKCR\.exe) and do some digging, but my code does that work in Init. > A convincing test should create a custom extension key, and test all > possible combinations of empty default values, missing keys with default > value name etc. Yes, more tests is always good. I’ll try and figure out how to test things on Windows and add some more tests in the next version. ~Theodore

1 0

Re: [PATCH 4/5] wined3d: Introduce wined3d_texture_get_overlay_position().
by Stefan Dösinger 07 Feb '16

07 Feb '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-02-05 um 20:31 schrieb Henri Verbeet: > dlls/wined3d/texture.c | 32 ++++++++++++++++++++++++++++++++ I think the overlay API would be much nicer in swapchains, either textures overlaying swapchains or swapchains overlaying swapchains. Unfortunately the fact that you can assign an overlay to an offscreenplain surface makes that very difficult. A solution similar to palettes where we do most tracking in ddraw and only forward "useful" setups to wined3d might be feasible. Fwiw, the only non video player app that uses overlays that I know is settlers 3, which uses them to draw the mouse pointer if certain options are set. (Feel free to completely ignore this concern, I don't think overlays should be a side quest for CSMT...) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWt33BAAoJEN0/YqbEcdMwiAoP/2uQ2ieAcs6PnFDTpwFhXMxf nYthS9pQfhmLSKPfyp69sj1QJvGLkfwtRJD4xqdu0TkJp3YMYsHIzFktT6wODcOd hqnMcN+8S0EYLFg7CYWgbwN+b+stUUzyFxML5DkLglnU6zC2nfid5Vv0h8o27o/D ySUKnSMqyhIzU5N1KL1qTaucnLYG9zW9Sgtw05zCpBZ86wy2X12ylyhRvofslqPj Cm6TPT5RPcgDw7TGSDfF1nFIp4c3nO6DIl4mWMBP6VCl+Z69Q2CqvSGBqW4ZWd3U Zs1Kae+6iF8FghwNtXx68o/gi/hcab648mA6Jc1ybnwGupv3i27/7ayQPB4Wb4R3 rx/37cJNz4FS9X5/reQJEOhoJR9wDzbBqmyctMOoMp8lOJCcpUaACdFDYvxVhvcv C4T0nMA8nmJ+uW5fgscsduEUFqPAN9QHwHDpn9AzzGVnjrpCEvFwXYFfuLZdhU9r NqMaxpyllA7S8GGuF4gmPPKopKl5C9+ZlNyTEadzhtksgZ9vqtXYbrxYaJryIMwG CPakKX5VHVP48IFxbFgzi7/0iq51njkS0BmTKc65+ZCa6bO3sVAcbu29N1UOFOYU T0XfO6PDUgljCCDLm/9+wrbpGd23yu9HQnUHcwyh41H06L1rBcun52P7PSdoC8Jh vGSx0aSmRCCBYTM9RpWi =XqoV -----END PGP SIGNATURE-----

2 1

Re: [v2] shell32: fix two bugs in IQueryAssocations
by Nikolay Sivov 07 Feb '16

07 Feb '16

On 07.02.2016 1:09, Theodore Dubois wrote: > Basically, returns the correct value for > ASSOCSTR_FRIENDLYDOCNAME and ASSOCSTR_DEFAULTICON > when passed a ProgID instead of a file extension. > > Also adds some tests to make sure it works. > > Signed-off-by: Theodore Dubois <tblodt(a)icloud.com> > --- > dlls/shell32/assoc.c | 115 +++++++++++++++++++++++---------------------- > dlls/shell32/tests/assoc.c | 12 ++++- > 2 files changed, 70 insertions(+), 57 deletions(-) > > diff --git a/dlls/shell32/assoc.c b/dlls/shell32/assoc.c > index 90d00a8..49af3c3 100644 > --- a/dlls/shell32/assoc.c > +++ b/dlls/shell32/assoc.c > @@ -18,6 +18,7 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > */ > #include <stdarg.h> > +#include <assert.h> Why do you need this? > This->hkeyProgID = This->hkeySource; I know it's not something you introduced, but it's dirty and should be fixed, because it leads to double free on a same handle. > + return S_OK; > + } > + > + /* if it's not a progid, it's a file extension or clsid */ > + if (*pszAssoc == '.') > + { > + /* for a file extension, the progid is the default value */ > + hr = ASSOC_GetValue(This->hkeySource, NULL, (void**)&progId, NULL); > + if (FAILED(hr)) > + return hr; > + } > + else /* if (*pszAssoc == '{') */ > + { > + assert(*pszAssoc == '{'); > + > + HKEY progIdKey; > + /* for a clsid, the progid is the default value of the ProgID subkey */ > + ret = RegOpenKeyExW(This->hkeySource, > + szProgID, > + 0, > + KEY_READ, > + &progIdKey); > + if (ret != ERROR_SUCCESS) > + return HRESULT_FROM_WIN32(ret); > + hr = ASSOC_GetValue(progIdKey, NULL, (void**)&progId, NULL); > + if (FAILED(hr)) > + return hr; > + RegCloseKey(progIdKey); > + } > + > + /* open the actual progid key, the one with the shell subkey */ > + ret = RegOpenKeyExW(HKEY_CLASSES_ROOT, > + progId, > + 0, > + KEY_READ, > + &This->hkeyProgID); > + if (ret != ERROR_SUCCESS) > + return HRESULT_FROM_WIN32(ret); > return S_OK; > } > else if (hkeyProgid != NULL) > @@ -507,33 +544,12 @@ static HRESULT WINAPI IQueryAssociations_fnGetString( > > case ASSOCSTR_FRIENDLYDOCNAME: > { > - WCHAR *pszFileType; > - DWORD ret; > - DWORD size; > + WCHAR *docName; > > - hr = ASSOC_GetValue(This->hkeySource, NULL, (void**)&pszFileType, NULL); > + hr = ASSOC_GetValue(This->hkeyProgID, NULL, (void**)&docName, NULL); > if (FAILED(hr)) > return hr; > - size = 0; > - ret = RegGetValueW(HKEY_CLASSES_ROOT, pszFileType, NULL, RRF_RT_REG_SZ, NULL, NULL, &size); > - if (ret == ERROR_SUCCESS) > - { > - WCHAR *docName = HeapAlloc(GetProcessHeap(), 0, size); > - if (docName) > - { > - ret = RegGetValueW(HKEY_CLASSES_ROOT, pszFileType, NULL, RRF_RT_REG_SZ, NULL, docName, &size); > - if (ret == ERROR_SUCCESS) > - hr = ASSOC_ReturnString(flags, pszOut, pcchOut, docName, strlenW(docName) + 1); > - else > - hr = HRESULT_FROM_WIN32(ret); > - HeapFree(GetProcessHeap(), 0, docName); > - } > - else > - hr = E_OUTOFMEMORY; > - } > - else > - hr = HRESULT_FROM_WIN32(ret); > - HeapFree(GetProcessHeap(), 0, pszFileType); > + hr = ASSOC_ReturnString(flags, pszOut, pcchOut, docName, strlenW(docName) + 1); > return hr; > } Basically you remove everything, and tests don't show that you should do that. For example looking at Win7 registry I see HKCR\.exe with default value of "exefile", then default value for HKCR\exefile is Application (and also there is a FriendlyTypeName key that's most likely localized). Current code will return "Application" and that seems like a better candidate for a friendly name. A convincing test should create a custom extension key, and test all possible combinations of empty default values, missing keys with default value name etc. > > @@ -623,41 +639,28 @@ get_friendly_name_fail: > case ASSOCSTR_DEFAULTICON: > { > static const WCHAR DefaultIconW[] = {'D','e','f','a','u','l','t','I','c','o','n',0}; > - WCHAR *pszFileType; > DWORD ret; > DWORD size; > - HKEY hkeyFile; > > - hr = ASSOC_GetValue(This->hkeySource, NULL, (void**)&pszFileType, NULL); > - if (FAILED(hr)) > - return hr; > - ret = RegOpenKeyExW(HKEY_CLASSES_ROOT, pszFileType, 0, KEY_READ, &hkeyFile); > + size = 0; > + ret = RegGetValueW(This->hkeyProgID, DefaultIconW, NULL, RRF_RT_REG_SZ, NULL, NULL, &size); > if (ret == ERROR_SUCCESS) > { > - size = 0; > - ret = RegGetValueW(hkeyFile, DefaultIconW, NULL, RRF_RT_REG_SZ, NULL, NULL, &size); > - if (ret == ERROR_SUCCESS) > + WCHAR *icon = HeapAlloc(GetProcessHeap(), 0, size); > + if (icon) > { > - WCHAR *icon = HeapAlloc(GetProcessHeap(), 0, size); > - if (icon) > - { > - ret = RegGetValueW(hkeyFile, DefaultIconW, NULL, RRF_RT_REG_SZ, NULL, icon, &size); > - if (ret == ERROR_SUCCESS) > - hr = ASSOC_ReturnString(flags, pszOut, pcchOut, icon, strlenW(icon) + 1); > - else > - hr = HRESULT_FROM_WIN32(ret); > - HeapFree(GetProcessHeap(), 0, icon); > - } > + ret = RegGetValueW(This->hkeyProgID, DefaultIconW, NULL, RRF_RT_REG_SZ, NULL, icon, &size); > + if (ret == ERROR_SUCCESS) > + hr = ASSOC_ReturnString(flags, pszOut, pcchOut, icon, strlenW(icon) + 1); > else > - hr = E_OUTOFMEMORY; > + hr = HRESULT_FROM_WIN32(ret); > + HeapFree(GetProcessHeap(), 0, icon); > } > else > - hr = HRESULT_FROM_WIN32(ret); > - RegCloseKey(hkeyFile); > + hr = E_OUTOFMEMORY; > } > else > hr = HRESULT_FROM_WIN32(ret); > - HeapFree(GetProcessHeap(), 0, pszFileType); > return hr; > } Same.

1 0

Re: shell32/tests: Fix okShell()'s tracing so it takes todo and other flags into account.
by Marvin 06 Feb '16

06 Feb '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20233 Your paranoid android. === w1064 (32 bit shlexec) === shlexec.c:2424: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt7EA7.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" failed: rc=29 err=2 shlexec.c:2424: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt7EA7.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" failed: rc=29 err=2 shlexec.c:2422: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt7EA7.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="%1", ddeexec="[open(%1)]", app="shlexec", topic="dde" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2424: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt7EA7.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="%1", ddeexec="[open(%1)]", app="shlexec", topic="dde" failed: rc=29 err=32 shlexec.c:2436: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt7EA7.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde", ifexec="[ifexec("%1")]" ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt7EA7.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wt7EA7.tmp\test file.sde")]' shlexec.c:2424: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt7EA7.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" failed: rc=29 err=2 shlexec.c:2424: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt7EA7.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", topic="dde" failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2424: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtEC4F.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" failed: rc=29 err=2 shlexec.c:2422: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtEC4F.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2424: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtEC4F.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" failed: rc=29 err=32 shlexec.c:2424: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtEC4F.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde", ifexec="[ifexec("%1")]" failed: rc=29 err=2 shlexec.c:2422: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtEC4F.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2424: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtEC4F.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" failed: rc=29 err=32

1 0

Re: [1/2] tests: Add winetest_status() which indicates what to do with a test result.
by Alexandre Julliard 05 Feb '16

05 Feb '16

Francois Gouget <fgouget(a)codeweavers.com> writes: > winetest_status() takes into account not just the condition but also > the todo level, debug level, whether to report successful tests; and > returns the test status and whether to trace its result. > This allows individual tests to do their own logging taking into account all these flags. > > Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Honestly, this thing is getting out of hand. Not only is this adding a lot of complexity for a trivial difference in output, but it has actually made the traces less readable IMO. Can we please get rid of the fancy macros and go back to printing the relevant information in the ok() calls, like all other tests do? Pretty please? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] shell32: fix two bugs in IQueryAssocations
by Marvin 05 Feb '16

05 Feb '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20228 Your paranoid android. === wxppro (32 bit assoc) === assoc.c:144: Test failed: 3: got needed length 18 assoc.c:144: Test failed: 5: got needed length 18 === w2003std (32 bit assoc) === assoc.c:144: Test failed: 3: got needed length 18 assoc.c:144: Test failed: 5: got needed length 18 === wvistau64 (32 bit assoc) === assoc.c:140: Test failed: 2: GetString failed, 0x8007007a assoc.c:144: Test failed: 3: got needed length 19 assoc.c:140: Test failed: 4: GetString failed, 0x8007007a assoc.c:144: Test failed: 5: got needed length 19 === w2008s64 (32 bit assoc) === assoc.c:140: Test failed: 2: GetString failed, 0x8007007a assoc.c:144: Test failed: 3: got needed length 18 assoc.c:140: Test failed: 4: GetString failed, 0x8007007a assoc.c:144: Test failed: 5: got needed length 18 === w7u (32 bit assoc) === assoc.c:140: Test failed: 2: GetString failed, 0x8007007a assoc.c:144: Test failed: 3: got needed length 16 assoc.c:140: Test failed: 4: GetString failed, 0x8007007a assoc.c:144: Test failed: 5: got needed length 16 === w7pro64 (32 bit assoc) === assoc.c:140: Test failed: 2: GetString failed, 0x8007007a assoc.c:144: Test failed: 3: got needed length 18 assoc.c:140: Test failed: 4: GetString failed, 0x8007007a assoc.c:144: Test failed: 5: got needed length 18 === w8 (32 bit assoc) === assoc.c:140: Test failed: 2: GetString failed, 0x8007007a assoc.c:144: Test failed: 3: got needed length 18 assoc.c:140: Test failed: 4: GetString failed, 0x8007007a assoc.c:144: Test failed: 5: got needed length 18 === w864 (32 bit assoc) === assoc.c:140: Test failed: 2: GetString failed, 0x8007007a assoc.c:144: Test failed: 3: got needed length 18 assoc.c:140: Test failed: 4: GetString failed, 0x8007007a assoc.c:144: Test failed: 5: got needed length 18 === w1064 (32 bit assoc) === assoc.c:140: Test failed: 2: GetString failed, 0x8007007a assoc.c:144: Test failed: 3: got needed length 18 assoc.c:140: Test failed: 4: GetString failed, 0x8007007a assoc.c:144: Test failed: 5: got needed length 18 === wvistau64 (64 bit assoc) === assoc.c:140: Test failed: 2: GetString failed, 0x8007007a assoc.c:144: Test failed: 3: got needed length 19 assoc.c:140: Test failed: 4: GetString failed, 0x8007007a assoc.c:144: Test failed: 5: got needed length 19 === w2008s64 (64 bit assoc) === assoc.c:140: Test failed: 2: GetString failed, 0x8007007a assoc.c:144: Test failed: 3: got needed length 18 assoc.c:140: Test failed: 4: GetString failed, 0x8007007a assoc.c:144: Test failed: 5: got needed length 18 === w7pro64 (64 bit assoc) === assoc.c:140: Test failed: 2: GetString failed, 0x8007007a assoc.c:144: Test failed: 3: got needed length 18 assoc.c:140: Test failed: 4: GetString failed, 0x8007007a assoc.c:144: Test failed: 5: got needed length 18 === w864 (64 bit assoc) === assoc.c:140: Test failed: 2: GetString failed, 0x8007007a assoc.c:144: Test failed: 3: got needed length 18 assoc.c:140: Test failed: 4: GetString failed, 0x8007007a assoc.c:144: Test failed: 5: got needed length 18 === w1064 (64 bit assoc) === assoc.c:140: Test failed: 2: GetString failed, 0x8007007a assoc.c:144: Test failed: 3: got needed length 18 assoc.c:140: Test failed: 4: GetString failed, 0x8007007a assoc.c:144: Test failed: 5: got needed length 18

1 0

Re: [PATCH] shell32: fix two bugs in IQueryAssocations
by Marvin 05 Feb '16

05 Feb '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20227 Your paranoid android. === wvistau64 (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w2008s64 (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w7u (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w7pro64 (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w8 (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w864 (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w1064 (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === wvistau64 (64 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w2008s64 (64 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w7pro64 (64 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w864 (64 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w1064 (64 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a

1 0

Re: [PATCH] shell32: fix two bugs in IQueryAssocations
by Marvin 05 Feb '16

05 Feb '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20226 Your paranoid android. === wvistau64 (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w2008s64 (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w7u (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w7pro64 (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w8 (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w864 (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w1064 (32 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === wvistau64 (64 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w2008s64 (64 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w7pro64 (64 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w864 (64 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a === w1064 (64 bit assoc) === assoc.c:136: Test failed: 2: GetString failed, 0x8007007a

1 0

Re: [PATCH 3/5] ddraw/tests: Rewrite rectangle_settings().
by Marvin 05 Feb '16

05 Feb '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20225 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0