March 2016 - Wine-devel - list.winehq.org

Re: [tools 1/2] Handle "midl_pragma warning" statement in parser
by Nikolay Sivov 22 Mar '16

22 Mar '16

On 20.03.2016 13:11, Bolotov Sergey wrote: > Signed-off-by: Bolotov Sergey <bolotov.s.s(a)yandex.ru> > --- > tools/widl/parser.h | 2 ++ > tools/widl/parser.l | 25 +++++++++++++++++++++++++ > tools/widl/parser.y | 38 +++++++++++++++++++++++++++++++++++++- > tools/widl/widltypes.h | 7 +++++++ > 4 files changed, 71 insertions(+), 1 deletion(-) > > diff --git a/tools/widl/parser.h b/tools/widl/parser.h > index 1bcc3c1..c15d874 100644 > --- a/tools/widl/parser.h > +++ b/tools/widl/parser.h > @@ -45,6 +45,8 @@ void pop_import(void); > > int is_type(const char *name); > > +int do_warning(char *toggle, warning_list_t *wnum); > + > extern char *temp_name; > > #endif > diff --git a/tools/widl/parser.l b/tools/widl/parser.l > index 5c2dcab..65e0f45 100644 > --- a/tools/widl/parser.l > +++ b/tools/widl/parser.l > @@ -164,6 +164,7 @@ UUID *parse_uuid(const char *u) > yy_pop_state(); > } > <PP_PRAGMA>[^\n]* parser_lval.str = xstrdup(yytext); yy_pop_state(); return aPRAGMA; > +<INITIAL>^{ws}*"midl_pragma warning" return tPRAGMA_WARNING; > <INITIAL,ATTR>\" yy_push_state(QUOTE); cbufidx = 0; > <QUOTE>\" { This is wrong, any number of spaces is allowed before 'warning'. > yy_pop_state(); > @@ -555,3 +556,27 @@ void abort_import(void) > for (ptr=0; ptr<import_stack_ptr; ptr++) > unlink(import_stack[ptr].temp_name); > } > + > +static void warning_disable(int warning) > +{ > + printf("disable %d\n", warning); > +} > + > +static void warning_enable(int warning) > +{ > + printf("enable %d\n", warning); > +} > + > +int do_warning(char *toggle, warning_list_t *wnum) > +{ > + warning_t *warning; > + if(!strcmp(toggle, "disable")) > + LIST_FOR_EACH_ENTRY(warning, wnum, warning_t, entry) > + warning_disable(warning->num); > + else if(!strcmp(toggle, "enable")) > + LIST_FOR_EACH_ENTRY(warning, wnum, warning_t, entry) > + warning_enable(warning->num); > + else > + return 0; > + return 1; > +} You remove this in next patch, I think it'd be enough to add parser support first, so widl does not fail on such construct, and add handling as 2/2. Why do you need this in a first place? Is it to process some third party idls?

1 0

Re: [PATCH 1/6] ddraw/tests: Rewrite blt_test().
by Marvin 22 Mar '16

22 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21588 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w8 (32 bit visual) === visual.c:1387: Test failed: unexpected colortable on offscreen surface === w864 (32 bit visual) === visual.c:1387: Test failed: unexpected colortable on offscreen surface === w1064 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 visual.c:1387: Test failed: unexpected colortable on offscreen surface === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Student interested in GSoC 2016 implementing D3DX9 API idea
by Xu Zhao 22 Mar '16

22 Mar '16

Hello Wine Community, First congrats that Wine Project get accepted into GSoC 2016 summer organization! I am currently a PhD student in University of Toronto and I am interested in the D3DX9 API implementation task. Mainly because I would like to see more games can run in wine because of my work! My research field is operating system so I am a pretty good C/CPP programmer. However I am not very familiar with DirectX related programming and hopefully I can get some help from the community, like where to start. I have read the wiki entry of D3DX9 API and want to get some help in selecting a reasonable sized API list, maybe someone can reply and provide some help? Thank you! Regards, - Xu -- Xu Zhao i(a)xuzhao.net

2 2

Server Downtime 2016-03-16 19:00 CDT
by Jeremy Newman 22 Mar '16

22 Mar '16

WineHQ.org and all related websites will be offline for maintenance and upgrades on 2016-03-16 starting at 19:00 CDT. This downtime should last 1-2 hours. Some websites may remain offline longer if they need additional work. I'll reply to this post when everything looks to be back online. -N

4 6

Re: [PATCH 2/6] ddraw/tests: Get rid of the unused "d3d" variable in test_shademode().
by Marvin 22 Mar '16

22 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21589 Your paranoid android. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH] vulkan-icd: Add stub dll.
by Roderick Colenbrander 22 Mar '16

22 Mar '16

Hi Gabríel, Thanks for your patch. Depending on the direction where you intend to take this, I'm not sure if we need this dll. Note I haven't done much with Vulkan myself yet, but following the analogy of opengl32, the ICD portion should be inside winex11.drv (and our other drivers). It is what should export this function call ultimately and similar needs to host the x11 related vulkan code, which has to live in here as well, because such code is not supposed to live outside winex11.drv. Thanks, Roderick On Mon, Mar 21, 2016 at 8:26 PM, Gabríel Arthúr Pétursson <gabriel(a)system.is> wrote: > Signed-off-by: Gabríel Arthúr Pétursson <gabriel(a)system.is> > --- > configure.ac | 1 + > dlls/vulkan-icd/Makefile.in | 2 ++ > dlls/vulkan-icd/vulkan-icd.spec | 1 + > 3 files changed, 4 insertions(+) > create mode 100644 dlls/vulkan-icd/Makefile.in > create mode 100644 dlls/vulkan-icd/vulkan-icd.spec > > diff --git a/configure.ac b/configure.ac > index 77c54c8..04ddb54 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -3310,6 +3310,7 @@ WINE_CONFIG_DLL(vnbt.vxd,enable_win16) > WINE_CONFIG_DLL(vnetbios.vxd,enable_win16) > WINE_CONFIG_DLL(vssapi) > WINE_CONFIG_DLL(vtdapi.vxd,enable_win16) > +WINE_CONFIG_DLL(vulkan-icd,,[implib]) > WINE_CONFIG_DLL(vwin32.vxd,enable_win16) > WINE_CONFIG_DLL(w32skrnl,enable_win16) > WINE_CONFIG_DLL(w32sys.dll16,enable_win16) > diff --git a/dlls/vulkan-icd/Makefile.in b/dlls/vulkan-icd/Makefile.in > new file mode 100644 > index 0000000..c41bf8f > --- /dev/null > +++ b/dlls/vulkan-icd/Makefile.in > @@ -0,0 +1,2 @@ > +MODULE = vulkan-icd.dll > +IMPORTLIB = vulkan-icd > diff --git a/dlls/vulkan-icd/vulkan-icd.spec b/dlls/vulkan-icd/vulkan-icd.spec > new file mode 100644 > index 0000000..db3616e > --- /dev/null > +++ b/dlls/vulkan-icd/vulkan-icd.spec > @@ -0,0 +1 @@ > +@ stub vk_icdGetInstanceProcAddr > -- > 2.7.0 > > >

2 3

Re: services: Make release_process() static.
by Sebastian Lackner 22 Mar '16

22 Mar '16

On 22.03.2016 11:26, Francois Gouget wrote: > Signed-off-by: Francois Gouget <fgouget(a)free.fr> > --- > programs/services/services.c | 12 ++++++------ > programs/services/services.h | 1 - > 2 files changed, 6 insertions(+), 7 deletions(-) > I do not mind if this patch is accepted, but follow patches would have to undo this change again. We also need the function from other services files.

1 0

Re: [PATCH 2/2] ddraw/tests: Use SetRect() instead of open coding it.
by Marvin 22 Mar '16

22 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21571 Your paranoid android. === w864 (32 bit d3d) === d3d.c:2311: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2311: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2311: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2311: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2492: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2636: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2636: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2636: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2636: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit d3d) === d3d.c:2311: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2311: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2311: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2311: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2492: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2636: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2636: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2636: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2636: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w8 (32 bit visual) === visual.c:1478: Test failed: unexpected colortable on offscreen surface === w864 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 visual.c:1478: Test failed: unexpected colortable on offscreen surface === w1064 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 visual.c:1478: Test failed: unexpected colortable on offscreen surface

2 1

Failing mshtml:xmlhttprequest test
by Francois Gouget 22 Mar '16

22 Mar '16

Since the WineHQ.org upgrade the mshtml:xmlhttprequest test has been failing on all platforms: xmlhttprequest.c:448: Test failed: Expect Server: Apache, got L"Apache/2.4.10 (Debian)" Due to: 583 static const struct HEADER_TYPE expect_headers[] = { 584 {"Server", "Apache"}, 585 {"Accept-Ranges", "bytes"}, Fixing the failure is easy, but maybe the test should be more flexible? It could be annoying to have to upgrade it with each minor server upgrade. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Theory is where you know everything but nothing works. Practice is where everything works but nobody knows why. Sometimes they go hand in hand: nothing works and nobody knows why.

2 1

Re: [PATCH 1/2] ddraw/tests: Fix copy&paste errors in open coded SetRect()
by Marvin 22 Mar '16

22 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21570 Your paranoid android. === w8 (32 bit visual) === visual.c:1486: Test failed: unexpected colortable on offscreen surface === w864 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 visual.c:1486: Test failed: unexpected colortable on offscreen surface === w1064 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 visual.c:1486: Test failed: unexpected colortable on offscreen surface

2 1