May 2016 - Wine-devel - list.winehq.org

Re: [PATCH 2/4] winemac.drv: Move create_bitmap_from_dib() above the import/export functions.
by Ken Thomases 04 May '16

04 May '16

Signed-off-by: Ken Thomases <ken(a)codeweavers.com>

1 0

Re: winemac.drv: Use IsRectEmpty() instead of open coding it.
by Ken Thomases 04 May '16

04 May '16

On May 3, 2016, at 2:47 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > Not even compile tested. But as this is a purely generated patch there > was no opportunity for me to screw it up... In fact, it doesn't compile. :-/ You've added a call to IsRectEmpty() to macdrv.h, which doesn't #include winuser.h. That alone only causes an implicit declaration warning. However, clipboard.c includes winuser.h after macdrv.h, which causes an error about the conflict between the real and implicit declarations. You can move the include of winuser.h from all of the modules to macdrv.h, but make sure to #define OEMRESOURCE before it, as required by mouse.c. It also seems to need to come after the include of wingdi.h. -Ken > > > > dlls/winemac.drv/macdrv.h | 2 +- > dlls/winemac.drv/window.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/winemac.drv/macdrv.h b/dlls/winemac.drv/macdrv.h > index f3b5e65..81b642c 100644 > --- a/dlls/winemac.drv/macdrv.h > +++ b/dlls/winemac.drv/macdrv.h > @@ -47,7 +47,7 @@ > > static inline CGRect cgrect_from_rect(RECT rect) > { > - if (rect.left >= rect.right || rect.top >= rect.bottom) > + if (IsRectEmpty(&rect)) > return CGRectMake(rect.left, rect.top, 0, 0); > return CGRectMake(rect.left, rect.top, rect.right - rect.left, rect.bottom - rect.top); > } > diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c > index a48ac17..fbea49f 100644 > --- a/dlls/winemac.drv/window.c > +++ b/dlls/winemac.drv/window.c > @@ -401,7 +401,7 @@ static void sync_window_region(struct macdrv_win_data *data, HRGN win_region) > */ > static inline void add_bounds_rect(RECT *bounds, const RECT *rect) > { > - if (rect->left >= rect->right || rect->top >= rect->bottom) return; > + if (IsRectEmpty(rect)) return; > bounds->left = min(bounds->left, rect->left); > bounds->top = min(bounds->top, rect->top); > bounds->right = max(bounds->right, rect->right); > -- > 2.4.11 > >

1 0

Re: ntdll: Fix buffer allocation check in get_dir_data_space.
by Alexandre Julliard 04 May '16

04 May '16

Sebastian Lackner <sebastian(a)fds-team.de> writes: > BTW: I assume its intentional that you realloc only the first buffer to release > some space, right? In the worst case we are wasting up to about > PATH_MAX * sizeof(WCHAR) space in the other buffers. Yes, in the common case it will only waste a few bytes. It's only the last buffer that can have significant space left. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dbghelp: Fix a typo in comment
by Frédéric Delanoy 04 May '16

04 May '16

Minor thing, but you wanna keep "*/" alignment consistent by adding a space. On Tue, May 3, 2016 at 4:01 PM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > @@ -58,7 +58,7 @@ > /* order from highest-order term to lowest-order term. UARTs transmit */ > /* characters in order from LSB to MSB. By storing the CRC this way, */ > /* we hand it to the UART in the order low-byte to high-byte; the UART */ > -/* sends each low-bit to hight-bit; and the result is transmission bit */ > +/* sends each low-bit to high-bit; and the result is transmission bit */ > /* by bit from highest- to lowest-order term without requiring any bit */ > /* shuffling on our part. Reception works similarly. */ -- Frédéric Delanoy

1 0

Re: user32/tests: Don't test function directly when reporting GetLastError()
by Marvin 03 May '16

03 May '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22828 Your paranoid android. === wvistau64 (64 bit win) === win.c:8154: Test failed: transparent window didn't get WM_NCHITTEST message win.c:8155: Test failed: button under static window didn't get WM_LBUTTONUP

1 0

Re: [PATCH 3/4] d3drm: Implement IDirect3DRM*_CreateTexture. (v2)
by Aaryaman Vasishta 03 May '16

03 May '16

Please take a look at v2 of this patch and v2 of patch 2/4. 1/4 and 4/4 are there as well but are way down the list so should I resend the whole patch set instead? Cheers Aaryaman On Sat, Apr 30, 2016 at 4:54 PM, Aaryaman Vasishta < jem456.vasishta(a)gmail.com> wrote: > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- > dlls/d3drm/d3drm.c | 37 ++++++++++++++++++++--------- > dlls/d3drm/tests/d3drm.c | 61 > ++++++++++++++++++++++++++++++++++++++++++++---- > dlls/d3drm/texture.c | 2 +- > 3 files changed, 83 insertions(+), 17 deletions(-) > > diff --git a/dlls/d3drm/d3drm.c b/dlls/d3drm/d3drm.c > index 2b428ef..6c6007d 100644 > --- a/dlls/d3drm/d3drm.c > +++ b/dlls/d3drm/d3drm.c > @@ -195,17 +195,19 @@ static HRESULT WINAPI > d3drm1_CreateAnimationSet(IDirect3DRM *iface, IDirect3DRMA > static HRESULT WINAPI d3drm1_CreateTexture(IDirect3DRM *iface, > D3DRMIMAGE *image, IDirect3DRMTexture **texture) > { > - struct d3drm_texture *object; > + struct d3drm *d3drm = impl_from_IDirect3DRM(iface); > + IDirect3DRMTexture3 *texture3; > HRESULT hr; > > - FIXME("iface %p, image %p, texture %p partial stub.\n", iface, image, > texture); > + TRACE("iface %p, image %p, texture %p.\n", iface, image, texture); > > - if (FAILED(hr = d3drm_texture_create(&object))) > + if (FAILED(hr = > IDirect3DRM3_CreateTexture(&d3drm->IDirect3DRM3_iface, image, &texture3))) > return hr; > > - *texture = &object->IDirect3DRMTexture_iface; > + hr = IDirect3DRMTexture3_QueryInterface(texture3, > &IID_IDirect3DRMTexture, (void **)texture); > + IDirect3DRMTexture3_Release(texture3); > > - return D3DRM_OK; > + return hr; > } > > static HRESULT WINAPI d3drm1_CreateLight(IDirect3DRM *iface, > @@ -661,17 +663,19 @@ static HRESULT WINAPI > d3drm2_CreateAnimationSet(IDirect3DRM2 *iface, IDirect3DRM > static HRESULT WINAPI d3drm2_CreateTexture(IDirect3DRM2 *iface, > D3DRMIMAGE *image, IDirect3DRMTexture2 **texture) > { > - struct d3drm_texture *object; > + struct d3drm *d3drm = impl_from_IDirect3DRM2(iface); > + IDirect3DRMTexture3 *texture3; > HRESULT hr; > > - FIXME("iface %p, image %p, texture %p partial stub.\n", iface, image, > texture); > + TRACE("iface %p, image %p, texture %p.\n", iface, image, texture); > > - if (FAILED(hr = d3drm_texture_create(&object))) > + if (FAILED(hr = > IDirect3DRM3_CreateTexture(&d3drm->IDirect3DRM3_iface, image, &texture3))) > return hr; > > - *texture = &object->IDirect3DRMTexture2_iface; > + hr = IDirect3DRMTexture3_QueryInterface(texture3, > &IID_IDirect3DRMTexture2, (void **)texture); > + IDirect3DRMTexture3_Release(texture3); > > - return D3DRM_OK; > + return hr; > } > > static HRESULT WINAPI d3drm2_CreateLight(IDirect3DRM2 *iface, > @@ -1152,13 +1156,24 @@ static HRESULT WINAPI > d3drm3_CreateAnimationSet(IDirect3DRM3 *iface, IDirect3DRM > static HRESULT WINAPI d3drm3_CreateTexture(IDirect3DRM3 *iface, > D3DRMIMAGE *image, IDirect3DRMTexture3 **texture) > { > + struct d3drm *d3drm = impl_from_IDirect3DRM3(iface); > struct d3drm_texture *object; > HRESULT hr; > > - FIXME("iface %p, image %p, texture %p partial stub.\n", iface, image, > texture); > + TRACE("iface %p, image %p, texture %p.\n", iface, image, texture); > + > + if (!d3drm_validate_image(image)) > + return D3DRMERR_BADVALUE; > > if (FAILED(hr = d3drm_texture_create(&object))) > return hr; > + object->d3drm = &d3drm->IDirect3DRM_iface; > + > + if (FAILED(hr = > IDirect3DRMTexture3_InitFromImage(&object->IDirect3DRMTexture3_iface, > image))) > + { > + d3drm_texture_destroy(object); > + return hr; > + } > > *texture = &object->IDirect3DRMTexture3_iface; > > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 2a70ca4..3a32e6d 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -1725,11 +1725,62 @@ static void test_Texture(void) > hr = IDirect3DRM_QueryInterface(d3drm1, &IID_IDirect3DRM3, (void > **)&d3drm3); > ok(SUCCEEDED(hr), "Cannot get IDirect3DRM3 interface (hr = %x).\n", > hr); > > + /* Tests for validation of D3DRMIMAGE struct */ > + hr = IDirect3DRM_CreateTexture(d3drm1, &testimg, &texture1); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture interface (hr = > %x)\n", hr); > + hr = IDirect3DRM2_CreateTexture(d3drm2, &testimg, &texture2); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture2 interface (hr = > %x)\n", hr); > + hr = IDirect3DRM3_CreateTexture(d3drm3, &testimg, &texture3); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture3 interface (hr = > %x)\n", hr); > + IDirect3DRMTexture_Release(texture1); > + IDirect3DRMTexture2_Release(texture2); > + IDirect3DRMTexture3_Release(texture3); > + > + initimg.rgb = 0; > + hr = IDirect3DRM_CreateTexture(d3drm1, &initimg, &texture1); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM2_CreateTexture(d3drm2, &initimg, &texture2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM3_CreateTexture(d3drm3, &initimg, &texture3); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + initimg.rgb = 1; > + initimg.red_mask = 0; > + hr = IDirect3DRM_CreateTexture(d3drm1, &initimg, &texture1); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM2_CreateTexture(d3drm2, &initimg, &texture2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM3_CreateTexture(d3drm3, &initimg, &texture3); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + initimg.red_mask = 0x000000ff; > + initimg.green_mask = 0; > + hr = IDirect3DRM_CreateTexture(d3drm1, &initimg, &texture1); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM2_CreateTexture(d3drm2, &initimg, &texture2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM3_CreateTexture(d3drm3, &initimg, &texture3); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + initimg.green_mask = 0x0000ff00; > + initimg.blue_mask = 0; > + hr = IDirect3DRM_CreateTexture(d3drm1, &initimg, &texture1); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM2_CreateTexture(d3drm2, &initimg, &texture2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM3_CreateTexture(d3drm3, &initimg, &texture3); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + initimg.blue_mask = 0x00ff0000; > + initimg.buffer1 = NULL; > + hr = IDirect3DRM_CreateTexture(d3drm1, &initimg, &texture1); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM2_CreateTexture(d3drm2, &initimg, &texture2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM3_CreateTexture(d3drm3, &initimg, &texture3); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + > initimg.buffer1 = &pixel; > hr = IDirect3DRM_CreateTexture(d3drm1, &initimg, &texture1); > ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture interface (hr = > %x)\n", hr); > ref2 = get_refcount((IUnknown *)d3drm1); > - todo_wine ok(ref2 > ref1, "expected ref2 > ref1, got ref1 = %u , ref2 > = %u.\n", ref1, ref2); > + ok(ref2 > ref1, "expected ref2 > ref1, got ref1 = %u , ref2 = %u.\n", > ref1, ref2); > ref3 = get_refcount((IUnknown *)d3drm2); > ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u , ref3 = > %u.\n", ref1, ref3); > ref4 = get_refcount((IUnknown *)d3drm3); > @@ -1737,7 +1788,7 @@ static void test_Texture(void) > hr = IDirect3DRM2_CreateTexture(d3drm2, &initimg, &texture2); > ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture2 interface (hr = > %x)\n", hr); > ref2 = get_refcount((IUnknown *)d3drm1); > - todo_wine ok(ref2 > ref1 + 1, "expected ref2 > ref1, got ref1 = %u , > ref2 = %u.\n", ref1, ref2); > + ok(ref2 > ref1 + 1, "expected ref2 > (ref1 + 1), got ref1 = %u , ref2 > = %u.\n", ref1, ref2); > ref3 = get_refcount((IUnknown *)d3drm2); > ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u , ref3 = > %u.\n", ref1, ref3); > ref4 = get_refcount((IUnknown *)d3drm3); > @@ -1745,7 +1796,7 @@ static void test_Texture(void) > hr = IDirect3DRM3_CreateTexture(d3drm3, &initimg, &texture3); > ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture3 interface (hr = > %x)\n", hr); > ref2 = get_refcount((IUnknown *)d3drm1); > - todo_wine ok(ref2 > ref1 + 2, "expected ref2 > ref1, got ref1 = %u , > ref2 = %u.\n", ref1, ref2); > + ok(ref2 > ref1 + 2, "expected ref2 > (ref1 + 2), got ref1 = %u , ref2 > = %u.\n", ref1, ref2); > ref3 = get_refcount((IUnknown *)d3drm2); > ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u , ref3 = > %u.\n", ref1, ref3); > ref4 = get_refcount((IUnknown *)d3drm3); > @@ -1803,7 +1854,7 @@ static void test_Texture(void) > > IDirect3DRMTexture_Release(texture1); > ref2 = get_refcount((IUnknown *)d3drm1); > - todo_wine ok(ref2 - 2 == ref1, "expected ref2 == ref1, got ref1 = %u, > ref2 = %u.\n", ref1, ref2); > + ok(ref2 - 2 == ref1, "expected (ref2 - 2) == ref1, got ref1 = %u, > ref2 = %u.\n", ref1, ref2); > ref3 = get_refcount((IUnknown *)d3drm2); > ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u, ref3 = > %u.\n", ref1, ref3); > ref4 = get_refcount((IUnknown *)d3drm3); > @@ -1827,7 +1878,7 @@ static void test_Texture(void) > > IDirect3DRMTexture2_Release(texture2); > ref2 = get_refcount((IUnknown *)d3drm1); > - todo_wine ok(ref2 - 1 == ref1, "expected ref2 == ref1, got ref1 = %u, > ref2 = %u.\n", ref1, ref2); > + ok(ref2 - 1 == ref1, "expected (ref2 - 1) == ref1, got ref1 = %u, > ref2 = %u.\n", ref1, ref2); > ref3 = get_refcount((IUnknown *)d3drm2); > ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u, ref3 = > %u.\n", ref1, ref3); > ref4 = get_refcount((IUnknown *)d3drm3); > diff --git a/dlls/d3drm/texture.c b/dlls/d3drm/texture.c > index 7db3ecd..883be82 100644 > --- a/dlls/d3drm/texture.c > +++ b/dlls/d3drm/texture.c > @@ -46,7 +46,7 @@ static inline struct d3drm_texture > *impl_from_IDirect3DRMTexture3(IDirect3DRMTex > > void d3drm_texture_destroy(struct d3drm_texture *texture) > { > - if (texture->d3drm && texture->initialized) > + if (texture->initialized) > IDirect3DRM_Release(texture->d3drm); > HeapFree(GetProcessHeap(), 0, texture); > } > -- > 2.3.2 (Apple Git-55) > >

1 0

Re: mode: add stub exe
by Nikolay Sivov 03 May '16

03 May '16

> +MODULE = mode.exe I don't know how important that is, but on Win7 it's called mode.com, just what bug title says. > @@ -3472,6 +3472,7 @@ WINE_CONFIG_PROGRAM(iexplore,,[install]) > WINE_CONFIG_PROGRAM(ipconfig,,[clean,install]) > WINE_CONFIG_PROGRAM(lodctr,,[install]) > WINE_CONFIG_PROGRAM(mofcomp,,[install]) > +WINE_CONFIG_PROGRAM(mode,,[install]) > WINE_CONFIG_PROGRAM(mshta,,[install]) > WINE_CONFIG_PROGRAM(msiexec,,[install,installbin,manpage]) > WINE_CONFIG_PROGRAM(net,,[clean,install]) This is not sorted.

2 1

Re: [1/2] kernel32/tests: Add more tests for GetConsoleFontInfo. (v4)
by Marvin 03 May '16

03 May '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22804 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 1301662830 console.c:1445: Test failed: [15] Expected output count to be 0, got 1301662830 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1301662830 console.c:1689: Test failed: [13] Expected output count to be 0, got 1301662830 console.c:1689: Test failed: [15] Expected output count to be 0, got 1301662830 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1301662830 === w864 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 3495556664 console.c:1445: Test failed: [15] Expected output count to be 0, got 3495556664 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3495556664 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 3495556664 console.c:1689: Test failed: [15] Expected output count to be 0, got 3495556664 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3495556664 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 4206877851 console.c:1445: Test failed: [15] Expected output count to be 0, got 4206877851 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 4206877851 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 4206877851 console.c:1689: Test failed: [15] Expected output count to be 0, got 4206877851 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 4206877851 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Re: [2/2] kernel32/tests: Add tests for SetConsoleFont. (resend)
by Marvin 03 May '16

03 May '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22805 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 3667173890 console.c:1445: Test failed: [15] Expected output count to be 0, got 3667173890 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3667173890 console.c:1689: Test failed: [13] Expected output count to be 0, got 3667173890 console.c:1689: Test failed: [15] Expected output count to be 0, got 3667173890 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3667173890 === w864 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 125638792 console.c:1445: Test failed: [15] Expected output count to be 0, got 125638792 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 125638792 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 125638792 console.c:1689: Test failed: [15] Expected output count to be 0, got 125638792 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 125638792 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 62984337 console.c:1445: Test failed: [15] Expected output count to be 0, got 62984337 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 62984337 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 62984337 console.c:1689: Test failed: [15] Expected output count to be 0, got 62984337 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 62984337 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

1 0

ntdll: Store the directory identity and search mask in the directory cache
by Piotr Caban 02 May '16

02 May '16

The patch breaks compilation on mac: directory.c:1973:42: error: expected identifier if (!has_wildcard( dir_data->->mask )) break; ^ directory.c:2164:34: error: use of undeclared identifier 'dir_data' const UNICODE_STRING *mask = dir_data->mask; ^ directory.c:2216:61: error: use of undeclared identifier 'dir_data' union file_directory_info *info = append_entry( dir_data, bu... Thanks, Piotr

1 1