May 2016 - Wine-devel - list.winehq.org

Re: [v3 PATCH] wined3d: Add missing WINED3DUSAGE flags to debug_d3dusage
by Henri Verbeet 19 May '16

19 May '16

On 18 May 2016 at 12:33, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > const char *debug_d3dusage(DWORD usage) > { > - char buf[333]; > + char buf[512]; 512 is insufficient, how did you arrive at that number?

1 0

Re: configure: Fix a typo in comments
by Nikolay Sivov 19 May '16

19 May '16

On 19.05.2016 12:13, Andrey Gusev wrote: > > --- a/configure > +++ b/configure > @@ -371,7 +371,7 @@ as_fn_executable_p () > # ---------------------- > # Append the text in VALUE to the end of the definition contained in VAR. Take > # advantage of any shell optimizations that allow amortized linear growth over > -# repeated appends, instead of the typical quadratic growth present in naive > +# repeated appends, instead of the typical quadratic growth present in native > # implementations. This is a generated part, if it had a typo it should be fixed in tools, not in Wine. For this patch, comment looks correct to me as it is.

1 0

Re: [PATCH 4/4] d3d9: Allow to pass NULL pointers to IDirect3DDevice9_GetRenderTargetData().
by Marvin 19 May '16

19 May '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23103 Your paranoid android. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: comctl32: Fix a typo in comment
by Huw Davies 19 May '16

19 May '16

On Thu, May 19, 2016 at 11:42:11AM +0300, Andrey Gusev wrote: > diff --git a/dlls/comctl32/trackbar.c b/dlls/comctl32/trackbar.c > index 8c99ad0..ba4cec3 100644 > --- a/dlls/comctl32/trackbar.c > +++ b/dlls/comctl32/trackbar.c > @@ -920,7 +920,7 @@ TRACKBAR_Refresh (TRACKBAR_INFO *infoPtr, HDC hdcDst) > > GetClientRect (infoPtr->hwndSelf, &rcClient); > > - /* try to render offscreen, if we fail, carrry onscreen */ > + /* try to render offscreen, if we fail, carry onscreen */ > hdc = CreateCompatibleDC(hdcDst); > if (hdc) { > hOffScreenBmp = CreateCompatibleBitmap(hdcDst, rcClient.right, rcClient.bottom); Apart from the fact that this comment still doesn't make sense (it should probably have an additional 'on'), I'm not sure why we have this fallback in the first place. If the dc or bitmap creation fails then we've probably got bigger problems. I'd suggest just returning early in those cases (with the appropriate cleanup). Huw.

1 0

Re: user32: Fix a typo in a comment
by Ken Thomases 18 May '16

18 May '16

On May 18, 2016, at 2:46 PM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > > Signed-off-by: Frédéric Delanoy <frederic.delanoy(a)gmail.com> > --- > dlls/user32/combo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/user32/combo.c b/dlls/user32/combo.c > index c9b969f..143d992 100644 > --- a/dlls/user32/combo.c > +++ b/dlls/user32/combo.c > @@ -416,7 +416,7 @@ static void CBCalcPlacement( > > /* > * In the case of a dropdown, the popup listbox is offset to the right. > - * so, we want to make sure it's flush with the right side of the > + * so, we want to make sure it's flushed with the right side of the > * combobox > */ > if( CB_GETTYPE(lphc) == CBS_DROPDOWN ) The original is actually correct English. "Flush" is an adjective meaning aligned. Cheers, Ken

1 0

Re: [PATCH 1/5] usp10: Resolve BNs and explicit formatting characters to the preceding level in resolveResolved().
by Marvin 18 May '16

18 May '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23083 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1433: Test failed: 0: uJustification incorrect (0) usp10.c:1433: Test failed: 1: uJustification incorrect (0) usp10.c:1433: Test failed: 2: uJustification incorrect (0) usp10.c:1433: Test failed: 3: uJustification incorrect (0) usp10.c:1433: Test failed: 4: uJustification incorrect (0) usp10.c:1433: Test failed: 5: uJustification incorrect (0) usp10.c:1433: Test failed: 6: uJustification incorrect (0) usp10.c:1433: Test failed: 7: uJustification incorrect (0) usp10.c:1433: Test failed: 8: uJustification incorrect (0) usp10.c:1433: Test failed: 9: uJustification incorrect (0) usp10.c:1449: Test failed: 3: uJustification incorrect (0) usp10.c:1449: Test failed: 5: fDiacritic incorrect (1) usp10.c:1449: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1449: Test failed: 15: fDiacritic incorrect (1) usp10.c:1449: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1433: Test failed: 0: uJustification incorrect (0) usp10.c:1433: Test failed: 1: uJustification incorrect (0) usp10.c:1433: Test failed: 2: uJustification incorrect (0) usp10.c:1433: Test failed: 3: uJustification incorrect (0) usp10.c:1433: Test failed: 4: uJustification incorrect (0) usp10.c:1433: Test failed: 5: uJustification incorrect (0) usp10.c:1433: Test failed: 6: uJustification incorrect (0) usp10.c:1433: Test failed: 7: uJustification incorrect (0) usp10.c:1433: Test failed: 8: uJustification incorrect (0) usp10.c:1433: Test failed: 9: uJustification incorrect (0) usp10.c:1449: Test failed: 3: uJustification incorrect (0) usp10.c:1449: Test failed: 5: fDiacritic incorrect (1) usp10.c:1449: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1449: Test failed: 15: fDiacritic incorrect (1) usp10.c:1449: Test failed: 15: fZeroWidth incorrect (1)

2 1

Re: [PATCH 3/6] wininet: Use compose_request_url in INTERNET_OPTION_URL implementation.
by Marvin 18 May '16

18 May '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23082 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] msvcr120/tests: Add critical section test.(resend)
by Piotr Caban 18 May '16

18 May '16

Hi, On 05/18/16 15:25, YongHao Hu wrote: > +#if _MSVCR_VER >= 110 _MSVCR_VER is not defined in tests. (I didn't look on rest of the patch yet) Thanks, Piotr

1 0

Re: [PATCH] msvcr120/tests: Add critical section test.(resend)
by Marvin 18 May '16

18 May '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23080 Your paranoid android. === w2008s64 (64 bit msvcr120) === Found no trace of the test summary line or of a crash

1 0

Re: [PATCH] user32/scroll: Move GetDCEx to stop DC leak
by Alexandre Julliard 18 May '16

18 May '16

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -920,9 +919,12 @@ static void SCROLL_HandleScrollEvent( HWND hwnd, INT nBar, UINT msg, POINT pt) > break; > > default: > + WARN("unsupported msg %s\n", SPY_GetMsgName(msg,hwnd)); > return; /* Should never happen */ > } > > + hdc = GetDCEx( hwnd, 0, DCX_CACHE | ((nBar == SB_CTL) ? 0 : DCX_WINDOW)); The function is only called for the messages it supports, so there's no need to add handling for other cases. -- Alexandre Julliard julliard(a)winehq.org

1 0