June 2016 - Wine-devel - list.winehq.org

Questions about Wine explorer.exe desktop work
by Joel Holdsworth 12 Jun '16

12 Jun '16

Dear All, I've been watching AJ's work on improving wine when running in desktop mode with respect to the task bar and start menu. I was wondering what the motivation for this work was? but it's a cool feature whatever the reason. I'm also interested in the work the ReactOS guys have been doing on reactos and shell32. To my understanding, in the last couple of years, the reactos team have expended quite some effort to faithfully replicate the behavior of shell32+explorer as seen in XP and Server 2003. This diagram shows how all the undocumented shell32 COM objects fit together: https://www.reactos.org/node/780 I was interested to see if reactos explorer.exe could run in wine, and it fails because it doesn't have the undocumented shell32 StartMenu or TaskBar COM objects. Look at AJ's patches it looks like Wine's start menu and task bar are being done in an ad-hoc way in explorer.exe; not trying to replicate shell32 COM objects. According to this document: https://svn.reactos.org/svn/reactos/trunk/reactos/media/doc/README.WINE?vie… , it seems that reactos forked shell32 in 2007. And from browsing the code, it seems a lot of it is now written in C++. It would be cool if the reactos could be moved off their fork back onto wine's version, but it seems like their shell32 might be ahead of wine's in some places. I wanted to ask suggest/ask if it would be a good idea to import or base-off-of the ROS shell32 code, convert it to C and use that for the new desktop code? It seems to me that the architecture would more closely match windows, so the ROS and Microsoft explorer.exe would then run on Wine. Also this would move us towards having the ROS and Wine explorer.exe and shell32 merged - and the ROS guys seem to care quite a lot about that stuff, so it would be good to unite the two project's efforts. Best Regards Joel Holdsworth

2 1

Re: [v2 0/1] winejoystick.drv/joystick_osx.c: fixed axes mapping, add feature support
by Alexandre Julliard 11 Jun '16

11 Jun '16

David Lawrie <david.dljunk(a)gmail.com> writes: > This patch fixes Slider and Ry/Rx axes mapping and adds support for > general multi-axis controllers (up to 6-axis controllers), steering > wheels w/ accelerators/brakes, multiple sliders/dials/wheels (up to 3), > rudder pedals, and throttles. > > Fixes: > 1) Slider now maps to Z, U, or V depending on availability > 2) Ry now maps to U > 3) Rx now maps to V > > Windows defines Winmm U as Dinput Ry and V as Dinput Rx. Original joystick_osx.c mapping was other way around. This is also a bug in the Linux Winmm joystick version (not fixed with this patch). Sliders are supposed to map to the Z-axis (or U/V axes if Z is taken). > > Adds: > > 1) Driver will find Multi-axis controller type in addition to gamepad and joystick > > 2a) In function collect_joystick_elements, under Generic Desktop page, patch adds support for multiple Sliders, Dials, and Wheels up to 3. First Slider/Dial/Wheel maps to Z, Second -> U, Third -> V. > > 2b) Patch also adds support for controller features defined by HID Simulation page: Rudder (Rz), Throttle (Z), Steering (X), Accelerator (Y), Brake (Rz). Looks good, but please send separate fixes as separate patches. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/1] winejoystick.drv/joystick_osx.c: fixed axes mapping, add feature support
by DavidL 10 Jun '16

10 Jun '16

Hi, I recently submitted a patch which had at least one whitespace formatting issue. Looking over it, I found one on line 518, a bracket in the wrong place. Is there an easy way for me to check if there are more formatting issues before resubmitting? Or should I simply resubmit? Thanks! David On Fri, Jun 10, 2016 at 7:06 AM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Formatting". > > This means that there are some formatting issues with your > patch. Either the author's full name, email address, or Signed-off-by > headers are missing, indentation is messed up (usually from editing > with a non-standard tab size), or there are gratuitous formatting > changes to the code. You need to resend a fixed patch. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email. >

2 1

Re: ucrtbase: Add __fpe_flt_rounds implementation
by Marvin 10 Jun '16

10 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23515 Your paranoid android. === wxppro (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === w2003std (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === wvistau64 (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === w7u (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === w7pro64 (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === w8 (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === w864 (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === wvistau64 (64 bit misc) === misc: unhandled exception c0000005 at 0000000000000000 === w2008s64 (64 bit misc) === misc: unhandled exception c0000005 at 0000000000000000 === w7pro64 (64 bit misc) === misc: unhandled exception c0000005 at 0000000000000000 === w864 (64 bit misc) === misc: unhandled exception c0000005 at 0000000000000000 === w1064 (64 bit misc) === misc.c:233: Test failed: __fpe_flt_rounds returned 3 misc.c:237: Test failed: __fpe_flt_rounds returned 2

1 0

Re: [PATCH v2] secur32/tests: Don't load advapi32.dll function dynamically.
by Marvin 10 Jun '16

10 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23510 Your paranoid android. === w1064 (32 bit schannel) === schannel.c:856: Test failed: Got unexpected status 0x80090308. schannel.c:864: Test failed: Got unexpected status 0x80090308. === w1064 (64 bit schannel) === schannel.c:856: Test failed: Got unexpected status 0x80090308. schannel.c:864: Test failed: Got unexpected status 0x80090308.

1 0

Re: [PATCH 3/3] msscript: Implement Language() property
by Jacek Caban 10 Jun '16

10 Jun '16

Hi Nikolay, On 06/09/2016 07:40 PM, Nikolay Sivov wrote: > static HRESULT WINAPI ScriptControl_put_Language(IScriptControl *iface, BSTR language) > { > ScriptControl *This = impl_from_IScriptControl(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_w(language)); > - return E_NOTIMPL; > + > + TRACE("(%p)->(%s)\n", This, debugstr_w(language)); > + > + if (!lstrcmpiW(language, vbscriptW)) > + This->language = LANGUAGE_VBSCRIPT; > + else if (!lstrcmpiW(language, jscriptW)) > + This->language = LANGUAGE_JSCRIPT; > + else if (!language) > + This->language = LANGUAGE_UNDEFINED; > + else > + return CTL_E_INVALIDPROPERTYVALUE; Are you sure it's limited to those two languages? It counters the point of active script technology. I don't see why it couldn't handle other registered languages. See register_script_engine from MSHTML script.c tests to see how additional languages may be added. Thanks, Jacek

1 0

Re: secur32/tests: Don't load advapi32.dll function dynamically.
by Marvin 10 Jun '16

10 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23509 Your paranoid android. === w1064 (32 bit schannel) === schannel.c:854: Test failed: Got unexpected status 0x80090308. schannel.c:862: Test failed: Got unexpected status 0x80090308. === w1064 (64 bit schannel) === schannel.c:854: Test failed: Got unexpected status 0x80090308. schannel.c:862: Test failed: Got unexpected status 0x80090308.

1 0

Re: d3d9/tests: Use wine_dbgstr_rect() to print RECTs.
by Marvin 10 Jun '16

10 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23495 Your paranoid android. === w864 (64 bit device) === device.c:4351: Test failed: cw is 0xf60, expected 0x7f. device.c:4360: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4351: Test failed: cw is 0xf60, expected 0x7f. device.c:4360: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (32 bit d3d9ex) === d3d9ex.c:2351: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2353: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2351: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2353: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2351: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2353: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2351: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2353: Test failed: Got unexpected hr 0, i=1.

2 1

Re: [PATCH 5/5] usp10: Replace zero-width glyphs with 0x20 when psa->fNoGlyphIndex is set in ScriptShapeOpenType().
by Marvin 09 Jun '16

09 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23487 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 4/5] usp10: Replace more control characters with blanks.
by Marvin 09 Jun '16

09 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23486 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0