July 2016 - Wine-devel - list.winehq.org

Re: [PATCH 01/11] mshtml/tests: Use relative URLs in navigation.js.
by Marvin 19 Jul '16

19 Jul '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24356 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

Re: [PATCH] msscript: Implement SetAdvise/GetAdvise
by Marvin 19 Jul '16

19 Jul '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24348 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: comctl32: Get rid of TOOLTIPS_SetMargin(), it is just a RECT assignment.
by Nikolay Sivov 19 Jul '16

19 Jul '16

On 19.07.2016 10:53, Michael Stefaniuc wrote: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/comctl32/tooltips.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c > index eed113e..a0c7ade 100644 > --- a/dlls/comctl32/tooltips.c > +++ b/dlls/comctl32/tooltips.c > @@ -1599,18 +1599,6 @@ TOOLTIPS_SetDelayTime (TOOLTIPS_INFO *infoPtr, DWORD duration, INT nTime) > } > > > -static LRESULT > -TOOLTIPS_SetMargin (TOOLTIPS_INFO *infoPtr, const RECT *lpRect) > -{ > - infoPtr->rcMargin.left = lpRect->left; > - infoPtr->rcMargin.right = lpRect->right; > - infoPtr->rcMargin.bottom = lpRect->bottom; > - infoPtr->rcMargin.top = lpRect->top; > - > - return 0; > -} > - > - > static inline LRESULT > TOOLTIPS_SetMaxTipWidth (TOOLTIPS_INFO *infoPtr, INT MaxWidth) > { > @@ -2261,7 +2249,8 @@ TOOLTIPS_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) > return TOOLTIPS_SetDelayTime (infoPtr, (DWORD)wParam, (INT)LOWORD(lParam)); > > case TTM_SETMARGIN: > - return TOOLTIPS_SetMargin (infoPtr, (LPRECT)lParam); > + infoPtr->rcMargin = *(RECT*)lParam; > + return 0; > > case TTM_SETMAXTIPWIDTH: > return TOOLTIPS_SetMaxTipWidth (infoPtr, (INT)lParam); > I think this needs test to see if any rectangle is accepted, for example with negative values. If we need to validate it, it's easier to do in a helper to match the rest of code.

1 0

Re: [PATCH] kernel32: Implement SetConsoleFont
by Marvin 19 Jul '16

19 Jul '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24347 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2884226813 console.c:1445: Test failed: [15] Expected output count to be 0, got 2884226813 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2884226813 console.c:1689: Test failed: [13] Expected output count to be 0, got 2884226813 console.c:1689: Test failed: [15] Expected output count to be 0, got 2884226813 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2884226813 === w864 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 1106048744 console.c:1445: Test failed: [15] Expected output count to be 0, got 1106048744 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1106048744 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 1106048744 console.c:1689: Test failed: [15] Expected output count to be 0, got 1106048744 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1106048744 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 131584522 console.c:1445: Test failed: [15] Expected output count to be 0, got 131584522 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 131584522 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 131584522 console.c:1689: Test failed: [15] Expected output count to be 0, got 131584522 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 131584522 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

1 0

Re: [1/3] wininet: Don't return available data sizes larger than the read buffer.
by Marvin 19 Jul '16

19 Jul '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24338 Your paranoid android. === w864 (64 bit http) === http.c:5309: Test failed: HttpSendRequest failed: 8

2 1

Re: [v2 1/1] dinput: Sort virtual joysticks by name on the Mac
by Ken Thomases 19 Jul '16

19 Jul '16

On Jul 18, 2016, at 1:57 AM, David Lawrie <david.dljunk(a)gmail.com> wrote: > +static CFStringRef copy_device_name(IOHIDDeviceRef device) > +{ > + CFTypeRef ref; > + CFStringRef name = NULL; > + > + if(device) Maybe didn't notice this in the previous version, but put a space between "if" and the parenthesis. > + { > + assert(IOHIDDeviceGetTypeID() == CFGetTypeID(device)); > + > + ref = IOHIDDeviceGetProperty(device, CFSTR(kIOHIDProductKey)); > + > + if (ref && CFStringGetTypeID() == CFGetTypeID(ref)) > + name = CFStringCreateCopy(kCFAllocatorDefault,ref); Please use a space after the comma in argument lists in function calls. > + else if (ref) > + name = CFCopyDescription(ref); > + else > + name = CFStringCreateCopy(kCFAllocatorDefault,CFSTR("(null)")); You don't want to fall back to a string based on the vendor and product ID? Also, the same spacing issue as above. > + } > + else > + ERR("Invalid Device requested %p\n",device); At this point, device is known to be NULL, so the log message can say that rather than the vague "invalid", and doesn't need to include its value. Or did you mean to be checking something else in the "if"? > + > + return name; > +} > + > static long get_device_location_ID(IOHIDDeviceRef device) > { > return get_device_property_long(device, CFSTR(kIOHIDLocationIDKey)); > @@ -203,7 +227,18 @@ static void copy_set_to_array(const void *value, void *context) > CFArrayAppendValue(context, value); > } > > -static CFComparisonResult device_location_comparator(const void *val1, const void *val2, void *context) > +static CFComparisonResult device_name_comparator(IOHIDDeviceRef device1, IOHIDDeviceRef device2) > +{ > + CFStringRef name1 = copy_device_name(device1), name2 = copy_device_name(device2); > + CFComparisonResult result = CFStringCompare(name1, name2, (kCFCompareForcedOrdering | kCFCompareNumerically)); > + if(name1) > + CFRelease(name1); > + if(name2) > + CFRelease(name2); If name1 or name2 might be NULL as these tests imply, then what does the preceding CFStringCompare() call do? Probably crashes. So, either assume/assure that copy_device_name() doesn't return NULL in normal operation or handle the possibility that it might more thoroughly. -Ken

2 2

Re: [PATCH 1/2] msctf: Don't crash on NULL input in EnumLanguageProfiles().
by Marvin 19 Jul '16

19 Jul '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24335 Your paranoid android. === w864 (32 bit inputprocessor) === inputprocessor.c:834: Test failed: Deactivation came unexpectedly

2 1

Re: shell32: add SHGetPropertyStoreForWindow stub (try 2)
by Nikolay Sivov 19 Jul '16

19 Jul '16

> +HRESULT WINAPI SHGetPropertyStoreForWindow(HWND hwnd, REFIID riid, void **ppv) > +{ > + FIXME("(%p %p %p) stub!\n", hwnd, riid, ppv); > + return E_NOTIMPL; > +} Not very important, but riid could be traced.

1 0

Re: [PATCH 7/7] d3d11/tests: Add test for bitwise shader instructions.
by Józef Kucia 19 Jul '16

19 Jul '16

On Mon, Jul 18, 2016 at 1:27 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + return uint4(~bits[0], ~(bits[0] & ~0u), ~bits[1], ~(bits[1] & ~0u)); This is a mistake. It should read "return uint4(~bits[0], ~(bits[0] ^ ~0u), ~bits[1], ~(bits[1] ^ ~0u));".

1 0

Re: [v2 1/1] winejoystick.drv: Sort virtual joysticks by name on the Mac
by Ken Thomases 19 Jul '16

19 Jul '16

On Jul 18, 2016, at 1:57 AM, David Lawrie <david.dljunk(a)gmail.com> wrote: > > Tested on OS X 10.10.5. > > Signed-off-by: David Lawrie <david.dljunk(a)gmail.com> > --- > dlls/winejoystick.drv/joystick_osx.c | 49 ++++++++++++++++++++++++++++++++---- > 1 file changed, 44 insertions(+), 5 deletions(-) Same comments as for the dinput version. -Ken

1 0