July 2016 - Wine-devel - list.winehq.org

Re: [PATCH 3/5] d3d10core/tests: Add test for vertex formats.
by Marvin 09 Jul '16

09 Jul '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24113 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] d3d11/tests: Add test for vertex formats.
by Marvin 09 Jul '16

09 Jul '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24112 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/3] wininet/tests: Add a test for recently introduced regression related to InternetCrackUrl.
by Marvin 09 Jul '16

09 Jul '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24111 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/3] wininet/tests: Avoid unnecessary initialization of variables.
by Marvin 09 Jul '16

09 Jul '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24110 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/3] wininet: Correctly set lpszUrlPath in InternetCrackUrlW for urls without path component.
by Marvin 09 Jul '16

09 Jul '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24109 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: gdi32: Remove unused function.
by Sebastian Lackner 08 Jul '16

08 Jul '16

On 08.07.2016 12:25, Huw Davies wrote: > Signed-off-by: Huw Davies <huw(a)codeweavers.com> > --- > dlls/gdi32/region.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/dlls/gdi32/region.c b/dlls/gdi32/region.c > index 0b0ff47..1e10221 100644 > --- a/dlls/gdi32/region.c > +++ b/dlls/gdi32/region.c > @@ -149,11 +149,6 @@ static inline void empty_region( WINEREGION *reg ) > reg->extents.left = reg->extents.top = reg->extents.right = reg->extents.bottom = 0; > } > > -static inline BOOL is_in_rect( const RECT *rect, int x, int y ) > -{ > - return (rect->right > x && rect->left <= x && rect->bottom > y && rect->top <= y); > -} > - > /* > * number of points to buffer before sending them off > * to scanlines() : Must be an even number > I assume it was intentional to remove the is_in_rect() check from PtInRegion, but is it really such a good idea? For points outside of the extents rectangle it increased runtime from O(1) to O(log N), which could still matter in practice.

2 1

Re: gdi32: Optionally return the type from GDI_GetObjPtr().
by Dmitry Timoshkov 08 Jul '16

08 Jul '16

Huw Davies <huw(a)codeweavers.com> wrote: > This enables get_dc_obj() to check the type without calling GetObjectType() > and thus it saves additional calls to Enter/LeaveCriticalSection(). > > Signed-off-by: Huw Davies <huw(a)codeweavers.com> > --- > This reduces the runtime of the dib tests by about 8% and achieves a similar > increase in performance with the drawing phase of a (gdi heavy) app I'm > looking at. ... > - bmp = GDI_GetObjPtr( hbitmap, OBJ_BITMAP ); > + bmp = GDI_GetObjPtr( hbitmap, OBJ_BITMAP, NULL ); Did you consider introducing GDI_GetObjPtrEx() with additional pointer to type, and making a shortcut by defining/calling it by a not Ex version? That would simplify the patch and avoid penalizing/changing the callers that don't need the type. -- Dmitry.

3 3

Re: [v3] riched20: Add support for ECO_NOHIDESEL flag
by Huw Davies 08 Jul '16

08 Jul '16

On Fri, Jul 08, 2016 at 12:32:55PM +0200, Piotr Caban wrote: > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/riched20/editor.c | 9 +++++++-- > dlls/riched20/paint.c | 6 ++++-- > 2 files changed, 11 insertions(+), 4 deletions(-) > > > diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c > index 13a2857..cb6fe3d 100644 > --- a/dlls/riched20/editor.c > +++ b/dlls/riched20/editor.c > @@ -3453,14 +3453,15 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, > ME_RewrapRepaint(editor); > } > > + if ((changedSettings & settings & ECO_NOHIDESEL) && !editor->bHaveFocus) > + ME_InvalidateSelection( editor ); > + Actually on reflection, I think comparing with ES_NOHIDESEL is slightly less confusing, so let's go with v2. Huw.

1 0

Re: riched20: Add support for ECO_NOHIDESEL flag
by Huw Davies 08 Jul '16

08 Jul '16

On Fri, Jul 08, 2016 at 11:34:11AM +0200, Piotr Caban wrote: > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > > This patch also fixes control behavior when ECO_NOHIDESEL is not specified > and the control looses focus (for bug 40915). > --- > dlls/riched20/editor.c | 9 +++++++-- > dlls/riched20/paint.c | 6 ++++-- > 2 files changed, 11 insertions(+), 4 deletions(-) > > > diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c > index 13a2857..b7864eb 100644 > --- a/dlls/riched20/editor.c > +++ b/dlls/riched20/editor.c > @@ -3453,14 +3453,15 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, > ME_RewrapRepaint(editor); > } > > + if ((changedSettings & settings & ECO_NOHIDESEL) && !editor->bHaveFocus) > + ME_InvalidateSelection( editor ); > + > if (changedSettings & settings & ECO_VERTICAL) > FIXME("ECO_VERTICAL not implemented yet!\n"); > if (changedSettings & settings & ECO_AUTOHSCROLL) > FIXME("ECO_AUTOHSCROLL not implemented yet!\n"); > if (changedSettings & settings & ECO_AUTOVSCROLL) > FIXME("ECO_AUTOVSCROLL not implemented yet!\n"); > - if (changedSettings & settings & ECO_NOHIDESEL) > - FIXME("ECO_NOHIDESEL not implemented yet!\n"); > if (changedSettings & settings & ECO_WANTRETURN) > FIXME("ECO_WANTRETURN not implemented yet!\n"); > if (changedSettings & settings & ECO_AUTOWORDSELECTION) > @@ -4257,6 +4258,8 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, > editor->bHaveFocus = TRUE; > ME_ShowCaret(editor); > ME_SendOldNotify(editor, EN_SETFOCUS); > + if (!editor->bHideSelection && !(editor->styleFlags & ECO_NOHIDESEL)) I think this, and all subsequent ECO_NOHIDESELs, would be better as ES_NOHIDESEL. The first one is fine as ECO_NOHIDESEL, since that's the setting one. Huw.

2 3

Re: [PATCH 02/12] d3drm: Move d3drm_device struct to d3drm_private.h.
by Aaryaman Vasishta 08 Jul '16

08 Jul '16

> > +struct d3drm_device > +{ > + IDirect3DRMDevice IDirect3DRMDevice_iface; > + IDirect3DRMDevice2 IDirect3DRMDevice2_iface; > + IDirect3DRMDevice3 IDirect3DRMDevice3_iface; > + IDirect3DRMWinDevice IDirect3DRMWinDevice_iface; > + IDirect3DRM *d3drm; > + IDirectDraw *ddraw; > + IDirectDrawSurface *primary_surface, *render_target; > + IDirectDrawClipper *clipper; > + IDirect3DDevice *device; > + LONG ref; > + BOOL dither; > + D3DRMRENDERQUALITY quality; > + DWORD rendermode; > + DWORD height; > + DWORD width; > +}; > + > > I should remove the current forward declaration now that this patch moves the definition here.

1 0