August 2016 - Wine-devel - list.winehq.org

Re: [PATCH 2/9] d3d8/tests: Add test for regression in IDirect3DDevice8_Reset().
by Marvin 15 Aug '16

15 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25060 Your paranoid android. === w864 (32 bit device) === device.c:1374: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1416: Test failed: Reset failed, hr 0x88760868. device.c:1418: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1422: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1427: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1428: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1429: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1430: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1431: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1432: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1436: Test failed: Screen width is 640, expected 800. device.c:1437: Test failed: Screen height is 480, expected 600. device.c:1443: Test failed: Back buffer width is 640, expected 800. device.c:1445: Test failed: Back buffer height is 480, expected 600. device.c:1472: Test failed: Screen width is 640, expected 1024. device.c:1473: Test failed: Screen height is 480, expected 768. device.c:1501: Test failed: Reset failed, hr 0x80070057. device.c:1503: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1515: Test failed: D3DVIEWPORT->Width = 400. device.c:1516: Test failed: D3DVIEWPORT->Height = 300. device: unhandled exception c0000005 at 75095D5B

2 1

Re: [PATCH] [preloader] Add proper CFI instructions to _start functions
by Alexandre Julliard 15 Aug '16

15 Aug '16

Keno Fischer <keno(a)juliacomputing.com> writes: > diff --git a/loader/preloader.c b/loader/preloader.c > index db0e998..8a86311 100644 > --- a/loader/preloader.c > +++ b/loader/preloader.c > @@ -212,6 +212,7 @@ struct > void _start(void); > extern char _end[]; > __ASM_GLOBAL_FUNC(_start, > + "\t.cfi_undefined %eip\n" > "\tmovl $243,%eax\n" /* SYS_set_thread_area */ > "\tmovl $thread_ldt,%ebx\n" > "\tint $0x80\n" /* allocate gs segment */ Looks OK, but it would need to be wrapped with the __ASM_CFI macro. Also could you please make sure to include your signoff? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v6)
by Henri Verbeet 15 Aug '16

15 Aug '16

On 12 August 2016 at 01:09, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + IDirect3DRMFrame3_AddRef(*scene = &frame->IDirect3DRMFrame3_iface); Actually, sorry, you probably shouldn't do that in d3drm. The d3drm headers are written by hand, so IDirect3DRMFrame3_AddRef() is a macro instead of an inline function. That means that when this expands the assignment happens twice.

2 3

Re: [PATCH v4 1/3] shell32/tests: Add more tests for FolderItems.
by Alex Henrie 15 Aug '16

15 Aug '16

2016-08-14 22:20 GMT-06:00 Alex Henrie <alexhenrie24(a)gmail.com>: > v4 does not include any tests that are not necessary to demonstrate the > correctness of the FolderItems_Item implementation. This makes the > patches much smaller, and hopefully more likely to be accepted. I have > also simplified the test for FolderItems_Item with VT_ERROR, and I've > added a small test to show that FolderItems_Item doesn't accept VT_BSTR > file names. Crud, I just realized that FolderItems_Item does accept VT_BSTR file names after all. I thought I'd tested this, sorry. Please do not ignore this patchset for another 3 weeks because of this mistake. -Alex

1 0

Re: [PATCH v4 3/3] shell32: Implement FolderItems_get_Count.
by Marvin 14 Aug '16

14 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25033 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w2003std (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === wvistau64 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w2008s64 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w7u (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w7pro64 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w8 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w864 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w1064 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === wvistau64 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w2008s64 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w7pro64 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w864 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w1064 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null

1 0

Re: [PATCH v4 2/3] shell32: Implement FolderItems_Item.
by Marvin 14 Aug '16

14 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25032 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w2003std (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === wvistau64 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w2008s64 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w7u (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w7pro64 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w8 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w864 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w1064 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === wvistau64 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w2008s64 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w7pro64 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w864 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w1064 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null

1 0

Re: [PATCH v4 1/3] shell32/tests: Add more tests for FolderItems.
by Marvin 14 Aug '16

14 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25031 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w2003std (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === wvistau64 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w2008s64 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w7u (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w7pro64 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w8 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w864 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w1064 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === wvistau64 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w2008s64 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w7pro64 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w864 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w1064 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null

1 0

Re: [PATCH] po: Update Simplified Chinese translation (v2).
by Jactry Zeng 14 Aug '16

14 Aug '16

Hi, It looks good to me. Thanks for your contribution! :) 2016-08-14 21:52 GMT+08:00 Mingcong Bai <jeffbaichina(a)gmail.com>: > Reverted a translated string to the existing upstream translation, and > unmarked two extra fuzzies. > > Signed-off-by: Mingcong Bai <jeffbai(a)aosc.xyz> > --- > po/zh_CN.po | 927 ++++++++++++++++++++++++++++++ > +----------------------------- > 1 file changed, 477 insertions(+), 450 deletions(-) > > > > > -- Regards, Jactry Zeng

1 0

Where is winegstreamer used?
by Bruno Jesus 13 Aug '16

13 Aug '16

After looking for gstreamer related source code in Wine I could not find a place that calls winegstreamer to actually do something like video/audio decode/output. I think it should be somewhere amstream/quartz related but I'm not sure. My question is basically what I need to do (preferably with source example or documentation) to get a mpg movie to play and that ends up using winegstreamer, for example. For example with AVI files I can simply do some avifil32/msvfw32 calls and get the video output to a window. Thanks in advance, Bruno

3 5

Re: [PATCH 1/2] dwrite: Sanitize specified stretch value, valid range is [1, 9]
by Ken Thomases 13 Aug '16

13 Aug '16

On Aug 13, 2016, at 4:47 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/dwrite/opentype.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/dwrite/opentype.c b/dlls/dwrite/opentype.c > index b35f1df..ff23f51 100644 > --- a/dlls/dwrite/opentype.c > +++ b/dlls/dwrite/opentype.c > @@ -1291,8 +1291,9 @@ void opentype_get_font_properties(struct file_stream_desc *stream_desc, struct d > USHORT version = GET_BE_WORD(tt_os2->version); > USHORT fsSelection = GET_BE_WORD(tt_os2->fsSelection); > USHORT usWeightClass = GET_BE_WORD(tt_os2->usWeightClass); > + USHORT usWidthClass = GET_BE_WORD(tt_os2->usWidthClass); > > - if (GET_BE_WORD(tt_os2->usWidthClass) <= DWRITE_FONT_STRETCH_ULTRA_EXPANDED) > + if (usWidthClass > DWRITE_FONT_STRETCH_UNDEFINED && usWidthClass <= DWRITE_FONT_STRETCH_ULTRA_EXPANDED) > props->stretch = GET_BE_WORD(tt_os2->usWidthClass); Shouldn't you use the new usWidthClass variable in the assignment here, too? -Ken

1 0