August 2016 - Wine-devel - list.winehq.org

Re: [PATCH 3/3] d3drm: Implement IDirect3DRMViewport*::Clear. (v3)
by Henri Verbeet 09 Aug '16

09 Aug '16

On 9 August 2016 at 03:20, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > v2: Remove some redundancies and add more tests. Handling of Clear without depth surface is still a bit weird as wined3d_device_clear seems to return an error on a device with no depth surface since the start vs device whose depth surface was deleted after it was created, in which case it (oddly) returns successfully, even having access to and successfully clearing the depth surface. > What does "deleted" and "surface" mean in the above? If it's just releasing the references to the depth/stencil texture and view, note that the device state keeps a reference to view that wouldn't be released until you set a different view or NULL.

2 1

Re: [PATCH 1/3] d3drm: Store reference to render target in IDirect3DRM*::CreateDeviceFromD3D.
by Henri Verbeet 09 Aug '16

09 Aug '16

On 9 August 2016 at 03:16, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 1abaed5..2c82ecb 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -4572,7 +4572,7 @@ static void test_create_device_from_d3d1(void) > ref3 = get_refcount((IUnknown *)d3drm1); > ok(ref3 > ref2, "expected ref3 > ref1, got ref1 = %u , ref3 = %u.\n", ref1, ref3); > ref3 = get_refcount((IUnknown *)temp_d3ddevice1); > - ok(ref3 == device_ref2, "Expected ref3 == device_ref2, got ref3 = %u, device_ref2 = %u.\n", ref3, device_ref2); > + todo_wine ok(ref3 == device_ref2, "Expected ref3 == device_ref2, got ref3 = %u, device_ref2 = %u.\n", ref3, device_ref2); So what does this patch fix?

2 1

Re: imm32, user32: Create and destroy the default IME window implicitly. (try 9)
by Alexandre Julliard 09 Aug '16

09 Aug '16

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > Try 9: > - Withdraw try 8 changes as we have ImmDisableIME now. > - Rebased and resolve conflicts against ImmDisableIME patch. This is still breaking some tests: ../../../tools/runtest -q -P wine -T ../../.. -M ole32.dll -p ole32_test.exe.so compobj && touch compobj.ok compobj.c:2618: Test failed: CoWaitForMultipleHandles unexpectedly pumped messages make: *** [compobj.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] usp10: Better implementation for ScriptGetLogicalWidths()
by Marvin 09 Aug '16

09 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24886 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

[RFC PATCH 2/2] programs/services: Load device drivers of the same group into the same winedevice process
by Aric Stewart 09 Aug '16

09 Aug '16

--- programs/services/services.c | 112 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 112 insertions(+)

1 0

[RFC PATCH 1/2] programs/services: Break services into Loader groups
by Aric Stewart 09 Aug '16

09 Aug '16

Sort the groups by the service's tag to start in order --- programs/services/services.c | 101 ++++++++++++++++++++++++++++++++----------- 1 file changed, 75 insertions(+), 26 deletions(-)

1 0

[RFC PATCH 2/2] programs/winedevice: Dynamically load devices into group device
by Aric Stewart 09 Aug '16

09 Aug '16

Signed-off-by: Aric Stewart <aric(a)codeweavers.com> --- programs/winedevice/device.c | 55 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 54 insertions(+), 1 deletion(-)

1 0

[RFC PATCH 1/2] programs/winedevice.exe: allow loading multiple devices on the command line
by Aric Stewart 09 Aug '16

09 Aug '16

Signed-off-by: Aric Stewart <aric(a)codeweavers.com> --- programs/winedevice/device.c | 92 ++++++++++++++++++++++++++++++++++++-------- 1 file changed, 75 insertions(+), 17 deletions(-)

1 0

Re: [PATCH] advapi32: Allow for sending extended control events to services
by Sebastian Lackner 09 Aug '16

09 Aug '16

On 08.08.2016 17:41, Aric Stewart wrote: > > This allows dwEventType and lpEventData parameters to be sent > > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/advapi32/service.c | 36 ++++++++++++++++++++++++++++-------- > include/wine/svcctl.idl | 11 ++++++++++- > 2 files changed, 38 insertions(+), 9 deletions(-) > It might be useful to validate the parameters received from the control pipe before assuming its safe to access the data. The existing code is also not really perfect yet, however it wouldn't hurt to add some checks. Nevertheless, even more important, it would also be good to combine this in a series with the corresponding programs/services part, so that it can be tested and we are sure this is the right way to solve it. Best regards, Sebastian

2 1

Re: [PATCH] msvcp140/tests: Initial tests for thread functions
by Piotr Caban 09 Aug '16

09 Aug '16

Hi Nikolay, On 08/08/16 23:26, Nikolay Sivov wrote: > + ret = p__Thrd_create(&ta, thrd_thread, NULL); > + ok(!ret, "failed to create thread, got %d\n", ret); > + ret = p__Thrd_detach(ta); > + ok(!ret, "_Thrd_detach failed, got %d\n", ret); Could you please duplicate the thread handle and wait for the thread to finish before exiting the tests? It would be nice to also change the msvcp120 tests this way. Thanks, Piotr

1 0